Add a teams_are_normal function to TSN.XML.Weather.

[dead/htsn-import.git] / src / Main.hs

diff --git a/src/Main.hs b/src/Main.hs
index 0b6dce631166ef83c06d8be345810e0277893d57..cb4bdffbe5e61f4ff8045e701310693944ff9dd2 100644 (file)
--- a/src/Main.hs
+++ b/src/Main.hs
@@ -57,11 +57,19 @@ import qualified TSN.XML.Injuries as Injuries ( dtd, pickle_message )
 import qualified TSN.XML.InjuriesDetail as InjuriesDetail (
   dtd,
   pickle_message )
+import qualified TSN.XML.JFile as JFile ( dtd, pickle_message )
 import qualified TSN.XML.News as News ( dtd, pickle_message )
 import qualified TSN.XML.Odds as Odds ( dtd, pickle_message )
+import qualified TSN.XML.ScheduleChanges as ScheduleChanges (
+  dtd,
+  pickle_message )
 import qualified TSN.XML.Scores as Scores ( dtd, pickle_message )
 import qualified TSN.XML.SportInfo as SportInfo ( dtds, parse_xml )
-import qualified TSN.XML.Weather as Weather ( dtd, pickle_message )
+import qualified TSN.XML.Weather as Weather (
+  dtd,
+  is_type1,
+  pickle_message,
+  teams_are_normal )
 import Xml ( DtdName(..), parse_opts )
 
 
@@ -92,7 +100,7 @@ import_file cfg path = do
       report_error $ "Unable to determine DTD for file " ++ path ++ "."
       return False
     (ImportFailed errmsg:_) -> do
-      report_error errmsg
+      report_error $ errmsg ++ " (" ++ path ++ ")"
       return False
     (ImportSkipped infomsg:_) -> do
       -- We processed the message but didn't import anything. Return
@@ -163,41 +171,56 @@ import_file cfg path = do
           --
           migrate_and_import m = dbmigrate m >> dbimport m
 
+          -- | The error message we return if unpickling fails.
+          --
+          errmsg = "Could not unpickle " ++ dtd ++ "."
+
+          -- | Try to migrate and import using the given pickler @f@;
+          --   if it works, return the result. Otherwise, return an
+          --   'ImportFailed' along with our error message.
+          --
+          go f = maybe
+                   (return $ ImportFailed errmsg)
+                   migrate_and_import
+                   (unpickleDoc f xml)
+
           importer
-            | dtd == AutoRacingResults.dtd = do
-               let m = unpickleDoc AutoRacingResults.pickle_message xml
-               maybe (return $ ImportFailed errmsg) migrate_and_import m
+            | dtd == AutoRacingResults.dtd =
+                go AutoRacingResults.pickle_message
+
+            | dtd == AutoRacingSchedule.dtd =
+                go AutoRacingSchedule.pickle_message
 
-            | dtd == AutoRacingSchedule.dtd = do
-               let m = unpickleDoc AutoRacingSchedule.pickle_message xml
-               maybe (return $ ImportFailed errmsg) migrate_and_import m
+            -- GameInfo and SportInfo appear last in the guards
+            | dtd == Injuries.dtd = go Injuries.pickle_message
 
-            -- GameInfo and SportInfo appear least in the guards
-            | dtd == Injuries.dtd = do
-               let m = unpickleDoc Injuries.pickle_message xml
-               maybe (return $ ImportFailed errmsg) migrate_and_import m
+            | dtd == InjuriesDetail.dtd = go InjuriesDetail.pickle_message
 
-            | dtd == InjuriesDetail.dtd = do
-                let m = unpickleDoc InjuriesDetail.pickle_message xml
-                maybe (return $ ImportFailed errmsg) migrate_and_import m
+            | dtd == JFile.dtd = go JFile.pickle_message
 
+            | dtd == News.dtd = go News.pickle_message
 
-            | dtd == News.dtd = do
-                let m = unpickleDoc News.pickle_message xml
-                maybe (return $ ImportFailed errmsg) migrate_and_import m
+            | dtd == Odds.dtd = go Odds.pickle_message
 
-            | dtd == Odds.dtd = do
-                let m = unpickleDoc Odds.pickle_message xml
-                maybe (return $ ImportFailed errmsg) migrate_and_import m
+            | dtd == ScheduleChanges.dtd = go ScheduleChanges.pickle_message
 
-            | dtd == Scores.dtd = do
-                let m = unpickleDoc Scores.pickle_message xml
-                maybe (return $ ImportFailed errmsg) migrate_and_import m
+            | dtd == Scores.dtd = go Scores.pickle_message
 
-            -- SportInfo and GameInfo appear least in the guards
-            | dtd == Weather.dtd = do
-                let m = unpickleDoc Weather.pickle_message xml
-                maybe (return $ ImportFailed errmsg) migrate_and_import m
+            -- SportInfo and GameInfo appear last in the guards
+            | dtd == Weather.dtd =
+                -- Some of the weatherxml docs are busted in predictable ways.
+                -- We want them to "succeed" so that they're deleted.
+                -- We already know we can't parse them.
+                if Weather.is_type1 xml
+                then if Weather.teams_are_normal xml
+                     then go Weather.pickle_message
+                     else do
+                       let msg = "Teams in reverse order in weatherxml.dtd" ++
+                                 " (" ++ path ++ ")"
+                       return $ ImportUnsupported msg
+                else do
+                  let msg = "Unsupported weatherxml.dtd type (" ++ path ++ ")"
+                  return $ ImportUnsupported msg
 
             | dtd `elem` GameInfo.dtds = do
                 let either_m = GameInfo.parse_xml dtd xml
@@ -220,8 +243,6 @@ import_file cfg path = do
                     "Unrecognized DTD in " ++ path ++ ": " ++ dtd ++ "."
               return $ ImportUnsupported infomsg
 
-            where
-              errmsg = "Could not unpickle " ++ dtd ++ "."
 
 
 -- | Entry point of the program. It twiddles some knobs for