Add -Wall and fix warnings.

diff --git a/makefile b/makefile
index d6be6c5a2e589ed8a74153be6199128b14957e42..ffe3a9ea4a72866abd0e354a0dd2e028eb10af46 100644 (file)
--- a/makefile
+++ b/makefile
@@ -1,5 +1,5 @@
 CC = gcc
-CFLAGS = -O2 -march=native -pipe
+CFLAGS = -O2 -march=native -pipe -Wall
 LIBS = -lacl
 
 SOURCES := $(shell find ./src -type f -name '*.c')

diff --git a/src/aclq.c b/src/aclq.c
index 6ea2e1dd7ba0e3d7e9c2b22d02716fbe4ed6608b..9e456e485babbe3e065336c1a75a404adbd7c453 100644 (file)
--- a/src/aclq.c
+++ b/src/aclq.c
@@ -9,6 +9,7 @@
 #include <unistd.h>
 
 /* ACLs */
+#include <acl/libacl.h> /* acl_get_perm, not portable */
 #include <sys/types.h>
 #include <sys/acl.h>
 
@@ -297,7 +298,7 @@ bool reapply_default_acl(const char* path) {
   /* dirname mangles its argument */
   char path_copy[PATH_MAX];
   strncpy(path_copy, path, PATH_MAX-1);
-  path_copy[PATH_MAX] = 0;
+  path_copy[PATH_MAX-1] = 0;
 
   char* parent = dirname(path_copy);
   if (!is_directory(parent)) {
@@ -348,7 +349,7 @@ bool reapply_default_acl(const char* path) {
 
   /* For the group bits, we'll use the ACL's mask instead of the group
      object bits. If the default ACL had a group entry, it should
-     already have propagated (but might be masked. */
+     already have propagated (but might be masked). */
   if (has_default_mask_read(parent)) {
     path_mode |= S_IRGRP;
   }