Fix hlint warnings.

[haeredes.git] / src / Main.hs

diff --git a/src/Main.hs b/src/Main.hs
index d425734c275404e24310edb650ac33c9b4fe0b67..4da383352360ee4a37a552805a5da88897c27c4f 100644 (file)
--- a/src/Main.hs
+++ b/src/Main.hs
@@ -4,6 +4,7 @@ where
 import Control.Concurrent.ParallelIO.Global (
   parallel,
   stopGlobalPool )
+import Control.Monad (unless)
 import qualified Data.ByteString.Char8 as BS (
   getContents,
   pack,
@@ -16,30 +17,33 @@ import Network.DNS (
   FileOrNumericHost(RCHostName),
   ResolvConf(resolvInfo),
   defaultResolvConf,
-  lookupNS,
   makeResolvSeed,
   withResolver )
 
 import CommandLine (Args(..), get_args)
-import DNS (normalize)
+import DNS (
+  LookupResult,
+  lookupMX',
+  lookupNS',
+  normalize )
 
 report :: (Domain, Maybe [Domain]) -> IO ()
 report (d, Nothing) =
   putStrLn $ "Domain " ++ (show d) ++ " not delegated."
 report (d, Just leftovers) =
-  if null leftovers
-  then return ()
-  else putStrLn $ "Domain " ++
-                  (show d) ++
-                  " delegates somewhere else: " ++
-                  (join " " (map show leftovers))
+  unless (null leftovers) $
+    putStrLn $ "Domain " ++
+               (show d) ++
+               " delegates somewhere else: " ++
+               (join " " (map show leftovers))
 
 clean :: [Domain] -- ^ List of delegates, @ds@
-      -> (Domain, Maybe [Domain]) -- ^ Pairs of (domain name, lookup result)
-      -> (Domain, Maybe [Domain])
+      -> LookupResult
+      -> LookupResult
 clean _ p@(_, Nothing) = p
-clean ds (d, Just targets) =
-  (d, Just $ targets \\ ds)
+clean delgts (d, Just targets) =
+  (d, Just $ targets \\ delgts)
+
 
 
 main :: IO ()
@@ -64,20 +68,16 @@ main = do
              Just s -> defaultResolvConf { resolvInfo = RCHostName s }
 
   rs <- makeResolvSeed rc
-  withResolver rs $ \resolver -> do
-    -- This function keeps the domain matches with its NS records.
-    let lookupNS' = \d -> (lookupNS resolver d) >>= (return . ((,) d))
-
-    -- Bad stuff happens if we try to run these lookups in parallel
-    -- instead of the reports.
-    domains_ns <- mapM lookupNS' nrml_domains
-    let cdns = map (clean nrml_delegates) domains_ns
-
-    _ <- case cfg of
-           (NS _ _) ->
-             -- We're only checking NS records, so report what we found.
-             parallel (map report cdns)
-           (MX _ _) ->
-             return [()]
-
-    stopGlobalPool
+
+  let lookup_function = case cfg of
+                          (NS _ _) -> lookupNS'
+                          (MX _ _) -> lookupMX'
+
+  _ <- withResolver rs $ \resolver -> do
+         -- Bad stuff happens if we try to run these lookups in parallel
+         -- instead of the reports.
+         records <- mapM (lookup_function resolver) nrml_domains
+         let cleaned_records = map (clean nrml_delegates) records
+         parallel (map report cleaned_records)
+
+  stopGlobalPool