Remove the "math domain error" TODO, addressed by twiddling MAX_COND.

[dunshire.git] / TODO

diff --git a/TODO b/TODO
index afcffc533072cba19efd7ee027ee1e91fc11079d..d75812b661d629579e74e9a564edc4b79c35815b 100644 (file)
--- a/TODO
+++ b/TODO
@@ -79,31 +79,6 @@
       [0.0000000]
 
 
-6. Fix the math domain errors that sometimes pop up:
-
-  ERROR: test_scaling_icecream (test.symmetric_linear_game_test
-                                .SymmetricLinearGameTest)
-  ----------------------------------------------------------------------
-  Traceback (most recent call last):
-    File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py",
-    line 336, in test_scaling_icecream
-      self.assert_scaling_works(L, K, e1, e2)
-    File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py",
-    line 317, in assert_scaling_works
-      value2 = game2.solution().game_value()
-    File "/home/mjo/src/dunshire/dunshire/games.py", line 428, in solution
-      soln_dict = solvers.conelp(c, G, h, C.cvxopt_dims(), A, b)
-    File "/usr/lib64/python3.4/site-packages/cvxopt/coneprog.py", line 1395,
-    in conelp
-      misc.update_scaling(W, lmbda, ds, dz)
-    File "/usr/lib64/python3.4/site-packages/cvxopt/misc.py", line 510,
-    in update_scaling
-      ln = jnrm2(lmbda, n = m, offset = ind)
-    File "/usr/lib64/python3.4/site-packages/cvxopt/misc.py", line 856, in jnrm2
-      return math.sqrt(x[offset] - a) * math.sqrt(x[offset] + a)
-  ValueError: math domain error
-
-
 7. Figure out why this happens, too:
 
   FAIL: test_scaling_icecream (test.symmetric_linear_game_test
@@ -138,36 +113,6 @@
   AssertionError: False is not true
 
 
-8. Fix floating point comparisons in the doctest output.
-
-10. Sometimes our Lyapunov-like tests over the ice cream cone are
-    failing badly. For example,
-
-  FAIL: test_lyapunov_icecream (test.symmetric_linear_game_test
-                                .SymmetricLinearGameTest)
-  ----------------------------------------------------------------------
-  Traceback (most recent call last):
-    File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py",
-    line 620, in test_lyapunov_icecream
-      self.assert_lyapunov_works(G)
-    File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py",
-    line 578, in assert_lyapunov_works
-      self.assertTrue(negative_stable)
-  AssertionError: False is not true
-
-
-    We should have a matrix L that is negative stable, but its eigenvalues
-    are actually,
-
-      [0.8991268260361707,
-       0.8991268260361707,
-       -1.4648148562918966,
-       3.2630685083642352,
-       0.8991268260361712]
-
-11. Complete the unit tests for the matrices module. We still need to
-    document it, and finish adding all of the tests.
-
 12. Investigate this test failure too. It looks like it was really
     close to being solved, but we would have needed a fudge factor
     of three instead of two.
@@ -222,5 +167,5 @@
        [ 0.0000002]
        [ 1.3406728]
 
-
-13. Add game payoff(x,y) method to check solutions.
+13. Add a test to ensure that if we solve the same game twice, we get the
+    same answer back.