]> gitweb.michael.orlitzky.com - dunshire.git/commitdiff
Remove the "math domain error" TODO, addressed by twiddling MAX_COND.
authorMichael Orlitzky <michael@orlitzky.com>
Wed, 9 Nov 2016 14:36:39 +0000 (09:36 -0500)
committerMichael Orlitzky <michael@orlitzky.com>
Sun, 13 Nov 2016 20:19:25 +0000 (15:19 -0500)
TODO

diff --git a/TODO b/TODO
index 3febfcd9149d0f4e8b13999e618dc66f11efd121..d75812b661d629579e74e9a564edc4b79c35815b 100644 (file)
--- a/TODO
+++ b/TODO
       [0.0000000]
 
 
-6. Fix the math domain errors that sometimes pop up:
-
-  ERROR: test_scaling_icecream (test.symmetric_linear_game_test
-                                .SymmetricLinearGameTest)
-  ----------------------------------------------------------------------
-  Traceback (most recent call last):
-    File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py",
-    line 336, in test_scaling_icecream
-      self.assert_scaling_works(L, K, e1, e2)
-    File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py",
-    line 317, in assert_scaling_works
-      value2 = game2.solution().game_value()
-    File "/home/mjo/src/dunshire/dunshire/games.py", line 428, in solution
-      soln_dict = solvers.conelp(c, G, h, C.cvxopt_dims(), A, b)
-    File "/usr/lib64/python3.4/site-packages/cvxopt/coneprog.py", line 1395,
-    in conelp
-      misc.update_scaling(W, lmbda, ds, dz)
-    File "/usr/lib64/python3.4/site-packages/cvxopt/misc.py", line 510,
-    in update_scaling
-      ln = jnrm2(lmbda, n = m, offset = ind)
-    File "/usr/lib64/python3.4/site-packages/cvxopt/misc.py", line 856, in jnrm2
-      return math.sqrt(x[offset] - a) * math.sqrt(x[offset] + a)
-  ValueError: math domain error
-
-
 7. Figure out why this happens, too:
 
   FAIL: test_scaling_icecream (test.symmetric_linear_game_test