GNUmakefile: use the error code from chktex

In the past, the error code from chktex was not a reliable indicator
of problems. That appears fixed, and we don't get any superfluous
output on success, so let's drop the old workaround and just run it.

diff --git a/GNUmakefile b/GNUmakefile
index bc35a3b333df01bf7777052a3b18f48e29e7d700..8f7e8200062481eea04f4388fb57541877225bfb 100644 (file)
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -195,13 +195,11 @@ sage_listings/%.py: sage_listings/%.listing
 check-boxes: $(BUILDDIR)/$(PN).log
        @! grep -i 'overfull\|underfull' $<
 
 check-boxes: $(BUILDDIR)/$(PN).log
        @! grep -i 'overfull\|underfull' $<
 

-# Run chktex to find silly mistakes. There is some exit code weirdness
-# (Savannah bug 53129), so we just look for empty output.
+# Run chktex to find silly mistakes.

 .PHONY: check-chktex
 .PHONY: check-chktex

-CHKTEX = chktex --localrc .chktexrc --quiet --inputfiles=0
+CHKTEX = chktex --localrc .chktexrc --quiet --inputfiles=0 --headererr

 check-chktex:
 check-chktex:

-       @chktexout=$$($(CHKTEX) $(PN).tex); \
-         test -z "$${chktexout}" || { echo "$${chktexout}" 1>&2; exit 1; }
+       $(CHKTEX) $(PN).tex

 
 # Ensure that there are no undefined references in the document by
 # parsing the log file for said warnings.
 
 # Ensure that there are no undefined references in the document by
 # parsing the log file for said warnings.