Make cube_at either return a cube or error instead of returning a (Maybe Cube).

[spline3.git] / src / Tests / Grid.hs

diff --git a/src/Tests/Grid.hs b/src/Tests/Grid.hs
index b565f0d819e29212aec3f9d94202a148670d76d0..3cc316ae302771a7b80c12c8fdbca76fdcaba1a5 100644 (file)
--- a/src/Tests/Grid.hs
+++ b/src/Tests/Grid.hs
@@ -1,7 +1,6 @@
 module Tests.Grid
 where
 
-import Data.Maybe (fromJust)
 import Test.HUnit
 
 import Assertions
@@ -10,7 +9,9 @@ import Cube hiding (i, j, k)
 import Examples
 import FunctionValues (value_at)
 import Grid
+import Point (Point)
 import Tetrahedron
+import ThreeDimensional
 
 
 -- | Check the value of c0030 for tetrahedron0 belonging to the
@@ -21,7 +22,7 @@ test_trilinear_c0030 =
     assertAlmostEqual "c0030 is correct" (c t 0 0 3 0) (17/8)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -33,7 +34,7 @@ test_trilinear_c0003 =
     assertAlmostEqual "c0003 is correct" (c t 0 0 0 3) (27/8)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -45,7 +46,7 @@ test_trilinear_c0021 =
     assertAlmostEqual "c0021 is correct" (c t 0 0 2 1) (61/24)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -57,7 +58,7 @@ test_trilinear_c0012 =
     assertAlmostEqual "c0012 is correct" (c t 0 0 1 2) (71/24)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -69,7 +70,7 @@ test_trilinear_c0120 =
     assertAlmostEqual "c0120 is correct" (c t 0 1 2 0) (55/24)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -81,7 +82,7 @@ test_trilinear_c0102 =
     assertAlmostEqual "c0102 is correct" (c t 0 1 0 2) (73/24)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -93,7 +94,7 @@ test_trilinear_c0111 =
     assertAlmostEqual "c0111 is correct" (c t 0 1 1 1) (8/3)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -105,7 +106,7 @@ test_trilinear_c0210 =
     assertAlmostEqual "c0210 is correct" (c t 0 2 1 0) (29/12)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -117,7 +118,7 @@ test_trilinear_c0201 =
     assertAlmostEqual "c0201 is correct" (c t 0 2 0 1) (11/4)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -129,7 +130,7 @@ test_trilinear_c0300 =
     assertAlmostEqual "c0300 is correct" (c t 0 3 0 0) (5/2)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -141,7 +142,7 @@ test_trilinear_c1020 =
     assertAlmostEqual "c1020 is correct" (c t 1 0 2 0) (8/3)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -153,7 +154,7 @@ test_trilinear_c1002 =
     assertAlmostEqual "c1002 is correct" (c t 1 0 0 2) (23/6)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -165,7 +166,7 @@ test_trilinear_c1011 =
     assertAlmostEqual "c1011 is correct" (c t 1 0 1 1) (13/4)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -177,7 +178,7 @@ test_trilinear_c1110 =
     assertAlmostEqual "c1110 is correct" (c t 1 1 1 0) (23/8)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -189,7 +190,7 @@ test_trilinear_c1101 =
     assertAlmostEqual "c1101 is correct" (c t 1 1 0 1) (27/8)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -201,7 +202,7 @@ test_trilinear_c1200 =
     assertAlmostEqual "c1200 is correct" (c t 1 2 0 0) 3
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -213,7 +214,7 @@ test_trilinear_c2010 =
     assertAlmostEqual "c2010 is correct" (c t 2 0 1 0) (10/3)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -225,7 +226,7 @@ test_trilinear_c2001 =
     assertAlmostEqual "c2001 is correct" (c t 2 0 0 1) 4
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -237,7 +238,7 @@ test_trilinear_c2100 =
     assertAlmostEqual "c2100 is correct" (c t 2 1 0 0) (7/2)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -249,7 +250,7 @@ test_trilinear_c3000 =
     assertAlmostEqual "c3000 is correct" (c t 3 0 0 0) 4
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -261,7 +262,7 @@ test_trilinear_f0_t0_v0 =
     assertEqual "v0 is correct" (v0 t) (1, 1, 1)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -273,7 +274,7 @@ test_trilinear_f0_t0_v1 =
     assertEqual "v1 is correct" (v1 t) (0.5, 1, 1)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -285,7 +286,7 @@ test_trilinear_f0_t0_v2 =
     assertEqual "v2 is correct" (v2 t) (0.5, 0.5, 1.5)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -297,7 +298,7 @@ test_trilinear_f0_t0_v3 =
     assertClose "v3 is correct" (v3 t) (0.5, 1.5, 1.5)
       where
         g = make_grid 1 trilinear
-        cube = fromJust $ cube_at g 1 1 1
+        cube = cube_at g 1 1 1
         t = tetrahedron0 cube
 
 
@@ -315,7 +316,7 @@ test_trilinear_reproduced =
                       let k' = fromIntegral k]
     where
       g = make_grid 1 trilinear
-      c0 = fromJust $ cube_at g 1 1 1
+      c0 = cube_at g 1 1 1
 
 
 test_zeros_reproduced :: Assertion
@@ -330,7 +331,7 @@ test_zeros_reproduced =
                       let k' = fromIntegral k]
     where
       g = make_grid 1 zeros
-      c0 = fromJust $ cube_at g 1 1 1
+      c0 = cube_at g 1 1 1
       t0 = tetrahedron0 c0
       p = polynomial t0
 
@@ -350,5 +351,28 @@ test_trilinear9x9x9_reproduced =
               let k' = (fromIntegral k) * 0.5]
     where
       g = make_grid 1 trilinear
-      c0 = fromJust $ cube_at g 1 1 1
-
+      c0 = cube_at g 1 1 1
+
+
+-- | The point 'p' in this test lies on the boundary of tetrahedra 12 and 15.
+--   However, the 'contains_point' test fails due to some numerical innacuracy.
+--   This bug should have been fixed by setting a positive tolerance level.
+--
+--   Example from before the fix:
+--
+--   > b0 (tetrahedron12 c) p
+--   -2.168404344971019e-18
+--   > b0 (tetrahedron15 c) p
+--   -3.4694469519536365e-18
+--
+test_tetrahedra_collision_sensitivity :: Assertion
+test_tetrahedra_collision_sensitivity =
+  assertTrue "tetrahedron collision tests aren't too sensitive" $
+             contains_point t12 p &&
+             contains_point t15 p
+  where
+    g = make_grid 1 trilinear
+    c = cube_at g 0 17 1
+    p = (0, 16.75, 0.5) :: Point
+    t12 = tetrahedron12 c
+    t15 = tetrahedron15 c