From: Michael Orlitzky <michael@orlitzky.com>
Date: Tue, 9 Mar 2021 03:04:15 +0000 (-0500)
Subject: eja: undo overzealous hack in _all2list; the bug was elsewhere.
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=f38e111cd026f1ecdab6dd2d2ed194a8745252a8;p=sage.d.git

eja: undo overzealous hack in _all2list; the bug was elsewhere.
---

diff --git a/mjo/eja/eja_utils.py b/mjo/eja/eja_utils.py
index 6f8cab6..7c6c581 100644
--- a/mjo/eja/eja_utils.py
+++ b/mjo/eja/eja_utils.py
@@ -106,13 +106,6 @@ def _all2list(x):
         [3, 4, 1, 0, 0, 0, 0, 0, 0, 0]
 
     """
-    if hasattr(x, 'list') and hasattr(x, 'to_vector'):
-        # This avoids calling to_vector() on a matrix algebra with
-        # e.g. quaternions where the returned vector is of the wrong
-        # length (three instead of four) because the quaternions don't
-        # know how many generators they have.
-        return _all2list(x.list())
-
     if hasattr(x, 'to_vector'):
         # This works on matrices of e.g. octonions directly, without
         # first needing to convert them to a list of octonions and