From: Michael Orlitzky <michael@orlitzky.com>
Date: Mon, 7 Dec 2020 21:26:51 +0000 (-0500)
Subject: eja: port BilinearFormEJA to matrix-only representation.
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=84efe40c8bdc4707cbb4c24ea704b33aba5d9753;p=sage.d.git

eja: port BilinearFormEJA to matrix-only representation.
---

diff --git a/mjo/eja/eja_algebra.py b/mjo/eja/eja_algebra.py
index f142181..2c68c8c 100644
--- a/mjo/eja/eja_algebra.py
+++ b/mjo/eja/eja_algebra.py
@@ -2317,25 +2317,25 @@ class BilinearFormEJA(ConcreteEJA):
             raise ValueError("bilinear form is not positive-definite")
 
         def inner_product(x,y):
-            return (B*x).inner_product(y)
+            return (y.T*B*x)[0,0]
 
         def jordan_product(x,y):
             P = x.parent()
-            x0 = x[0]
-            xbar = x[1:]
-            y0 = y[0]
-            ybar = y[1:]
-            z0 = inner_product(x,y)
+            x0 = x[0,0]
+            xbar = x[1:,0]
+            y0 = y[0,0]
+            ybar = y[1:,0]
+            z0 = (y.T*x)[0,0]
             zbar = y0*xbar + x0*ybar
-            return P((z0,) + tuple(zbar))
+            return P([0] + zbar.list())
 
         # We know this is a valid EJA, but will double-check
         # if the user passes check_axioms=True.
         if "check_axioms" not in kwargs: kwargs["check_axioms"] = False
 
         n = B.nrows()
-        standard_basis = FreeModule(ZZ, n).basis()
-        super(BilinearFormEJA, self).__init__(standard_basis,
+        column_basis = tuple( b.column() for b in FreeModule(ZZ, n).basis() )
+        super(BilinearFormEJA, self).__init__(column_basis,
                                               jordan_product,
                                               inner_product,
                                               **kwargs)