From: Michael Orlitzky <michael@orlitzky.com>
Date: Sat, 21 Nov 2020 13:19:19 +0000 (-0500)
Subject: eja: update a few TODO items.
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=77a973c0044e70fff2041a76e78a0fde7595bfb8;p=sage.d.git

eja: update a few TODO items.
---

diff --git a/mjo/eja/TODO b/mjo/eja/TODO
index 76b9eaf..f49bde1 100644
--- a/mjo/eja/TODO
+++ b/mjo/eja/TODO
@@ -11,6 +11,9 @@
    DirectSumEJA.
 
 6. Switch to QQ in *all* algebras for _charpoly_coefficients().
+   This only works when we know that the basis can be rationalized...
+   which is the case at least for the concrete EJAs we provide,
+   but not in general.
 
 7. Pass already_echelonized (default: False) and echelon_basis
    (default: None) into the subalgebra constructor. The value of
@@ -18,3 +21,6 @@
    some time, and usinf e.g. FreeModule_submodule_with_basis_field
    we may somehow be able to pass the echelon basis straight in to
    save time.
+
+   This may require supporting "basis" as a list of basis vectors
+   (as opposed to superalgebra elements) in the subalgebra constructor.