From: Michael Orlitzky <michael@orlitzky.com>
Date: Wed, 24 Jul 2019 03:23:02 +0000 (-0400)
Subject: eja: add an implementation warning for characteristic_polynomial().
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=644eb599855ddd51e8731104cc337eb9a4a33abe;p=sage.d.git

eja: add an implementation warning for characteristic_polynomial().
---

diff --git a/mjo/eja/euclidean_jordan_algebra.py b/mjo/eja/euclidean_jordan_algebra.py
index c37ace0..b31322f 100644
--- a/mjo/eja/euclidean_jordan_algebra.py
+++ b/mjo/eja/euclidean_jordan_algebra.py
@@ -140,6 +140,20 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
     @cached_method
     def characteristic_polynomial(self):
         """
+
+        .. WARNING::
+
+            This implementation doesn't guarantee that the polynomial
+            denominator in the coefficients is not identically zero, so
+            theoretically it could crash. The way that this is handled
+            in e.g. Faraut and Koranyi is to use a basis that guarantees
+            the denominator is non-zero. But, doing so requires knowledge
+            of at least one regular element, and we don't even know how
+            to do that. The trade-off is that, if we use the standard basis,
+            the resulting polynomial will accept the "usual" coordinates. In
+            other words, we don't have to do a change of basis before e.g.
+            computing the trace or determinant.
+
         EXAMPLES:
 
         The characteristic polynomial in the spin algebra is given in