From: Michael Orlitzky <michael@orlitzky.com>
Date: Tue, 20 Aug 2019 14:12:04 +0000 (-0400)
Subject: eja: require "field" argument for matrix basis functions.
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=4e1d889fa70b660e789f31adb13f449c9f3a2fb1;p=sage.d.git

eja: require "field" argument for matrix basis functions.
---

diff --git a/mjo/eja/eja_algebra.py b/mjo/eja/eja_algebra.py
index 9b02880..07c4947 100644
--- a/mjo/eja/eja_algebra.py
+++ b/mjo/eja/eja_algebra.py
@@ -797,7 +797,7 @@ def random_eja():
 
 
 
-def _real_symmetric_basis(n, field=QQ):
+def _real_symmetric_basis(n, field):
     """
     Return a basis for the space of real symmetric n-by-n matrices.
     """
@@ -816,7 +816,7 @@ def _real_symmetric_basis(n, field=QQ):
     return tuple(S)
 
 
-def _complex_hermitian_basis(n, field=QQ):
+def _complex_hermitian_basis(n, field):
     """
     Returns a basis for the space of complex Hermitian n-by-n matrices.
 
@@ -857,7 +857,7 @@ def _complex_hermitian_basis(n, field=QQ):
     return tuple(S)
 
 
-def _quaternion_hermitian_basis(n, field=QQ):
+def _quaternion_hermitian_basis(n, field):
     """
     Returns a basis for the space of quaternion Hermitian n-by-n matrices.
 
@@ -1237,7 +1237,7 @@ class RealSymmetricEJA(FiniteDimensionalEuclideanJordanAlgebra):
 
     """
     def __init__(self, n, field=QQ, **kwargs):
-        S = _real_symmetric_basis(n, field=field)
+        S = _real_symmetric_basis(n, field)
         Qs = _multiplication_table_from_matrix_basis(S)
 
         fdeja = super(RealSymmetricEJA, self)
@@ -1306,7 +1306,7 @@ class ComplexHermitianEJA(FiniteDimensionalEuclideanJordanAlgebra):
 
     """
     def __init__(self, n, field=QQ, **kwargs):
-        S = _complex_hermitian_basis(n)
+        S = _complex_hermitian_basis(n, field)
         Qs = _multiplication_table_from_matrix_basis(S)
 
         fdeja = super(ComplexHermitianEJA, self)
@@ -1383,7 +1383,7 @@ class QuaternionHermitianEJA(FiniteDimensionalEuclideanJordanAlgebra):
 
     """
     def __init__(self, n, field=QQ, **kwargs):
-        S = _quaternion_hermitian_basis(n)
+        S = _quaternion_hermitian_basis(n, field)
         Qs = _multiplication_table_from_matrix_basis(S)
 
         fdeja = super(QuaternionHermitianEJA, self)