From: Michael Orlitzky <michael@orlitzky.com>
Date: Tue, 20 Oct 2020 22:00:52 +0000 (-0400)
Subject: Warn about IP addresses in hostname fields.
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=2533843a92ae5a7cb04894c815b844b02ffa4242;p=valtz.git

Warn about IP addresses in hostname fields.

A common error is to specify an IP address as the result of an MX
lookup. The RFCs (974, 1035, 2181...) state that the result should be
a "domain name," which in this context, means "host name." This commit
adds a check on "hostname" fields that rejects a dotted-quad contained
therein. In particular, it catches the aforementioned MX record error.
---

diff --git a/valtz b/valtz
index 26d516d..0ca0e6a 100755
--- a/valtz
+++ b/valtz
@@ -76,6 +76,7 @@ my %validation_msg = (
     1008 => 'integer out of bounds',
     1009 => 'must have at least three labels to be valid as mail address',
     1010 => 'must not be 2(NS), 5(CNAME), 6(SOA), 12(PTR), 15(MX) or 252(AXFR)',
+    1011 => 'IP address found where hostname expected'
 );
 
 # NOTE : ONLY translate the right-hand part
@@ -238,6 +239,13 @@ my %token_validator = (
     'x' => [ 5, sub {
         my ($type, $s) = @_;
         my $result = 0;
+
+	# Check to see if someone put an IP address in a hostname
+	# field. The motivation for this was MX records where many
+	# people expect an IP address to be a valid response, but I
+	# see no harm in enforcing it elsewhere.
+	return 1011 if $s =~ /^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\.?$/;
+
         # check all parts
         for (split /\./, $s)
         {