From: Michael Orlitzky <michael@orlitzky.com>
Date: Sun, 2 Feb 2020 17:41:49 +0000 (-0500)
Subject: src/OptionalConfiguration.hs: use an explicit mappend.
X-Git-Tag: 0.0.4
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=24c0bd71a353d0f0323d879bc78582fe2557c731;p=mailbox-count.git

src/OptionalConfiguration.hs: use an explicit mappend.

I have a feeling that in older versions of GHC, the Monoid instance
is not smart enough to use an existing Semigroup instance for its
mappend implementation. Let's just make it explicit.
---

diff --git a/src/OptionalConfiguration.hs b/src/OptionalConfiguration.hs
index 16fad06..31aa7f1 100644
--- a/src/OptionalConfiguration.hs
+++ b/src/OptionalConfiguration.hs
@@ -55,26 +55,14 @@ merge_maybes Nothing (Just x)  = Just x
 merge_maybes (Just _) (Just y) = Just y
 
 
--- | The Monoid instance for these lets us "combine" two
---   OptionalConfigurations. The "combine" operation that we'd like to
---   perform is, essentially, to mash them together. So if we have two
+-- | The Semigroup instance for these lets us "combine" two
+--   configurations. The "combine" operation that we'd like to perform
+--   is, essentially, to mash them together. So if we have two
 --   OptionalConfigurations, each half full, we could combine them
 --   into one big one.
 --
 --   This is used to merge command-line and config-file settings.
 --
-instance Monoid OptionalConfiguration where
-  -- | An empty OptionalConfiguration.
-  mempty = OptionalConfiguration
-             Nothing
-             Nothing
-             Nothing
-             Nothing
-             Nothing
-             Nothing
-             Nothing
-             Nothing
-
 instance Semigroup OptionalConfiguration where
   -- | Combine @cfg1@ and @cfg2@, giving precedence to @cfg2@.
   cfg1 <> cfg2 =
@@ -89,6 +77,22 @@ instance Semigroup OptionalConfiguration where
       (merge_maybes (username cfg1) (username cfg2))
 
 
+-- | The Monoid instance essentially only provides the "empty
+--   configuration."
+instance Monoid OptionalConfiguration where
+  -- | An empty OptionalConfiguration.
+  mempty = OptionalConfiguration
+             Nothing
+             Nothing
+             Nothing
+             Nothing
+             Nothing
+             Nothing
+             Nothing
+             Nothing
+  mappend = (<>)
+
+
 -- | Obtain an OptionalConfiguration from mailbox-countrc in either
 --   the global configuration directory or the user's home
 --   directory. The one in $HOME is prefixed by a dot so that it is