From: Michael Orlitzky <michael@orlitzky.com>
Date: Mon, 31 Jan 2022 22:22:44 +0000 (-0500)
Subject: eja: revert random_element() to old fast behavior.
X-Git-Url: https://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=1d6c0d98ea24be9bcfec236ad94d6d125dabd8f4;p=sage.d.git

eja: revert random_element() to old fast behavior.
---

diff --git a/mjo/eja/eja_algebra.py b/mjo/eja/eja_algebra.py
index afd0f55..9f8a258 100644
--- a/mjo/eja/eja_algebra.py
+++ b/mjo/eja/eja_algebra.py
@@ -1447,26 +1447,13 @@ class FiniteDimensionalEJA(CombinatorialFreeModule):
         # For a general base ring... maybe we can trust this to do the
         # right thing? Unlikely, but.
         V = self.vector_space()
-        v = V.random_element()
-
-        if self.base_ring() is AA:
-            # The "random element" method of the algebraic reals is
-            # stupid at the moment, and only returns integers between
-            # -2 and 2, inclusive:
-            #
-            #   https://trac.sagemath.org/ticket/30875
-            #
-            # Instead, we implement our own "random vector" method,
-            # and then coerce that into the algebra. We use the vector
-            # space degree here instead of the dimension because a
-            # subalgebra could (for example) be spanned by only two
-            # vectors, each with five coordinates.  We need to
-            # generate all five coordinates.
-            if thorough:
-                v *= QQbar.random_element().real()
-            else:
-                v *= QQ.random_element()
+        if self.base_ring() is AA and not thorough:
+            # Now that AA generates actually random random elements
+            # (post Trac 30875), we only need to de-thorough the
+            # randomness when asked to.
+            V = V.change_ring(QQ)
 
+        v = V.random_element()
         return self.from_vector(V.coordinate_vector(v))
 
     def random_elements(self, count, thorough=False):