]> gitweb.michael.orlitzky.com - sage.d.git/commitdiff
eja: undo overzealous hack in _all2list; the bug was elsewhere.
authorMichael Orlitzky <michael@orlitzky.com>
Tue, 9 Mar 2021 03:04:15 +0000 (22:04 -0500)
committerMichael Orlitzky <michael@orlitzky.com>
Tue, 9 Mar 2021 03:04:15 +0000 (22:04 -0500)
mjo/eja/eja_utils.py

index 6f8cab6d8019dcbba0be1e81c3872a7ba738f807..7c6c581329dd64aaa8f3d958e00b2f9eb3221fcb 100644 (file)
@@ -106,13 +106,6 @@ def _all2list(x):
         [3, 4, 1, 0, 0, 0, 0, 0, 0, 0]
 
     """
-    if hasattr(x, 'list') and hasattr(x, 'to_vector'):
-        # This avoids calling to_vector() on a matrix algebra with
-        # e.g. quaternions where the returned vector is of the wrong
-        # length (three instead of four) because the quaternions don't
-        # know how many generators they have.
-        return _all2list(x.list())
-
     if hasattr(x, 'to_vector'):
         # This works on matrices of e.g. octonions directly, without
         # first needing to convert them to a list of octonions and