X-Git-Url: https://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=src%2Faclq.c;h=a2b4307475752b061fd5304ffca8a18a6382bc05;hb=263849b3e05d7ed79fffb0751683ecd740cc90af;hp=eaeb2ede17e36d33f79925e3a6416f3a605259fa;hpb=d87d053c3183ccdbfe60a3c957cffa85212131c0;p=apply-default-acl.git

diff --git a/src/aclq.c b/src/aclq.c
index eaeb2ed..a2b4307 100644
--- a/src/aclq.c
+++ b/src/aclq.c
@@ -15,6 +15,9 @@
 
 
 mode_t get_mode(const char* path) {
+  /*
+   * Get the mode bits from path.
+   */
   if (path == NULL) {
     errno = ENOENT;
     return -1;
@@ -32,17 +35,11 @@ mode_t get_mode(const char* path) {
   }
 }
 
-bool mode_has_perm(mode_t mode, int perm) {
-  if (mode & perm) {
-    return true;
-  }
-  else {
-    return false;
-  }
-}
-
 
 bool is_regular_file(const char* path) {
+  /*
+   * Returns true if path is a regular file, false otherwise.
+   */
   if (path == NULL) {
     return false;
   }
@@ -58,6 +55,9 @@ bool is_regular_file(const char* path) {
 }
 
 bool is_directory(const char* path) {
+  /*
+   * Returns true if path is a directory, false otherwise.
+   */
   if (path == NULL) {
     return false;
   }
@@ -73,311 +73,327 @@ bool is_directory(const char* path) {
 }
 
 
-int has_type_tag_acl(const char* path,
-		     acl_type_t type,
-		     acl_tag_t desired_tag) {
-  /* Returns one if the given path has a default ACL for the supplied
-     tag, zero if it doesn't, and -1 on error. */
-  acl_t defacl = acl_get_file(path, type);
 
-  if (defacl == (acl_t)NULL) {
-    return 0;
+int acl_set_entry(acl_t* aclp,
+		  acl_entry_t entry) {
+  /*
+   * Update or create the given entry.
+   */
+
+  acl_tag_t entry_tag;
+  int gt_result = acl_get_tag_type(entry, &entry_tag);
+  if (gt_result == -1) {
+    perror("acl_set_entry (acl_get_tag_type)");
+    return -1;
   }
 
-  acl_entry_t entry;
-  int result = acl_get_entry(defacl, ACL_FIRST_ENTRY, &entry);
+  acl_permset_t entry_permset;
+  int ps_result = acl_get_permset(entry, &entry_permset);
+  if (ps_result == -1) {
+    perror("acl_set_entry (acl_get_permset)");
+    return -1;
+  }
+
+  acl_entry_t existing_entry;
+  /* Loop through the given ACL looking for matching entries. */
+  int result = acl_get_entry(*aclp, ACL_FIRST_ENTRY, &existing_entry);
 
   while (result == 1) {
-    acl_tag_t tag = ACL_UNDEFINED_TAG;
-    int tag_result = acl_get_tag_type(entry, &tag);
+    acl_tag_t existing_tag = ACL_UNDEFINED_TAG;
+    int tag_result = acl_get_tag_type(existing_entry, &existing_tag);
 
     if (tag_result == -1) {
-       perror("has_default_tag_acl (acl_get_tag_type)");
+       perror("set_acl_tag_permset (acl_get_tag_type)");
        return -1;
     }
-    else {
-      if (tag == desired_tag) {
+
+    if (existing_tag == entry_tag) {
+      if (entry_tag == ACL_USER_OBJ ||
+	  entry_tag == ACL_GROUP_OBJ ||
+	  entry_tag == ACL_OTHER) {
+	/* Only update for these three since all other tags will have
+	   been wiped. */
+	acl_permset_t existing_permset;
+	int gep_result = acl_get_permset(existing_entry, &existing_permset);
+	if (gep_result == -1) {
+	  perror("acl_set_entry (acl_get_permset)");
+	  return -1;
+	}
+
+	int s_result = acl_set_permset(existing_entry, entry_permset);
+	if (s_result == -1) {
+	  perror("acl_set_entry (acl_set_permset)");
+	  return -1;
+	}
+
 	return 1;
       }
+
     }
 
-    result = acl_get_entry(defacl, ACL_NEXT_ENTRY, &entry);
+    result = acl_get_entry(*aclp, ACL_NEXT_ENTRY, &existing_entry);
   }
 
+  /* This catches both the initial acl_get_entry and the ones at the
+     end of the loop. */
   if (result == -1) {
-    perror("has_default_tag_acl (acl_get_entry)");
+    perror("acl_set_entry (acl_get_entry)");
     return -1;
   }
 
-  return 0;
-}
+  /* If we've made it this far, we need to add a new entry to the
+     ACL. */
+  acl_entry_t new_entry;
 
-int has_default_tag_acl(const char* path, acl_tag_t desired_tag) {
-  return has_type_tag_acl(path, ACL_TYPE_DEFAULT, desired_tag);
-}
+  /* We allocate memory here that we should release! */
+  int c_result = acl_create_entry(aclp, &new_entry);
+  if (c_result == -1) {
+    perror("acl_set_entry (acl_create_entry)");
+    return -1;
+  }
 
-int has_access_tag_acl(const char* path, acl_tag_t desired_tag) {
-  return has_type_tag_acl(path, ACL_TYPE_ACCESS, desired_tag);
-}
+  int st_result = acl_set_tag_type(new_entry, entry_tag);
+  if (st_result == -1) {
+    perror("acl_set_entry (acl_set_tag_type)");
+    return -1;
+  }
 
-int has_default_user_obj_acl(const char* path) {
-  return has_default_tag_acl(path, ACL_USER_OBJ);
-}
+  int s_result = acl_set_permset(new_entry, entry_permset);
+  if (s_result == -1) {
+    perror("acl_set_entry (acl_set_permset)");
+    return -1;
+  }
 
-int has_default_group_obj_acl(const char* path) {
-  return has_default_tag_acl(path, ACL_GROUP_OBJ);
-}
+  if (entry_tag == ACL_USER || entry_tag == ACL_GROUP) {
+    /* We need to set the qualifier too. */
+    void* entry_qual = acl_get_qualifier(entry);
+    if (entry_qual == (void*)NULL) {
+      perror("acl_set_entry (acl_get_qualifier)");
+      return -1;
+    }
 
-int has_default_other_acl(const char* path) {
-  return has_default_tag_acl(path, ACL_OTHER);
-}
+    int sq_result = acl_set_qualifier(new_entry, entry_qual);
+    if (sq_result == -1) {
+      perror("acl_set_entry (acl_set_qualifier)");
+      return -1;
+    }
+  }
 
-int has_default_mask_acl(const char* path) {
-  return has_default_tag_acl(path, ACL_MASK);
+  return 1;
 }
 
 
-int get_type_tag_entry(const char* path,
-		       acl_type_t type,
-		       acl_tag_t desired_tag,
-		       acl_entry_t* entry) {
-    /* Returns one if successful, zero when the ACL doesn't exist, and
-     -1 on unexpected errors. */
-  acl_t defacl = acl_get_file(path, type);
 
-  if (defacl == (acl_t)NULL) {
-    /* Follow the acl_foo convention of -1 == error. */
-    return 0;
-  }
-
-  int result = acl_get_entry(defacl, ACL_FIRST_ENTRY, entry);
+int acl_entry_count(acl_t* acl) {
+  /*
+   * Return the number of entries in acl, or -1 on error.
+   */
+  acl_entry_t entry;
+  int entry_count = 0;
+  int result = acl_get_entry(*acl, ACL_FIRST_ENTRY, &entry);
 
   while (result == 1) {
-    acl_tag_t tag = ACL_UNDEFINED_TAG;
-    int tag_result = acl_get_tag_type(*entry, &tag);
-
-    if (tag_result == -1) {
-       perror("get_default_tag_entry (acl_get_tag_type)");
-       return -1;
-    }
-
-    if (tag == desired_tag) {
-      /* We found the right tag, so return successfully. */
-      return 1;
-    }
-
-    result = acl_get_entry(defacl, ACL_NEXT_ENTRY, entry);
+    entry_count++;
+    result = acl_get_entry(*acl, ACL_NEXT_ENTRY, &entry);
   }
 
-  /* This catches both the initial acl_get_entry and the ones at the
-     end of the loop. */
   if (result == -1) {
-    perror("get_default_tag_entry (acl_get_entry)");
+    perror("acl_is_minimal (acl_get_entry)");
     return -1;
   }
 
-  return 0;
+  return entry_count;
 }
 
-int get_default_tag_entry(const char* path,
-			  acl_tag_t desired_tag,
-			  acl_entry_t* entry) {
-  return get_type_tag_entry(path, ACL_TYPE_DEFAULT, desired_tag, entry);
-}
 
-int get_access_tag_entry(const char* path,
-			  acl_tag_t desired_tag,
-			  acl_entry_t* entry) {
-  return get_type_tag_entry(path, ACL_TYPE_ACCESS, desired_tag, entry);
-}
+int acl_is_minimal(acl_t* acl) {
+  /* An ACL is minimal if it has fewer than four entries. Return 0 for
+   * false, 1 for true, and -1 on error.
+   */
+
+  int ec = acl_entry_count(acl);
+  if (ec == -1) {
+    perror("acl_is_minimal (acl_entry_count)");
+    return -1;
+  }
 
+  if (ec < 4) {
+    return 1;
+  }
+  else {
+    return 0;
+  }
+}
 
 
-int get_type_tag_permset(const char* path,
-			 acl_type_t type,
-			 acl_tag_t desired_tag,
-			 acl_permset_t* output_perms) {
-  /* Returns one if successful, zero when the ACL doesn't exist, and
-     -1 on unexpected errors. */
-  acl_t defacl = acl_get_file(path, type);
+int any_can_execute(const char* path) {
+  /* Returns 1 if any ACL entry has execute access, 0 if none do, and
+   * -1 on error.
+   */
+  acl_t acl = acl_get_file(path, ACL_TYPE_ACCESS);
 
-  if (defacl == (acl_t)NULL) {
-    /* Follow the acl_foo convention of -1 == error. */
+  if (acl == (acl_t)NULL) {
     return 0;
   }
 
-  acl_entry_t entry;
-  int result = get_default_tag_entry(path, desired_tag, &entry);
-
-  if (result == 1) {
-    /* We found the right tag, now get the permset. */
-    int ps_result = acl_get_permset(entry, output_perms);
-    if (ps_result == -1) {
-      perror("get_default_tag_permset (acl_get_permset)");
-    }
+  /* Our return value. */
+  int result = 0;
 
-    if (ps_result == 0) {
-      return 1;
+  if (acl_is_minimal(&acl)) {
+    mode_t mode = get_mode(path);
+    if (mode & (S_IXUSR | S_IXOTH | S_IXGRP)) {
+      result = 1;
+      goto cleanup;
     }
     else {
-      return 0;
+      result = 0;
+      goto cleanup;
     }
   }
-  else {
-    return result;
-  }
-}
 
-int get_default_tag_permset(const char* path,
-			    acl_tag_t desired_tag,
-			    acl_permset_t* output_perms) {
-  return get_type_tag_permset(path, ACL_TYPE_DEFAULT, desired_tag, output_perms);
-}
+  acl_entry_t entry;
+  int ge_result = acl_get_entry(acl, ACL_FIRST_ENTRY, &entry);
 
-int get_access_tag_permset(const char* path,
-			    acl_tag_t desired_tag,
-			    acl_permset_t* output_perms) {
-  return get_type_tag_permset(path, ACL_TYPE_ACCESS, desired_tag, output_perms);
-}
+  while (ge_result == 1) {
+    acl_permset_t permset;
 
-int has_default_tag_perm(const char* path,
-			  acl_tag_t tag,
-			  acl_perm_t perm) {
-  /* Check path to see if tag has the given perm. Returns one if it
-     does, zero if it doesn't (or there's no ACL), and -1 on unexpected
-     errors. */
+    int ps_result = acl_get_permset(entry, &permset);
+    if (ps_result == -1) {
+      perror("any_can_execute (acl_get_permset)");
+      result = -1;
+      goto cleanup;
+    }
 
-  if (!has_default_tag_acl(path, tag)) {
-    return 0;
-  }
+    int gp_result = acl_get_perm(permset, ACL_EXECUTE);
+    if (gp_result == -1) {
+      perror("any_can_execute (acl_get_perm)");
+      result = -1;
+      goto cleanup;
+    }
 
-  acl_permset_t permset;
-  bool ps_result = get_default_tag_permset(path, tag, &permset);
+    if (gp_result == 1) {
+      result = 1;
+      goto cleanup;
+    }
 
-  if (ps_result != 1) {
-    /* Failure or error. */
-    return ps_result;
+    ge_result = acl_get_entry(acl, ACL_NEXT_ENTRY, &entry);
   }
 
-  int p_result = acl_get_perm(permset, perm);
-  if (p_result == -1) {
-    perror("has_default_tag_perm (acl_get_perm)");
+  if (ge_result == -1) {
+    perror("any_can_execute (acl_get_entry)");
+    result = -1;
+    goto cleanup;
   }
 
-  return p_result;
+ cleanup:
+  acl_free(acl);
+  return result;
 }
 
-int remove_access_tag_perm(const char* path,
-			   acl_tag_t tag,
-			   acl_perm_t perm) {
-  /* Attempt to remove perm from tag. Returns one if successful, zero
-     if there was nothing to do, and -1 on errors. */
-  int hata = has_access_tag_acl(path, tag);
-  if (hata != 1) {
-    /* Failure or error. */
-    return hata;
-  }
 
-  acl_permset_t permset;
-  bool ps_result = get_access_tag_permset(path, tag, &permset);
+int inherit_default_acl(const char* path, const char* parent) {
+  /* Inherit the default ACL from parent to path. This overwrites any
+   * existing default ACL. Returns 1 for success, 0 for failure, and
+   * -1 on error.
+   */
 
-  if (ps_result != 1) {
-    /* Failure or error. */
-    return ps_result;
-  }
+  /* Our return value. */
+  int result = 1;
 
-  int d_result = acl_delete_perm(permset, perm);
-  if (d_result == -1) {
-    perror("remove_access_tag_perm (acl_delete_perm)");
+  if (path == NULL) {
+    errno = ENOENT;
     return -1;
   }
 
-  /* We've only removed perm from the permset; now we have to replace
-     the permset. */
-  acl_entry_t entry;
-  int entry_result = get_access_tag_entry(path, tag, &entry);
-
-  if (entry_result == -1) {
-    perror("remove_access_tag_perm (get_access_tag_entry)");
-    return -1;
+  if (!is_directory(path) || !is_directory(parent)) {
+    return 0;
   }
 
-  if (entry_result == 1) {
-    /* Success. */
-    int s_result = acl_set_permset(entry, permset);
-    if (s_result == -1) {
-      perror("remove_access_tag_perm (acl_set_permset)");
-      return -1;
-    }
-
-    return 1;
-  }
-  else {
+  acl_t parent_acl = acl_get_file(parent, ACL_TYPE_DEFAULT);
+  if (parent_acl == (acl_t)NULL) {
     return 0;
   }
-}
 
-int remove_access_group_obj_execute(const char* path) {
-  return remove_access_tag_perm(path, ACL_GROUP_OBJ, ACL_EXECUTE);
-}
+  acl_t path_acl = acl_dup(parent_acl);
 
+  if (path_acl == (acl_t)NULL) {
+    perror("inherit_default_acl (acl_dup)");
+    acl_free(parent_acl);
+    return -1;
+  }
 
-int has_default_user_obj_read(const char* path) {
-  return has_default_tag_perm(path, ACL_USER_OBJ, ACL_READ);
-}
+  int sf_result = acl_set_file(path, ACL_TYPE_DEFAULT, path_acl);
+  if (sf_result == -1) {
+    perror("inherit_default_acl (acl_set_file)");
+    result = -1;
+    goto cleanup;
+  }
 
-int has_default_user_obj_write(const char* path) {
-  return has_default_tag_perm(path, ACL_USER_OBJ, ACL_WRITE);
+ cleanup:
+  acl_free(path_acl);
+  return result;
 }
 
-int has_default_user_obj_execute(const char* path) {
-  return has_default_tag_perm(path, ACL_USER_OBJ, ACL_EXECUTE);
-}
 
-int has_default_group_obj_read(const char* path) {
-  return has_default_tag_perm(path, ACL_GROUP_OBJ, ACL_READ);
-}
+int wipe_acls(const char* path) {
+  /* Remove ACL_USER, ACL_GROUP, and ACL_MASK entries from
+     path. Returns 1 for success, 0 for failure, and -1 on error. */
 
-int has_default_group_obj_write(const char* path) {
-  return has_default_tag_perm(path, ACL_GROUP_OBJ, ACL_WRITE);
-}
+  if (path == NULL) {
+    errno = ENOENT;
+    return -1;
+  }
 
-int has_default_group_obj_execute(const char* path) {
-  return has_default_tag_perm(path, ACL_GROUP_OBJ, ACL_EXECUTE);
-}
+  /* Finally, remove individual named/mask entries. */
+  acl_t acl = acl_get_file(path, ACL_TYPE_ACCESS);
+  if (acl == (acl_t)NULL) {
+    perror("wipe_acls (acl_get_file)");
+    return -1;
+  }
 
-int has_default_other_read(const char* path) {
-  return has_default_tag_perm(path, ACL_OTHER, ACL_READ);
-}
+  /* Our return value. */
+  int result = 1;
 
-int has_default_other_write(const char* path) {
-  return has_default_tag_perm(path, ACL_OTHER, ACL_WRITE);
-}
+  acl_entry_t entry;
+  int ge_result = acl_get_entry(acl, ACL_FIRST_ENTRY, &entry);
+
+  while (ge_result == 1) {
+    int d_result = acl_delete_entry(acl, entry);
+    if (d_result == -1) {
+      perror("wipe_acls (acl_delete_entry)");
+      result = -1;
+      goto cleanup;
+    }
 
-int has_default_other_execute(const char* path) {
-  return has_default_tag_perm(path, ACL_OTHER, ACL_EXECUTE);
-}
+    ge_result = acl_get_entry(acl, ACL_NEXT_ENTRY, &entry);
+  }
 
-int has_default_mask_read(const char* path) {
-  return has_default_tag_perm(path, ACL_MASK, ACL_READ);
-}
+  /* Catches the first acl_get_entry as well as the ones at the end of
+     the loop. */
+  if (ge_result == -1) {
+    perror("wipe_acls (acl_get_entry)");
+    result = -1;
+    goto cleanup;
+  }
 
-int has_default_mask_write(const char* path) {
-  return has_default_tag_perm(path, ACL_MASK, ACL_WRITE);
-}
+  int sf_result = acl_set_file(path, ACL_TYPE_ACCESS, acl);
+  if (sf_result == -1) {
+    perror("wipe_acls (acl_set_file)");
+    result = -1;
+    goto cleanup;
+  }
 
-int has_default_mask_execute(const char* path) {
-  return has_default_tag_perm(path, ACL_MASK, ACL_EXECUTE);
+ cleanup:
+  acl_free(acl);
+  return result;
 }
 
 
 int reapply_default_acl(const char* path) {
-  /* If this is a normal file or directory (i.e. that has just been
-     created), we proceed to find its parent directory which will have
-     a default ACL.
-
-     Returns one for success, zero for failure (i.e. no ACL), and -1
-     on unexpected errors. */
+  /* Really reapply the default ACL by looping through it. Returns one
+   * for success, zero for failure (i.e. no ACL), and -1 on unexpected
+   * errors.
+   */
   if (path == NULL) {
     return 0;
   }
@@ -397,165 +413,180 @@ int reapply_default_acl(const char* path) {
     return 0;
   }
 
-  /* This is the original mode of path. We will simply add permissions
-     to it, and then later reapply the result via chmod. */
-  mode_t path_mode = get_mode(path);
+  int ace_result = any_can_execute(path);
+  if (ace_result == -1) {
+    perror("reapply_default_acl_ng (any_can_execute)");
+    return -1;
+  }
 
-  if (has_default_mask_acl(parent)) {
-    /* The parent has an extended ACL. Extended ACLs use the mask
-       entry. */
+  bool allow_exec = (bool)ace_result;
 
-    /* For the group bits, we'll use the ACL's mask instead of the group
-       object bits. If the default ACL had a group entry, it should
-       already have propagated (but might be masked). */
-    if (has_default_mask_read(parent)) {
-      path_mode |= S_IRGRP;
-    }
-    else {
-      path_mode &= ~S_IRGRP;
-    }
+  acl_t defacl = acl_get_file(parent, ACL_TYPE_DEFAULT);
 
-    if (has_default_mask_write(parent)) {
-      path_mode |= S_IWGRP;
-    }
-    else {
-      path_mode &= ~S_IWGRP;
-    }
-
-    if (!mode_has_perm(path_mode, S_IXGRP)) {
-      /* The group ACL entry should already have been inherited from the
-	 default ACL. If the source was not group executable, we want to
-	 modify the destination so that it is not group executable
-	 either. In the presence of ACLs, the group permissions come not
-	 from the mode bits, but from the group:: ACL entry. So, to do
-	 this, we remove the group::x entry. */
-      remove_access_group_obj_execute(path);
-    }
+  if (defacl == (acl_t)NULL) {
+    perror("reapply_default_acl_ng (acl_get_file)");
+    return -1;
+  }
 
-    /* We need to determine whether or not to mask the execute
-       bit. This applies not only to the user/group/other entries, but
-       also to all other named entries. If the original file wasn't
-       executable, then the result probably should not be. To
-       determine whether or not "it was executable", we rely on the
-       user execute bits. Obviously this should be done before we
-       twiddle that bit. */
-    if (has_default_mask_execute(parent)) {
-      if (mode_has_perm(path_mode, S_IXUSR)) {
-	/* This just adds the group execute bit, and doesn't actually
-	     grant group execute permissions. */
-	path_mode |= S_IXGRP;
-      }
-    }
-    else {
-      path_mode &= ~S_IXGRP;
-    }
+  /* Our return value. */
+  int result = 1;
 
+  int wipe_result = wipe_acls(path);
+  if (wipe_result == -1) {
+    perror("reapply_default_acl_ng (wipe_acls)");
+    result = -1;
+    goto cleanup;
   }
-  else {
-    /* It's a minimal ACL. We'll repeat for the group bits what we
-       already did for the owner/other bits. */
-    if (has_default_group_obj_acl(parent)) {
-      if (has_default_group_obj_read(parent)) {
-	path_mode |= S_IRGRP;
-      }
-      else {
-	path_mode &= ~S_IRGRP;
-      }
-
 
-      if (has_default_group_obj_write(parent)) {
-	path_mode |= S_IWGRP;
-      }
-      else {
-	path_mode &= ~S_IWGRP;
-      }
+  /* Do this after wipe_acls(), otherwise we'll overwrite the wiped
+     ACL with this one. */
+  acl_t acl = acl_get_file(path, ACL_TYPE_ACCESS);
+  if (acl == (acl_t)NULL) {
+    perror("reapply_default_acl_ng (acl_get_file)");
+    return -1;
+  }
 
-      /* We don't want to set the execute bit on via the ACL unless it
-	 was on originally. */
-      if (!has_default_group_obj_execute(parent)) {
-	path_mode &= ~S_IXGRP;
-      }
-    }
+  /* If it's a directory, inherit the parent's default. */
+  int inherit_result = inherit_default_acl(path, parent);
+  if (inherit_result == -1) {
+    perror("reapply_default_acl_ng (inherit_acls)");
+    result = -1;
+    goto cleanup;
   }
 
+  acl_entry_t entry;
+  int ge_result = acl_get_entry(defacl, ACL_FIRST_ENTRY, &entry);
 
-  /* If parent has a default user ACL, apply it. */
-  if (has_default_user_obj_acl(parent)) {
+  while (ge_result == 1) {
+    acl_tag_t tag = ACL_UNDEFINED_TAG;
+    int tag_result = acl_get_tag_type(entry, &tag);
 
-    if (has_default_user_obj_read(parent)) {
-      /* Add user read. */
-      path_mode |= S_IRUSR;
-    }
-    else {
-      /* Remove user read. */
-      path_mode &= ~S_IRUSR;
+    if (tag_result == -1) {
+       perror("has_default_tag_acl (acl_get_tag_type)");
+       result = -1;
+       goto cleanup;
     }
 
 
-    if (has_default_user_obj_write(parent)) {
-      /* Add user write. */
-      path_mode |= S_IWUSR;
-    }
-    else {
-      /* Remove user write. */
-      path_mode &= ~S_IWUSR;
+    /* We've got an entry/tag from the default ACL. Get its permset. */
+    acl_permset_t permset;
+    int ps_result = acl_get_permset(entry, &permset);
+    if (ps_result == -1) {
+      perror("reapply_default_acl_ng (acl_get_permset)");
+      result = -1;
+      goto cleanup;
     }
 
+    /* If this is a default mask, fix it up. */
+    if (tag == ACL_MASK ||
+	tag == ACL_USER_OBJ ||
+	tag == ACL_GROUP_OBJ ||
+	tag == ACL_OTHER) {
+      if (!allow_exec) {
+	/* The mask doesn't affect acl_user_obj, acl_group_obj (in
+	   minimal ACLs) or acl_other entries, so if execute should be
+	   masked, we have to do it manually. */
+	int d_result = acl_delete_perm(permset, ACL_EXECUTE);
+	if (d_result == -1) {
+	  perror("reapply_default_acl_ng (acl_delete_perm)");
+	  result = -1;
+	  goto cleanup;
+	}
+
+	int sp_result = acl_set_permset(entry, permset);
+	if (sp_result == -1) {
+	  perror("reapply_default_acl_ng (acl_set_permset)");
+	  result = -1;
+	  goto cleanup;
+	}
+      }
+    }
 
-    /* We don't want to set the execute bit on via the ACL unless it
-       was on originally. */
-    if (!has_default_user_obj_execute(parent)) {
-      /* Remove user execute. */
-      path_mode &= ~S_IXUSR;
+    /* Finally, add the permset to the access ACL. */
+    int set_result = acl_set_entry(&acl, entry);
+    if (set_result == -1) {
+      perror("reapply_default_acl_ng (acl_set_entry)");
+      result = -1;
+      goto cleanup;
     }
+
+    ge_result = acl_get_entry(defacl, ACL_NEXT_ENTRY, &entry);
   }
 
+  /* Catches the first acl_get_entry as well as the ones at the end of
+     the loop. */
+  if (ge_result == -1) {
+    perror("reapply_default_acl_ng (acl_get_entry)");
+    result = -1;
+    goto cleanup;
+  }
 
-  /* Do the same thing with the other perms/ACL. */
-  if (has_default_other_acl(parent)) {
+  int sf_result = acl_set_file(path, ACL_TYPE_ACCESS, acl);
+  if (sf_result == -1) {
+    perror("reapply_default_acl_ng (acl_set_file)");
+    result = -1;
+    goto cleanup;
+  }
 
-    if (has_default_other_read(parent)) {
-      path_mode |= S_IROTH;
-    }
-    else {
-      path_mode &= ~S_IROTH;
-    }
+ cleanup:
+  acl_free(defacl);
+  return result;
+}
 
 
-    if (has_default_other_write(parent)) {
-      path_mode |= S_IWOTH;
-    }
-    else {
-      path_mode &= ~S_IWOTH;
-    }
+void usage(char* program_name) {
+  /*
+   * Print usage information.
+   */
+  printf("Reapply any applicable default ACLs to the given files or "
+	 "directories.\n\n");
+  printf("Usage: %s <target1> [<target2> [ <target3>...]]\n", program_name);
+}
 
 
-    /* We don't want to set the execute bit on via the ACL unless it
-       was on originally. */
-    if (!has_default_other_execute(parent)) {
-      path_mode &= ~S_IXOTH;
+bool asked_for_help(int argc, char* argv[]) {
+  /*
+   * Check argv for either form of the "help" flag, -h or --help.
+   */
+  int arg_index = 1;
+  for (arg_index = 1; arg_index < argc; arg_index++) {
+    if (!strcmp(argv[arg_index], "-h")) {
+      return true;
+    }
+    if (!strcmp(argv[arg_index], "--help")) {
+      return true;
     }
   }
 
-  int chmod_result = chmod(path, path_mode);
-  if (chmod_result == 0) {
-    return 1;
-  }
-  else {
-    return 0;
-  }
+  return false;
 }
 
 
 int main(int argc, char* argv[]) {
-   const char* target = argv[1];
+  /*
+   * Call reapply_default_acl on each command-line argument.
+   */
+  if (argc < 2) {
+    usage(argv[0]);
+    return EXIT_FAILURE;
+  }
 
-   bool result = reapply_default_acl(target);
+  if (asked_for_help(argc, argv)) {
+    usage(argv[0]);
+    return EXIT_SUCCESS;
+  }
+
+  int result = EXIT_SUCCESS;
+
+  int arg_index = 1;
+  for (arg_index = 1; arg_index < argc; arg_index++) {
+    const char* target = argv[arg_index];
+    bool reapp_result = reapply_default_acl(target);
+
+    if (!reapp_result) {
+      result = EXIT_FAILURE;
+    }
+  }
 
-   if (result) {
-     return EXIT_SUCCESS;
-   }
-   else {
-     return EXIT_FAILURE;
-   }
+  return result;
 }