sys-user_pkg_pretend() {
# Sanity checks that would otherwise run code in global scope.
-
- # Next ensure that no other username owns an important UID.
if [[ "${SYS_USER_UID_IMPORTANT}" == "true" ]]; then
- # Ok, the UID is important. Make sure nobody else has it. Or
+
+ # The UID is important, so make sure nobody else has it. Or
# rather, nobody else *with a different username* has it.
local oldname=$(sys-user_getname "${SYS_USER_UID}")
- if [[ "${SYS_USER_NAME}" != "${oldname}" ]]; then
+ if [[ -n "${oldname}" ]] && \
+ [[ "${SYS_USER_NAME}" != "${oldname}" ]]; then
die "important UID ${SYS_USER_UID} already belongs to ${oldname}"
fi
- fi
- # Finally, ensure that this username doesn't already exist with
- # another UID if its UID is supposedly important.
- local olduid=$(sys-user_getuid "${SYS_USER_NAME}")
- if [[ -n "${olduid}" ]]; then
- if [[ "${SYS_USER_UID_IMPORTANT}" == "true" ]] && \
+ # Ensure that this username doesn't already exist with another
+ # UID if its UID is supposedly important.
+ local olduid=$(sys-user_getuid "${SYS_USER_NAME}")
+ if [[ -n "${olduid}" ]] && \
[[ "${SYS_USER_UID}" != "${olduid}" ]]; then
# The UID is important and specified, but there is already a
# system user with this name and a different UID. Halp.
# We have successfully done nothing.
ewarn "Tried to remove nonexistent user ${SYS_USER_NAME}."
elif [[ -z "${REPLACING_VERSIONS}" ]]; then
- # The user to remove exists, and this is not an upgrade, so
- # we really do remove him.
- userdel "${SYS_USER_NAME}" || \
- die "failed to remove user ${SYS_USER_NAME}"
- einfo "Removed user ${SYS_USER_NAME} from the system."
+ # The user to remove exists, and this is not an upgrade. For
+ # Phase 1, we maintain the status quo and simply refuse to
+ # remove him (unless you know what you are doing).
+ if [[ "${I_KNOW_WHAT_I_AM_DOING}" == "yes" ]]; then
+ userdel "${SYS_USER_NAME}" || \
+ die "failed to remove user ${SYS_USER_NAME}"
+ einfo "Removed user ${SYS_USER_NAME} from the system."
+ else
+ die "refusing to remove package for system user ${SYS_USER_NAME}"
+ fi
# The missing case: if the user exists and this is an upgrade,
# we leave the user alone to be modified in