From: Michael Orlitzky <michael@orlitzky.com>
Date: Wed, 23 Oct 2019 14:14:53 +0000 (-0400)
Subject: xfce4-hdaps-dialogs.c: replace GTK_STOCK macros with their values.
X-Git-Tag: v1.0.0~17
X-Git-Url: http://gitweb.michael.orlitzky.com/?p=xfce4-hdaps.git;a=commitdiff_plain;h=273c8f913b14f9db603e64c8a3291a4abd9c99f0

xfce4-hdaps-dialogs.c: replace GTK_STOCK macros with their values.

The GTK_STOCK_* macros are all deprecated and are throwing warnings in
gtk+-3.x. But apparently, hard-coding the value of the macro is fine?
This is what the examples in libxfce4ui do at least. On the other
hand, the "stock items migration guide" suggests that we should use
newer icon names from the freedesktop.org specification.

Having tried the new names, I am happy to say that they don't work at
all, leaving me with the obviously-correct solution in this commit: to
replace the deprecated macros with their hard-coded values verbatim.
---

diff --git a/panel-plugin/xfce4-hdaps-dialogs.c b/panel-plugin/xfce4-hdaps-dialogs.c
index cd8f36a..b5d6fb1 100644
--- a/panel-plugin/xfce4-hdaps-dialogs.c
+++ b/panel-plugin/xfce4-hdaps-dialogs.c
@@ -102,9 +102,9 @@ void hdaps_configure(XfcePanelPlugin *plugin,
   dialog = xfce_titled_dialog_new_with_buttons(_("Hdaps Plugin"),
 					       GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (plugin))),
 					       GTK_DIALOG_DESTROY_WITH_PARENT,
-					       GTK_STOCK_HELP, GTK_RESPONSE_HELP,
-					       GTK_STOCK_SAVE, GTK_RESPONSE_OK,
-					       GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
+					       "gtk-help", GTK_RESPONSE_HELP,
+					       "gtk-save", GTK_RESPONSE_OK,
+					       "gtk-cancel", GTK_RESPONSE_CANCEL,
 					       NULL);
 
   /* Center the dialog on screen. */