From f38e111cd026f1ecdab6dd2d2ed194a8745252a8 Mon Sep 17 00:00:00 2001 From: Michael Orlitzky Date: Mon, 8 Mar 2021 22:04:15 -0500 Subject: [PATCH] eja: undo overzealous hack in _all2list; the bug was elsewhere. --- mjo/eja/eja_utils.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/mjo/eja/eja_utils.py b/mjo/eja/eja_utils.py index 6f8cab6..7c6c581 100644 --- a/mjo/eja/eja_utils.py +++ b/mjo/eja/eja_utils.py @@ -106,13 +106,6 @@ def _all2list(x): [3, 4, 1, 0, 0, 0, 0, 0, 0, 0] """ - if hasattr(x, 'list') and hasattr(x, 'to_vector'): - # This avoids calling to_vector() on a matrix algebra with - # e.g. quaternions where the returned vector is of the wrong - # length (three instead of four) because the quaternions don't - # know how many generators they have. - return _all2list(x.list()) - if hasattr(x, 'to_vector'): # This works on matrices of e.g. octonions directly, without # first needing to convert them to a list of octonions and -- 2.43.2