From db5226c4f5478db40d844b99077a5b164ef6d714 Mon Sep 17 00:00:00 2001 From: Michael Orlitzky Date: Sun, 22 Nov 2020 17:58:17 -0500 Subject: [PATCH] TODO: remove two completed items. --- mjo/eja/TODO | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/mjo/eja/TODO b/mjo/eja/TODO index ffa4f7c..f09191e 100644 --- a/mjo/eja/TODO +++ b/mjo/eja/TODO @@ -4,17 +4,14 @@ 3. Implement the octonion simple EJA. -4. Factor out the unit-norm basis (and operator symmetry) tests once - all of the algebras pass. +4. Override random_instance(), one(), et cetera in DirectSumEJA. -5. Override random_instance(), one(), et cetera in DirectSumEJA. - -6. Switch to QQ in *all* algebras for _charpoly_coefficients(). +5. Switch to QQ in *all* algebras for _charpoly_coefficients(). This only works when we know that the basis can be rationalized... which is the case at least for the concrete EJAs we provide, but not in general. -7. Pass already_echelonized (default: False) and echelon_basis +6. Pass already_echelonized (default: False) and echelon_basis (default: None) into the subalgebra constructor. The value of already_echelonized can be passed to V.span_of_basis() to save some time, and usinf e.g. FreeModule_submodule_with_basis_field @@ -24,10 +21,4 @@ This may require supporting "basis" as a list of basis vectors (as opposed to superalgebra elements) in the subalgebra constructor. -8. Implement random_instance() for general algebras as random_eja(). - Copy/paste the "general" construction into the other classes that - can use it. The general construction can be something like "call - random_instance() on something that inherits me and return the - result." - -9. Use charpoly for inverse stuff if it's cached. +7. Use charpoly for inverse stuff if it's cached. -- 2.43.2