From: Michael Orlitzky Date: Thu, 25 Feb 2021 23:08:17 +0000 (-0500) Subject: eja: remove the subalgebra bug TODO, it's not a new bug. X-Git-Url: http://gitweb.michael.orlitzky.com/?p=sage.d.git;a=commitdiff_plain;h=4c19598e53d8dd21c1cf92351fea2951db8e9cf4 eja: remove the subalgebra bug TODO, it's not a new bug. Element subalgebra computations don't work over inexact fields because we can't compute the degree of an element because we can't compute the rank of a matrix. --- diff --git a/mjo/eja/TODO b/mjo/eja/TODO index feaf98a..e925c16 100644 --- a/mjo/eja/TODO +++ b/mjo/eja/TODO @@ -21,9 +21,5 @@ sage: a0 = (1/4)*X[4]**2*X[6]**2 - (1/2)*X[2]*X[5]*X[6]**2 - (1/2)*X[3]*X[4]*X[6 True/False values for the example classes, and of course add an _is_associative() method. -7. When field=RDF, subalgebra construction is failing because the - inner product isn't associative? Actually, it's the combination - of field=RDF and orthonormalize=True. - -8. Set check_axioms=False for element-subalgebras outside of once or +7. Set check_axioms=False for element-subalgebras outside of once or twice in the test suite. diff --git a/mjo/eja/eja_element.py b/mjo/eja/eja_element.py index 876777e..5a2ff5a 100644 --- a/mjo/eja/eja_element.py +++ b/mjo/eja/eja_element.py @@ -910,7 +910,7 @@ class FiniteDimensionalEJAElement(IndexedFreeModuleElement): M = matrix([(self.parent().one()).to_vector()]) old_rank = 1 - # Specifying the row-reduction algorithm can e.g. help over + # Specifying the row-reduction algorithm can e.g. help over # AA because it avoids the RecursionError that gets thrown # when we have to look too hard for a root. #