From: Michael Orlitzky <michael@orlitzky.com>
Date: Tue, 9 Mar 2021 06:23:48 +0000 (-0500)
Subject: matrix_algebra: put basis in the usual (row,column) order.
X-Git-Url: http://gitweb.michael.orlitzky.com/?p=sage.d.git;a=commitdiff_plain;h=43783fbb6e8292a67506f6df876ab1de6dab68b1

matrix_algebra: put basis in the usual (row,column) order.
---

diff --git a/mjo/hurwitz.py b/mjo/hurwitz.py
index 1f7c9dc..e280034 100644
--- a/mjo/hurwitz.py
+++ b/mjo/hurwitz.py
@@ -319,6 +319,7 @@ class HurwitzMatrixAlgebraElement(MatrixAlgebraElement):
             sage: A = HurwitzMatrixAlgebra(2, QQbar, ZZ)
             sage: M = A([ [ I,   2*I],
             ....:         [ 3*I, 4*I] ])
+            sage: M.conjugate_transpose()
             +------+------+
             | -1*I | -3*I |
             +------+------+
diff --git a/mjo/matrix_algebra.py b/mjo/matrix_algebra.py
index d67347b..84aa8d2 100644
--- a/mjo/matrix_algebra.py
+++ b/mjo/matrix_algebra.py
@@ -198,8 +198,6 @@ class MatrixAlgebra(CombinatorialFreeModule):
         # sticking a "1" in each position doesn't give us a basis for
         # the space. We actually need to stick each of e0, e1, ...  (a
         # basis for the entry algebra itself) into each position.
-        I = range(n)
-        J = range(n)
         self._entry_algebra = entry_algebra
 
         # Needs to make the (overridden) method call when, for example,
@@ -207,8 +205,8 @@ class MatrixAlgebra(CombinatorialFreeModule):
         # lies to us.
         entry_basis = self.entry_algebra_gens()
 
-        basis_indices = [(i,j,e) for i in range(n)
-                                 for j in range(n)
+        basis_indices = [(i,j,e) for j in range(n)
+                                 for i in range(n)
                                  for e in entry_basis]
 
         super().__init__(scalars,