eja: fix trivial subalgebra element constructor.

[sage.d.git] / mjo / eja / eja_subalgebra.py

diff --git a/mjo/eja/eja_subalgebra.py b/mjo/eja/eja_subalgebra.py
index 4458a7e06d9d905ab276665a210eb7dc8275320b..c8bf548e2264edf8d2ee53d82f1dbf5e78ead8f7 100644 (file)
--- a/mjo/eja/eja_subalgebra.py
+++ b/mjo/eja/eja_subalgebra.py
@@ -1,4 +1,5 @@
 from sage.matrix.constructor import matrix
+from sage.misc.cachefunc import cached_method
 
 from mjo.eja.eja_algebra import FiniteDimensionalEJA
 from mjo.eja.eja_element import FiniteDimensionalEJAElement
@@ -84,7 +85,7 @@ class FiniteDimensionalEJASubalgebraElement(FiniteDimensionalEJAElement):
             True
 
         """
-        return self.parent().superalgebra()(self.to_matrix())
+        return self.parent().superalgebra_embedding()(self)
 
 
 
@@ -209,7 +210,17 @@ class FiniteDimensionalEJASubalgebra(FiniteDimensionalEJA):
 
         """
         if elt in self.superalgebra():
-            return super()._element_constructor_(elt.to_matrix())
+            # If the subalgebra is trivial, its _matrix_span will be empty
+            # but we still want to be able convert the superalgebra's zero()
+            # element into the subalgebra's zero() element. There's no great
+            # workaround for this because sage checks that your basis is
+            # linearly-independent everywhere, so we can't just give it a
+            # basis consisting of the zero element.
+            m = elt.to_matrix()
+            if self.is_trivial() and m.is_zero():
+                return self.zero()
+            else:
+                return super()._element_constructor_(m)
         else:
             return super()._element_constructor_(elt)
 
@@ -221,4 +232,39 @@ class FiniteDimensionalEJASubalgebra(FiniteDimensionalEJA):
         return self._superalgebra
 
 
+    @cached_method
+    def superalgebra_embedding(self):
+        r"""
+        Return the embedding from this subalgebra into the superalgebra.
+
+        SETUP::
+
+            sage: from mjo.eja.eja_algebra import HadamardEJA
+
+        EXAMPLES::
+
+            sage: J = HadamardEJA(4)
+            sage: A = J.one().subalgebra_generated_by()
+            sage: iota = A.superalgebra_embedding()
+            sage: iota
+            Linear operator between finite-dimensional Euclidean Jordan algebras represented by the matrix:
+            [1/2]
+            [1/2]
+            [1/2]
+            [1/2]
+            Domain: Euclidean Jordan algebra of dimension 1 over Algebraic Real Field
+            Codomain: Euclidean Jordan algebra of dimension 4 over Algebraic Real Field
+            sage: iota(A.one()) == J.one()
+            True
+
+        """
+        from mjo.eja.eja_operator import FiniteDimensionalEJAOperator
+        mm = self._module_morphism(lambda j: self.superalgebra()(self.monomial(j).to_matrix()),
+                                   codomain=self.superalgebra())
+        return FiniteDimensionalEJAOperator(self,
+                                            self.superalgebra(),
+                                            mm.matrix())
+
+
+
     Element = FiniteDimensionalEJASubalgebraElement