X-Git-Url: http://gitweb.michael.orlitzky.com/?p=numerical-analysis.git;a=blobdiff_plain;f=src%2FLinear%2FQR.hs;h=283512a29494da41cb24db69ee2170cb213e53f1;hp=ea72958d74163c30679ce75231b5a48a8f0f45dd;hb=ae914d13235a4582077a5cb2b1edd630d9c6ad62;hpb=6b6bae4206bab66823617e2ba77cdf3e8d3fb752 diff --git a/src/Linear/QR.hs b/src/Linear/QR.hs index ea72958..283512a 100644 --- a/src/Linear/QR.hs +++ b/src/Linear/QR.hs @@ -12,7 +12,6 @@ import qualified Algebra.Ring as Ring ( C ) import qualified Algebra.Algebraic as Algebraic ( C ) import Data.Vector.Fixed ( ifoldl ) import Data.Vector.Fixed.Cont ( Arity ) -import Debug.Trace import NumericPrelude hiding ( (*) ) import Linear.Matrix ( @@ -98,6 +97,9 @@ givens_rotator i j xi xj = -- factorization. We keep the pair updated by multiplying @q@ and -- @r@ by the new rotator (or its transpose). -- +-- We do not require that the diagonal elements of R are positive, +-- so our factorization is a little less unique than usual. +-- -- Examples: -- -- >>> import Linear.Matrix