From ab5d1f7b27c0d100c1af15561815acf4a10b2f00 Mon Sep 17 00:00:00 2001
From: Michael Orlitzky <michael@orlitzky.com>
Date: Tue, 23 Aug 2022 21:07:01 -0400
Subject: [PATCH] makefile: move ghc-options here from the cabal file.

---
 list-remote-forwards.cabal | 50 --------------------------------------
 makefile                   | 20 ++++++++++++---
 2 files changed, 17 insertions(+), 53 deletions(-)

diff --git a/list-remote-forwards.cabal b/list-remote-forwards.cabal
index fe8761e..0d6f5d4 100644
--- a/list-remote-forwards.cabal
+++ b/list-remote-forwards.cabal
@@ -177,23 +177,6 @@ executable list-remote-forwards
     Report
     String
 
-  ghc-options:
-    -Wall
-    -fwarn-hi-shadowing
-    -fwarn-missing-signatures
-    -fwarn-name-shadowing
-    -fwarn-orphans
-    -fwarn-type-defaults
-    -fwarn-tabs
-    -fwarn-incomplete-record-updates
-    -fwarn-monomorphism-restriction
-    -fwarn-unused-do-bind
-    -rtsopts
-    -threaded
-    -optc-O3
-    -optc-march=native
-
-
 test-suite testsuite
   type: exitcode-stdio-1.0
   hs-source-dirs: src test
@@ -215,21 +198,6 @@ test-suite testsuite
     tasty-hunit                 >= 0.8,
     tasty-quickcheck            >= 0.8
 
-  -- It's not entirely clear to me why I have to reproduce all of this.
-  ghc-options:
-    -Wall
-    -fwarn-hi-shadowing
-    -fwarn-missing-signatures
-    -fwarn-name-shadowing
-    -fwarn-orphans
-    -fwarn-type-defaults
-    -fwarn-tabs
-    -fwarn-incomplete-record-updates
-    -fwarn-monomorphism-restriction
-    -fwarn-unused-do-bind
-    -O2
-
-
 test-suite doctests
   type: exitcode-stdio-1.0
   hs-source-dirs: test
@@ -240,24 +208,6 @@ test-suite doctests
     doctest   >= 0.9,
     filemanip >= 0.3.6
 
-  -- It's not entirely clear to me why I have to reproduce all of this.
-  ghc-options:
-    -Wall
-    -fwarn-hi-shadowing
-    -fwarn-missing-signatures
-    -fwarn-name-shadowing
-    -fwarn-orphans
-    -fwarn-type-defaults
-    -fwarn-tabs
-    -fwarn-incomplete-record-updates
-    -fwarn-monomorphism-restriction
-    -fwarn-unused-do-bind
-    -rtsopts
-    -threaded
-    -optc-O3
-    -optc-march=native
-
-
 source-repository head
   type: git
   location: http://gitweb.michael.orlitzky.com/list-remote-forwards.git
diff --git a/makefile b/makefile
index c024def..c6094aa 100644
--- a/makefile
+++ b/makefile
@@ -2,11 +2,25 @@ PN            = list-remote-forwards
 BIN           = dist/build/$(PN)/$(PN)
 SRCS          = $(shell find src/ -type f -name '*.hs')
 
+# Append these warnings to the HCFLAGS environment variable that gets
+# passed as options to GHC. We want to see the warnings while developing
+# but don't want them hard-coded in the cabal file for end users.
+HCFLAGS += -Weverything \
+           -Wno-implicit-prelude \
+           -Wno-safe \
+           -Wno-unsafe \
+           -Wno-all-missed-specialisations \
+           -Wno-prepositive-qualified-module \
+           -Wno-missing-safe-haskell-mode \
+           -Wno-missing-deriving-strategies \
+           -rtsopts \
+           -threaded
+
 .PHONY : dist hlint
 
 $(BIN): $(PN).cabal $(SRCS)
 	runghc Setup.hs configure --user
-	runghc Setup.hs build
+	runghc Setup.hs build --ghc-options="${HCFLAGS}"
 
 doc: $(PN).cabal $(SRCS)
 	runghc Setup.hs hscolour --all
@@ -24,12 +38,12 @@ TEST_SRCS := $(shell find test/ -type f -name '*.hs')
 
 $(TESTSUITE_BIN): $(PN).cabal $(SRCS) $(TEST_SRCS)
 	runghc Setup.hs configure --user --enable-tests --prefix=/
-	runghc Setup.hs build
+	runghc Setup.hs build --ghc-options="${HCFLAGS}"
 
 
 $(DOCTESTS_BIN): $(PN).cabal $(SRCS) $(TEST_SRCS)
 	runghc Setup.hs configure --user --enable-tests
-	runghc Setup.hs build
+	runghc Setup.hs build --ghc-options="${HCFLAGS}"
 
 test: $(BIN) $(TESTSUITE_BIN) $(DOCTESTS_BIN)
 	runghc Setup.hs test
-- 
2.43.2