From 0115adecce0ea5d82facf4bd8d7276a9c51db7b3 Mon Sep 17 00:00:00 2001 From: Michael Orlitzky Date: Wed, 9 Nov 2016 09:38:04 -0500 Subject: [PATCH] Remove two TODOs that were addressed with larger fudge factors in tests. --- TODO | 34 ---------------------------------- 1 file changed, 34 deletions(-) diff --git a/TODO b/TODO index 6ba8caa..4cbf01d 100644 --- a/TODO +++ b/TODO @@ -8,40 +8,6 @@ 4. Come up with a fast heuristic (like making nu huge and taking e1 as our point) that finds a primal feasible point. -7. Figure out why this happens, too: - - FAIL: test_scaling_icecream (test.symmetric_linear_game_test - .SymmetricLinearGameTest) - ---------------------------------------------------------------------- - Traceback (most recent call last): - File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", - line 336, in test_scaling_icecream - self.assert_scaling_works(L, K, e1, e2) - File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", - line 318, in assert_scaling_works - self.assert_within_tol(alpha*value1, value2) - File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", - line 254, in assert_within_tol - self.assertTrue(abs(first - second) < options.ABS_TOL) - AssertionError: False is not true - - - FAIL: test_translation_orthant (test.symmetric_linear_game_test - SymmetricLinearGameTest) - ---------------------------------------------------------------------- - Traceback (most recent call last): - File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", - line 374, in test_translation_orthant - self.assert_translation_works(L, K, e1, e2) - File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", - line 366, in assert_translation_works - self.assert_within_tol(value2, inner_product(M*x_bar, y_bar)) - File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", - line 254, in assert_within_tol - self.assertTrue(abs(first - second) < options.ABS_TOL) - AssertionError: False is not true - - 12. Investigate this test failure too. It looks like it was really close to being solved, but we would have needed a fudge factor of three instead of two. -- 2.43.2