From: Michael Orlitzky <michael@orlitzky.com>
Date: Thu, 15 Sep 2022 03:10:48 +0000 (-0400)
Subject: bin/djbdns-logparse.py: add docs/examples for handle_tinydns_log().
X-Git-Tag: 0.0.1~51
X-Git-Url: http://gitweb.michael.orlitzky.com/?p=djbdns-logparse.git;a=commitdiff_plain;h=a9488224389519d37972285eaf0363b5e249f545

bin/djbdns-logparse.py: add docs/examples for handle_tinydns_log().
---

diff --git a/bin/djbdns-logparse.py b/bin/djbdns-logparse.py
index 3a25a5a..ed85381 100755
--- a/bin/djbdns-logparse.py
+++ b/bin/djbdns-logparse.py
@@ -176,11 +176,37 @@ def handle_dnscache_log(line, match):
     print(timestamp, event, " ".join(words))
 
 
-def handle_tinydns_log(line, match):
+def handle_tinydns_log(line : str, match: re.Match):
+    """
+    Handle a line that matched the ``tinydns_log_re`` regex.
+
+    Parameters
+    ----------
+
+    line : string
+        The tinydns log line that matched ``tinydns_log_re``.
+
+    match : re.Match
+        The match object that was returned when ``line`` was
+        tested against ``tinydns_log_re``.
+
+    Examples
+    --------
+
+        >>> line = "2022-09-14 21:04:40.206516500 7f000001:9d61:be69 - 0001 www.example.com"
+        >>> match = tinydns_log_re.match(line)
+        >>> handle_tinydns_log(line, match)
+        2022-09-14 21:04:40.206516500 dropped query (no authority) from 127.0.0.1:40289 (id 48745): a www.example.com
+
+    """
     (timestamp, ip, port, id, code, type, name) = match.groups()
     ip = convert_ip(ip)
     port = int(port, 16)
     id = int(id, 16)
+
+    # Convert the "type" field to a human-readable record type name
+    # using the query_type dictionary. If the right name isn't present
+    # in the dictionary, we use the (decimal) type id instead.
     type = int(type, 16)                # "001c" -> 28
     type = query_type.get(type, type)   # 28 -> "aaaa"