CurlFollowLocation True,
-- Give it a little time...
- CurlTimeout 45,
-
- -- For debugging.
- CurlVerbose True ]
+ CurlTimeout 45 ]
make_cookie_jar :: IO FilePath
-- | Log in using curl. Store the resulting session cookies in the
--- supplied file.Warning: This returns an error if the function
--- fails!
-log_in :: FilePath -> String -> String -> IO (Maybe String)
+-- supplied file.
+log_in :: FilePath -> String -> String -> IO (Either String String)
log_in cookie_jar username password =
withCurlDo $ do
-- Create a curl instance.
return $
case code of
- CurlOK -> Nothing
- error_code -> Just $ "HTTP Error: " ++ (show error_code)
+ CurlOK -> Right (respBody resp)
+ error_code -> Left $ "HTTP Error: " ++ (show error_code)
-- If an error occurred, we want to dump as much information as
-- possible. If this becomes a problem, we can use respGetInfo to
-- query the response object for more information
module Main
where
-import Control.Concurrent (threadDelay)
-import Control.Monad (when)
-import Data.Maybe (fromJust, isJust)
+import Data.List (isPrefixOf)
+import Data.Maybe (fromJust)
import Prelude hiding (readFile)
import System.Directory (doesFileExist)
import System.IO (
import Configuration (Cfg(..), get_cfg, use_account)
import LWN.HTTP (get_page, log_in, make_cookie_jar)
import LWN.Page (epublish, parse)
-import LWN.URI (add_trailing_slash, is_lwn_url, make_absolute_url, make_https)
-import Misc (contains)
+import LWN.URI (
+ add_trailing_slash,
+ is_lwn_url,
+ try_make_absolute_url,
+ make_https)
+
my_read_opts :: SysConfigList
my_read = readString my_read_opts
--- |A wrapper around threadDelay which takes seconds instead of
--- microseconds as its argument.
-thread_sleep :: Int -> IO ()
-thread_sleep seconds = do
- let microseconds = seconds * (10 ^ (6 :: Int))
- threadDelay microseconds
-
-
-- | Try to parse the given article using HXT. We try a few different
-- methods; if none of them work, we return 'Nothing'.
get_xml_from_article :: Cfg -> IO (Maybe (IOStateArrow s b XmlTree))
(fromJust $ username cfg)
(fromJust $ password cfg)
- -- Without this, the cookie file is empty during
- -- get_page. Whaaat?
- thread_sleep 1
-
- when (isJust li_result) $ do
- let msg = "Failed to log in. " ++ (fromJust li_result)
- hPutStrLn stderr msg
+ case li_result of
+ Left err -> do
+ let msg = "Failed to log in. " ++ err
+ hPutStrLn stderr msg
+ Right response_body -> do
+ hPutStrLn stderr response_body
html <- get_page (Just cj) my_article
-- that, we try to construct a URL from what we're given and do our
-- best.
real_article_path :: String -> IO String
-real_article_path s = do
- is_file <- doesFileExist s
- return $ if is_file then s else add_trailing_slash check_cases
+real_article_path path = do
+ is_file <- doesFileExist path
+ return $ if is_file then path else add_trailing_slash check_cases
where
- abs_current =
- case make_absolute_url "current" of
- Nothing -> s
- Just ac -> ac
- abs_article =
- case make_absolute_url ("Articles/" ++ s) of
- Nothing -> s
- Just as -> as
+ abs_current = try_make_absolute_url ("/" ++ path)
+ abs_article = try_make_absolute_url ("Articles/" ++ path)
check_cases :: String
check_cases
- | is_lwn_url s = make_https s
- | s `contains` "current" = abs_current
- | s =~ "^[0-9]+$" = abs_article
- | otherwise = s -- Give up
+ | is_lwn_url path = make_https path
+ | isPrefixOf "current" path = abs_current
+ | path =~ "^[0-9]+$" = abs_article
+ | otherwise = path -- Give up
main :: IO ()
main = do
cfg <- get_cfg
output_handle <- get_output_handle (output cfg)
-
- when (use_account cfg) $ do
- putStrLn "Using account."
-
maybe_html <- get_xml_from_article cfg
case maybe_html of
actual <- real_article_path "current"
assertEqual "Current article path constructed" expected actual
+test_current_bigpage_article_path :: Assertion
+test_current_bigpage_article_path = do
+ let expected = "https://lwn.net/current/bigpage"
+ actual <- real_article_path "current/bigpage"
+ assertEqual "Current bigpage article path constructed" expected actual
+
test_numbered_article_path :: Assertion
test_numbered_article_path = do
let expected = "https://lwn.net/Articles/69/"
main_tests =
testGroup "Main Tests" [
testCase "Current article path constructed" test_current_article_path,
+ testCase
+ "Current bigpage article path constructed"
+ test_current_bigpage_article_path,
testCase "Numbered article path constructed" test_numbered_article_path,
testCase "Full article path left alone" test_full_article_path,
testCase "Non-https URL made https" test_non_https_article_path ]