X-Git-Url: http://gitweb.michael.orlitzky.com/?p=dead%2Flwn-epub.git;a=blobdiff_plain;f=src%2FMain.hs;h=924b9a558dd59df682d9cbdb3713fceaad0b27f1;hp=655f1bef40c0680bda2c98e2d4ae9bc6f06c2cd8;hb=b18c060e5cb708901eb29f1f27b25c467875a143;hpb=6789361c1ee570df06878535aff73d99b87528a5 diff --git a/src/Main.hs b/src/Main.hs index 655f1be..924b9a5 100644 --- a/src/Main.hs +++ b/src/Main.hs @@ -3,7 +3,7 @@ module Main where import Prelude hiding (readFile) -import System.Directory(doesFileExist) +import System.Directory (doesFileExist) import System.IO ( Handle, IOMode (WriteMode), @@ -11,10 +11,17 @@ import System.IO ( stdout ) import System.IO.UTF8 (readFile) +import Test.HUnit (Assertion, assertEqual) +import Test.Framework (Test, testGroup) +import Test.Framework.Providers.HUnit (testCase) +import Text.Regex.Posix ((=~)) import Text.XML.HXT.Core -import CommandLine (Args(..), apply_args, show_help) +import CommandLine (show_help) +import Configuration (Cfg(..), get_cfg) import LWN.Page +import LWN.URI (is_lwn_url, make_absolute_url, make_https) +import Misc (contains) my_read_opts :: SysConfigList @@ -51,17 +58,36 @@ get_output_handle path = openBinaryFile path WriteMode + -- | Convert the given article to either a URL or a filesystem -- path. If the given article exists on the filesystem, we assume -- it's a file. Otherwise, we check to see if it's a URL. Failing -- that, we try to construct a URL from what we're given and do our -- best. real_article_path :: String -> IO String -real_article_path = return . id +real_article_path s = do + is_file <- doesFileExist s + return $ if is_file then s else check_cases + where + abs_current = + case make_absolute_url "current" of + Nothing -> s + Just ac -> ac + abs_article = + case make_absolute_url ("Articles/" ++ s) of + Nothing -> s + Just as -> as + + check_cases :: String + check_cases + | is_lwn_url s = make_https s + | s `contains` "current" = abs_current + | s =~ "^[0-9]+$" = abs_article + | otherwise = s -- Give up main :: IO () main = do - Args{..} <- apply_args + Cfg{..} <- get_cfg output_handle <- get_output_handle output maybe_html <- get_xml_from_article article @@ -71,10 +97,46 @@ main = do result <- parse html case result of Just stuff -> epublish stuff output_handle - Nothing -> return () + Nothing -> do + _ <- show_help + return () Nothing -> do _ <- show_help return () - putStrLn "Done." + + +test_current_article_path :: Assertion +test_current_article_path = do + let expected = "https://lwn.net/current" + actual <- real_article_path "current" + assertEqual "Current article path constructed" expected actual + +test_numbered_article_path :: Assertion +test_numbered_article_path = do + let expected = "https://lwn.net/Articles/69" + actual <- real_article_path "69" -- I'm twelve + assertEqual "Numbered article path constructed" expected actual + + +test_full_article_path :: Assertion +test_full_article_path = do + let expected = "https://lwn.net/Articles/502979/" + actual <- real_article_path "https://lwn.net/Articles/502979/" + assertEqual "Full article path left alone" expected actual + +test_non_https_article_path :: Assertion +test_non_https_article_path = do + let expected = "https://lwn.net/Articles/502979/" + actual <- real_article_path "http://lwn.net/Articles/502979/" + assertEqual "Non-https URL made https" expected actual + +main_tests :: Test +main_tests = + testGroup "Main Tests" [ + testCase "Current article path constructed" test_current_article_path, + testCase "Numbered article path constructed" test_numbered_article_path, + testCase "Full article path left alone" test_full_article_path, + testCase "Non-https URL made https" test_non_https_article_path ] + \ No newline at end of file