X-Git-Url: http://gitweb.michael.orlitzky.com/?p=dead%2Flwn-epub.git;a=blobdiff_plain;f=src%2FLWN%2FURI.hs;h=7aa4240cf146eee312801881100ce43be087b6e5;hp=0d01e1900852c71dce82e7f75c754fb717be9b76;hb=b18c060e5cb708901eb29f1f27b25c467875a143;hpb=79eb04e3c84bd9514659d0d52c2e862959647aa6 diff --git a/src/LWN/URI.hs b/src/LWN/URI.hs index 0d01e19..7aa4240 100644 --- a/src/LWN/URI.hs +++ b/src/LWN/URI.hs @@ -4,20 +4,17 @@ where import Data.Maybe (fromJust) import Data.String.Utils (split) import Network.URI ( - URI, + URI(..), + URIAuth(..), parseAbsoluteURI, parseURIReference, - uriAuthority, - uriPath, - uriPort, - uriQuery, - uriRegName, - uriScheme + relativeTo, + uriRegName ) import Test.HUnit (Assertion, assertEqual) import Test.Framework (Test, testGroup) import Test.Framework.Providers.HUnit (testCase) -import Text.Regex.Posix +import Text.Regex.Posix ((=~)) -- Distinguish between URLs (Strings) and URIs as provided by the -- Network.URI module. @@ -43,6 +40,19 @@ http_port uri = parse_result = uriAuthority uri +make_https :: URL -> URL +make_https url = + case parse_result of + Nothing -> url -- Shrug? + Just uri -> + if http uri then + show $ uri { uriScheme = "https:" } + else + url -- Leave non-http URLs alone. + where + parse_result = parseURIReference url + + -- | Does this URI use an HTTPS-compatible port? https_port :: URI -> Bool https_port uri = @@ -115,11 +125,46 @@ filename url = let reverse_components = reverse components in case reverse_components of [] -> Nothing - (x:xs) -> Just x + (x:_) -> Just x where parse_result = parseURIReference url + +make_absolute_uri :: URI -> Maybe URI +make_absolute_uri relative_uri = + relativeTo relative_uri base_uri + where + base_auth = URIAuth { uriUserInfo = "", + uriRegName = "lwn.net", + uriPort = "" } + base_uri = URI { uriScheme = "https:", + uriAuthority = Just base_auth, + uriPath = "/", + uriQuery = "", + uriFragment = "" } + + +make_absolute_url :: URL -> Maybe URL +make_absolute_url relative_url = + case parse_result of + Nothing -> Nothing + Just relative_uri -> + let abs_result = make_absolute_uri relative_uri in + case abs_result of + Nothing -> Nothing + Just abs_uri -> Just $ show abs_uri + where + parse_result = parseURIReference relative_url + +-- | Like 'make_absolute_url', except returns its input instead of +-- 'Nothing' if the absolution fails. +try_make_absolute_url :: URL -> URL +try_make_absolute_url url = + case make_absolute_url url of + Nothing -> url + Just abs_url -> abs_url + -- | A List of LWN URLs to use during testing. lwn_urls :: [URL] lwn_urls = [ proto ++ www ++ "lwn.net" ++ path ++ bigpage ++ query | @@ -172,6 +217,23 @@ test_relative_filename_parsed = actual_result = fromJust $ filename url +test_empty_url_conversion :: Assertion +test_empty_url_conversion = + assertEqual "'' converted to lwn.net" expected actual + where + expected = "https://lwn.net/" + actual = fromJust $ make_absolute_url "" + + +test_normal_url_conversion :: Assertion +test_normal_url_conversion = + assertEqual "Image URL is made absolute" expected actual + where + url = "/images/2012/lcj-coughlan-lattimer-sm.jpg" + expected = "https://lwn.net/images/2012/lcj-coughlan-lattimer-sm.jpg" + actual = fromJust $ make_absolute_url url + + uri_tests :: Test uri_tests = testGroup "URI Tests" [ @@ -184,4 +246,8 @@ uri_tests = testGroup "Filename Parsing" [ testCase "Bare filename parsed" test_bare_filename_parsed, testCase "Absolute filename parsed" test_absolute_filename_parsed, - testCase "Relative filename parsed" test_relative_filename_parsed ] ] + testCase "Relative filename parsed" test_relative_filename_parsed ], + + testGroup "Relative -> Absolute Conversion" [ + testCase "Empty URL converted to lwn.net" test_empty_url_conversion, + testCase "Normal URL made absolute" test_normal_url_conversion ]]