From 9e9afb9429b1814b50f0631ccfe6253952e3fda6 Mon Sep 17 00:00:00 2001 From: Michael Orlitzky Date: Sun, 7 Sep 2025 21:19:48 -0400 Subject: [PATCH] GNUmakefile: use the error code from chktex In the past, the error code from chktex was not a reliable indicator of problems. That appears fixed, and we don't get any superfluous output on success, so let's drop the old workaround and just run it. --- GNUmakefile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/GNUmakefile b/GNUmakefile index bc35a3b..8f7e820 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -195,13 +195,11 @@ sage_listings/%.py: sage_listings/%.listing check-boxes: $(BUILDDIR)/$(PN).log @! grep -i 'overfull\|underfull' $< -# Run chktex to find silly mistakes. There is some exit code weirdness -# (Savannah bug 53129), so we just look for empty output. +# Run chktex to find silly mistakes. .PHONY: check-chktex -CHKTEX = chktex --localrc .chktexrc --quiet --inputfiles=0 +CHKTEX = chktex --localrc .chktexrc --quiet --inputfiles=0 --headererr check-chktex: - @chktexout=$$($(CHKTEX) $(PN).tex); \ - test -z "$${chktexout}" || { echo "$${chktexout}" 1>&2; exit 1; } + $(CHKTEX) $(PN).tex # Ensure that there are no undefined references in the document by # parsing the log file for said warnings. -- 2.49.0