From: Michael Orlitzky <michael@orlitzky.com>
Date: Thu, 29 Aug 2019 15:45:52 +0000 (-0400)
Subject: Revert "eja: always use the rationals for denormalized bases."
X-Git-Url: http://gitweb.michael.orlitzky.com/?a=commitdiff_plain;h=b7499c180737961440bd7b25afb2bc194b5f62c5;hp=33b5476e1422a36972979e768f1829cec1b421a5;p=sage.d.git

Revert "eja: always use the rationals for denormalized bases."

This reverts commit 1e3bfabaac18a1118fc4afd632265d91d3d0ec6c.
It broke the tests, and next time I'll do it one step at a time
to keep them working.
---

diff --git a/mjo/eja/eja_algebra.py b/mjo/eja/eja_algebra.py
index 7c2eda2..4673e91 100644
--- a/mjo/eja/eja_algebra.py
+++ b/mjo/eja/eja_algebra.py
@@ -1263,7 +1263,7 @@ class ComplexMatrixEuclideanJordanAlgebra(MatrixEuclideanJordanAlgebra):
         if not n.mod(2).is_zero():
             raise ValueError("the matrix 'M' must be a complex embedding")
 
-        field = QQ
+        field = M.base_ring() # This should already have sqrt2
         R = PolynomialRing(field, 'z')
         z = R.gen()
         F = NumberField(z**2 + 1,'i', embedding=CLF(-1).sqrt())
@@ -1403,7 +1403,7 @@ class ComplexHermitianEJA(ComplexMatrixEuclideanJordanAlgebra, KnownRankEJA):
             True
 
         """
-        R = PolynomialRing(QQ, 'z')
+        R = PolynomialRing(field, 'z')
         z = R.gen()
         F = NumberField(z**2 + 1, 'I', embedding=CLF(-1).sqrt())
         I = F.gen()