X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=src%2FTSN%2FXML%2FOdds.hs;h=5174ddb927462266e80af42eb45171bb49975f41;hb=14dc52a2e7d7712281aee2332f7342f67abe4306;hp=a4fddb97f81597dd35676d37820eba968ced3062;hpb=019325f22e80859ba68a1e4b9985d00031430387;p=dead%2Fhtsn-import.git diff --git a/src/TSN/XML/Odds.hs b/src/TSN/XML/Odds.hs index a4fddb9..5174ddb 100644 --- a/src/TSN/XML/Odds.hs +++ b/src/TSN/XML/Odds.hs @@ -3,44 +3,51 @@ {-# LANGUAGE GADTs #-} {-# LANGUAGE QuasiQuotes #-} {-# LANGUAGE RecordWildCards #-} -{-# LANGUAGE ScopedTypeVariables #-} -{-# LANGUAGE StandaloneDeriving #-} {-# LANGUAGE TemplateHaskell #-} {-# LANGUAGE TypeFamilies #-} +-- | Parse TSN XML for the DTD \"Odds_XML.dtd\". Each document +-- contains a root element \ that contains a bunch of +-- other... disorganized... information. +-- module TSN.XML.Odds ( - Odds, - Message, - odds_tests ) + dtd, + pickle_message, + -- * Tests + odds_tests, + -- * WARNING: these are private but exported to silence warnings + OddsCasinoConstructor(..), + OddsConstructor(..), + OddsGameConstructor(..), + OddsGameLineConstructor(..) ) where - --- | Parse TSN XML for the DTD "Odds_XML.dtd". Each document contains --- a root element \ that contains a bunch of other --- unorganized crap. --- - -import Data.Data ( Data, constrFields, dataTypeConstrs, dataTypeOf ) -import Data.List.Utils ( join, split ) +-- System imports. +import Control.Applicative ( (<$>) ) +import Control.Monad ( forM_, join ) +import Data.Time ( UTCTime(..) ) import Data.Tuple.Curry ( uncurryN ) -import Data.Typeable ( Typeable ) import Database.Groundhog ( - defaultMigrationLogger, - insert, + (=.), + (==.), + countAll, + deleteAll, + insert_, migrate, - runMigration ) + runMigration, + silentMigrationLogger, + update ) import Database.Groundhog.Core ( DefaultKey ) +import Database.Groundhog.Generic ( runDbConn ) +import Database.Groundhog.Sqlite ( withSqliteConn ) import Database.Groundhog.TH ( groundhog, mkPersist ) -import System.Console.CmdArgs.Default ( Default(..) ) import Test.Tasty ( TestTree, testGroup ) import Test.Tasty.HUnit ( (@?=), testCase ) +import Text.Read ( readMaybe ) import Text.XML.HXT.Core ( PU, - XmlPickler(..), - unpickleDoc, - xp5Tuple, xp6Tuple, xp8Tuple, xpAttr, @@ -49,147 +56,325 @@ import Text.XML.HXT.Core ( xpList, xpOption, xpPair, - xpPrim, xpText, - xpText0, xpTriple, xpWrap ) +-- Local imports. import TSN.Codegen ( - tsn_codegen_config, - tsn_db_field_namer ) -import TSN.DbImport ( DbImport(..), ImportResult(..) ) -import TSN.XmlImport ( XmlImport(..) ) -import Xml ( FromXml(..), pickle_unpickle, unpickleable ) + tsn_codegen_config ) +import TSN.DbImport ( DbImport(..), ImportResult(..), run_dbmigrate ) +import TSN.Picklers ( xp_date_padded, xp_time, xp_time_stamp ) +import TSN.Team ( Team(..) ) +import TSN.XmlImport ( XmlImport(..), XmlImportFkTeams(..) ) +import Xml ( + Child(..), + FromXml(..), + FromXmlFkTeams(..), + ToDb(..), + pickle_unpickle, + unpickleable, + unsafe_unpickle ) + + +-- | The DTD to which this module corresponds. Used to invoke dbimport. +-- +dtd :: String +dtd = "Odds_XML.dtd" +-- +-- DB/XML data types +-- -data OddsCasinoXml = - OddsCasinoXml { - xml_casino_client_id :: Int, - xml_casino_name :: String, - xml_casino_line :: Maybe Float } - deriving (Eq, Show) +-- * OddsGameCasino/OddsGameCasinoXml -- | The casinos should have their own table, but the lines don't --- belong in that table. (There should be another table joining the --- casinos and the thing the lines are for together.) +-- belong in that table (there is a separate table for +-- 'OddsGameLine' which associates the two). +-- +-- We drop the \"Game\" prefix because the casinos really aren't +-- children of the games; the XML just makes it seem that way. +-- data OddsCasino = OddsCasino { casino_client_id :: Int, casino_name :: String } deriving (Eq, Show) -instance FromXml OddsCasinoXml where - type Db OddsCasinoXml = OddsCasino - -- We don't need the key argument (from_xml_fk) since the XML type - -- contains more information in this case. - from_xml OddsCasinoXml{..} = OddsCasino - xml_casino_client_id - xml_casino_name +-- | The home/away lines are 'Double's, but the over/under lines are +-- textual. If we want to use one data type for both, we have to go +-- with a 'String' and then attempt to 'read' a 'Double' later when we +-- go to insert the thing. +-- +data OddsGameCasinoXml = + OddsGameCasinoXml { + xml_casino_client_id :: Int, + xml_casino_name :: String, + xml_casino_line :: Maybe String } + deriving (Eq, Show) -instance XmlImport OddsCasinoXml +-- | Try to get a 'Double' out of the 'xml_casino_line' which is a +-- priori textual (because it might be an over/under line). +-- +home_away_line :: OddsGameCasinoXml -> Maybe Double +home_away_line = join . (fmap readMaybe) . xml_casino_line -data OddsHomeTeamXml = - OddsHomeTeamXml { - xml_home_team_id :: Int, - xml_home_rotation_number :: Int, - xml_home_abbr :: String, - xml_home_team_name :: String, - xml_home_casinos :: [OddsCasinoXml] } - deriving (Eq, Show) -instance FromXml OddsHomeTeamXml where - type Db OddsHomeTeamXml = OddsTeam - from_xml OddsHomeTeamXml{..} = OddsTeam - xml_home_team_id - xml_home_abbr - xml_home_team_name -instance XmlImport OddsHomeTeamXml where +instance ToDb OddsGameCasinoXml where + -- | The database representation of an 'OddsGameCasinoXml' is an + -- 'OddsCasino'. + -- + type Db OddsGameCasinoXml = OddsCasino -data OddsTeam = - OddsTeam { - db_team_id :: Int, - db_abbr :: String, - db_team_name :: String } - deriving (Eq, Show) +instance FromXml OddsGameCasinoXml where + -- | We convert from XML to the database by dropping the line field. + -- + from_xml OddsGameCasinoXml{..} = + OddsCasino { + casino_client_id = xml_casino_client_id, + casino_name = xml_casino_name } + + +-- | This allows us to insert the XML representation 'OddsGameCasinoXml' +-- directly. +-- +instance XmlImport OddsGameCasinoXml -data OddsAwayTeamXml = - OddsAwayTeamXml { - xml_away_team_id :: Int, - xml_away_rotation_number :: Int, - xml_away_abbr :: String, - xml_away_team_name :: String, - xml_away_casinos :: [OddsCasinoXml] } + +-- * OddsGameTeamXml + +-- | The XML representation of a \ or \, as +-- found in \s. We can't use the 'Team' representation +-- directly because there are some other fields we need to parse. +-- +-- The starter id/name could perhaps be combined into an embedded +-- type, but can you make an entire embedded type optional with +-- Maybe? I doubt it works. +-- +data OddsGameTeamXml = + OddsGameTeamXml { + xml_team_id :: String, -- ^ The home/away team IDs + -- are three characters but + -- Postgres imposes no + -- performance penalty on + -- lengthless text fields, + -- so we ignore the probable + -- upper bound of three + -- characters. + xml_team_rotation_number :: Maybe Int, + xml_team_abbr :: String, + xml_team_name :: String, + xml_team_starter :: Maybe (Int, String), -- ^ (id, name) + xml_team_casinos :: [OddsGameCasinoXml] } deriving (Eq, Show) -instance FromXml OddsAwayTeamXml where - type Db OddsAwayTeamXml = OddsTeam - from_xml OddsAwayTeamXml{..} = OddsTeam - xml_away_team_id - xml_away_abbr - xml_away_team_name +instance ToDb OddsGameTeamXml where + -- | The database representation of an 'OddsGameTeamXml' is an + -- 'OddsGameTeam'. + -- + type Db OddsGameTeamXml = Team + +instance FromXml OddsGameTeamXml where + -- | We convert from XML to the database by dropping the lines and + -- rotation number (which are specific to the games, not the teams + -- themselves). + -- + from_xml OddsGameTeamXml{..} = + Team { + team_id = xml_team_id, + abbreviation = Just xml_team_abbr, + name = Just xml_team_name } + +-- | This allows us to insert the XML representation +-- 'OddsGameTeamXml' directly. +-- +instance XmlImport OddsGameTeamXml where + -instance XmlImport OddsAwayTeamXml where --- | Can't use a newtype with Groundhog. -data OddsOverUnder = - OddsOverUnder [OddsCasinoXml] + +-- * OddsGameOverUnderXml + +-- | XML representation of the over/under. A wrapper around a bunch of +-- casino elements. +-- +newtype OddsGameOverUnderXml = + OddsGameOverUnderXml { xml_casinos :: [OddsGameCasinoXml] } deriving (Eq, Show) + +-- * OddsGameLine + +-- | This database representation of the casino lines can't be +-- constructed from the one in the XML. The casinos within +-- Game-\>HomeTeam, Game-\>AwayTeam, and Game-\>Over_Under are all more or +-- less the same. We don't need a bajillion different tables to +-- store that, just one tying the casino/game pair to the three +-- lines. +-- +-- The one small difference between the over/under casinos and the +-- home/away ones is that the home/away lines are all 'Double's, but +-- the over/under lines appear to be textual. +-- +data OddsGameLine = + OddsGameLine { + ogl_odds_games_id :: DefaultKey OddsGame, + ogl_odds_casinos_id :: DefaultKey OddsCasino, + ogl_over_under :: Maybe String, + ogl_away_line :: Maybe Double, + ogl_home_line :: Maybe Double } + + +-- * OddsGame/OddsGameXml + +-- | Database representation of a game. We retain the rotation number +-- of the home/away teams, since those are specific to the game and +-- not the teams. +-- data OddsGame = OddsGame { + db_odds_id :: DefaultKey Odds, + db_away_team_id :: DefaultKey Team, + db_home_team_id :: DefaultKey Team, db_game_id :: Int, - db_game_date :: String, -- TODO - db_game_time :: String, -- TODO - db_game_away_team_id :: DefaultKey OddsTeam, - db_game_away_team_rotation_number :: Int, - db_game_home_team_id :: DefaultKey OddsTeam, - db_game_home_team_rotation_number :: Int } -deriving instance Eq OddsGame -deriving instance Show OddsGame + db_game_time :: UTCTime, -- ^ Contains both the date and time. + db_away_team_rotation_number :: Maybe Int, + db_home_team_rotation_number :: Maybe Int, + db_away_team_starter_id :: Maybe Int, + db_away_team_starter_name :: Maybe String, + db_home_team_starter_id :: Maybe Int, + db_home_team_starter_name :: Maybe String } + +-- | XML representation of an 'OddsGame'. +-- data OddsGameXml = OddsGameXml { xml_game_id :: Int, - xml_game_date :: String, -- TODO - xml_game_time :: String, -- TODO - xml_game_away_team :: OddsAwayTeamXml, - xml_game_home_team :: OddsHomeTeamXml, - xml_game_over_under :: OddsOverUnder } + xml_game_date :: UTCTime, -- ^ Contains only the date + xml_game_time :: UTCTime, -- ^ Contains only the time + xml_away_team :: OddsGameTeamXml, + xml_home_team :: OddsGameTeamXml, + xml_over_under :: OddsGameOverUnderXml } deriving (Eq, Show) -data Odds = - Odds { - db_sport :: String, - db_title :: String, - db_line_time :: String } +-- | Pseudo-field that lets us get the 'OddsGameCasinoXml's out of +-- xml_over_under. +-- +xml_over_under_casinos :: OddsGameXml -> [OddsGameCasinoXml] +xml_over_under_casinos = xml_casinos . xml_over_under + + +instance ToDb OddsGameXml where + -- | The database representation of an 'OddsGameXml' is an + -- 'OddsGame'. + -- + type Db OddsGameXml = OddsGame + + +instance Child OddsGameXml where + -- | Each 'OddsGameXml' is contained in an 'Odds'. In other words + -- the foreign key for 'OddsGame' points to an 'Odds'. + -- + type Parent OddsGameXml = Odds + + +instance FromXmlFkTeams OddsGameXml where + -- | To convert from the XML representation to the database one, we + -- drop the casino lines, but retain the home/away rotation + -- numbers and the starters. The foreign keys to 'Odds' and the + -- home/away teams are passed in. + -- + from_xml_fk_teams fk fk_away fk_home OddsGameXml{..} = + OddsGame { + db_odds_id = fk, + db_away_team_id = fk_away, + db_home_team_id = fk_home, + db_game_id = xml_game_id, + + db_game_time = UTCTime + (utctDay xml_game_date) -- Take the day part from one, + (utctDayTime xml_game_time), -- the time from the other. + + db_away_team_rotation_number = + (xml_team_rotation_number xml_away_team), + + db_home_team_rotation_number = + (xml_team_rotation_number xml_home_team), + + db_away_team_starter_id = + (fst <$> xml_team_starter xml_away_team), + + db_away_team_starter_name = + (snd <$> xml_team_starter xml_away_team), + + db_home_team_starter_id = + (fst <$> xml_team_starter xml_home_team), + + db_home_team_starter_name = + (snd <$> xml_team_starter xml_home_team) } + + +-- | This lets us insert the XML representation 'OddsGameXml' directly. +-- +instance XmlImportFkTeams OddsGameXml + + +-- * OddsGameWithNotes -- | This is our best guess at what occurs in the Odds_XML -- documents. It looks like each consecutive set of games can --- optionally have some notes appear before it. Each "note" comes as --- its own ... element. +-- optionally have some notes appear before it. Each \"note\" comes +-- as its own \...\ element. -- -- The notes are ignored completely in the database; we only bother -- with them to ensure that we're (un)pickling correctly. -- --- We can't group the notes with a "set" of 'OddsGame's, because that --- leads to ambiguity in parsing. Since we're going to ignore the --- notes anyway, we just stick them with an arbitrary game. C'est la --- vie. +-- We can't group the notes with a \"set\" of 'OddsGame's, because +-- that leads to ambiguity in parsing. Since we're going to ignore +-- the notes anyway, we just stick them with an arbitrary +-- game. C'est la vie. +-- +-- We have to take the same approach with the league. The +-- \ elements are sitting outside of the games, and +-- are presumably supposed to be interpreted in \"chronological\" +-- order; i.e. the current league stays the same until we see +-- another \ element. Unfortunately, that's not how +-- XML works. So we're forced to ignore the league in the database +-- and pull the same trick, pairing them with games. -- data OddsGameWithNotes = OddsGameWithNotes { + league :: Maybe String, notes :: [String], game :: OddsGameXml } deriving (Eq, Show) --- | The XML representation of Odds. + +-- * Odds/Message + +-- | Database representation of a 'Message'. +-- +data Odds = + Odds { + db_xml_file_id :: Int, + db_sport :: String, + db_title :: String, + db_line_time :: String, -- ^ We don't parse these as a 'UTCTime' + -- because their timezones are ambiguous + -- (and the date is less than useful when + -- it might be off by an hour). + db_time_stamp :: UTCTime } + + +-- | The XML representation of 'Odds'. +-- data Message = Message { xml_xml_file_id :: Int, @@ -199,127 +384,269 @@ data Message = xml_title :: String, xml_line_time :: String, xml_games_with_notes :: [OddsGameWithNotes], - xml_time_stamp :: String } + xml_time_stamp :: UTCTime } deriving (Eq, Show) -- | Pseudo-field that lets us get the 'OddsGame's out of -- 'xml_games_with_notes'. +-- xml_games :: Message -> [OddsGameXml] xml_games m = map game (xml_games_with_notes m) -instance FromXml Message where - type Db Message = Odds - -- We don't need the key argument (from_xml_fk) since the XML type - -- contains more information in this case. - from_xml (Message _ _ _ d e f _ _) = - Odds d e f +instance ToDb Message where + -- | The database representation of a 'Message' is 'Odds'. + -- + type Db Message = Odds +instance FromXml Message where + -- | To convert from the XML representation to the database one, we + -- just drop a bunch of fields. + -- + from_xml Message{..} = + Odds { + db_xml_file_id = xml_xml_file_id, + db_sport = xml_sport, + db_title = xml_title, + db_line_time = xml_line_time, + db_time_stamp = xml_time_stamp } + +-- | This lets us insert the XML representation 'Message' directly. +-- instance XmlImport Message + +-- +-- Database code +-- + +-- Groundhog database schema. This must come before the DbImport +-- instance definition. Don't know why. +mkPersist tsn_codegen_config [groundhog| +- entity: Odds + constructors: + - name: Odds + uniques: + - name: unique_odds + type: constraint + # Prevent multiple imports of the same message. + fields: [db_xml_file_id] + +- entity: OddsCasino + dbName: odds_casinos + constructors: + - name: OddsCasino + uniques: + - name: unique_odds_casino + type: constraint + fields: [casino_client_id] + +- entity: OddsGame + dbName: odds_games + constructors: + - name: OddsGame + fields: + - name: db_odds_id + reference: + onDelete: cascade + - name: db_away_team_id + reference: + onDelete: cascade + - name: db_home_team_id + reference: + onDelete: cascade + +- entity: OddsGameLine + dbName: odds_games_lines + constructors: + - name: OddsGameLine + fields: + - name: ogl_odds_games_id + reference: + onDelete: cascade + - name: ogl_odds_casinos_id + reference: + onDelete: cascade + +|] + instance DbImport Message where - dbmigrate _= undefined - dbimport = undefined + dbmigrate _= + run_dbmigrate $ do + migrate (undefined :: Team) + migrate (undefined :: Odds) + migrate (undefined :: OddsCasino) + migrate (undefined :: OddsGame) + migrate (undefined :: OddsGameLine) + + dbimport m = do + -- Insert the root "odds" element and acquire its primary key (id). + odds_id <- insert_xml m + + forM_ (xml_games m) $ \game -> do + -- First we insert the home and away teams. + away_team_id <- insert_xml_or_select (xml_away_team game) + home_team_id <- insert_xml_or_select (xml_home_team game) + + -- Now insert the game, keyed to the "odds" and its teams. + game_id <- insert_xml_fk_teams odds_id away_team_id home_team_id game + + -- Finally, we insert the lines. The over/under entries for this + -- game and the lines for the casinos all wind up in the same + -- table, odds_games_lines. We can insert the over/under entries + -- freely with empty away/home lines: + forM_ (xml_over_under_casinos game) $ \c -> do + -- Start by inderting the casino. + ou_casino_id <- insert_xml_or_select c + + -- Now add the over/under entry with the casino's id. + let ogl = OddsGameLine { + ogl_odds_games_id = game_id, + ogl_odds_casinos_id = ou_casino_id, + ogl_over_under = (xml_casino_line c), + ogl_away_line = Nothing, + ogl_home_line = Nothing } + + insert_ ogl + + -- ...but then when we insert the home/away team lines, we + -- prefer to update the existing entry rather than overwrite it + -- or add a new record. + forM_ (xml_team_casinos $ xml_away_team game) $ \c -> do + -- insert, or more likely retrieve the existing, casino + a_casino_id <- insert_xml_or_select c + + -- Get a Maybe Double instead of the Maybe String that's in there. + let away_line = home_away_line c + + -- Unconditionally update that casino's away team line with ours. + update [Ogl_Away_Line =. away_line] $ -- WHERE + Ogl_Odds_Casinos_Id ==. a_casino_id + + -- Repeat all that for the home team. + forM_ (xml_team_casinos $ xml_home_team game) $ \c ->do + h_casino_id <- insert_xml_or_select c + let home_line = home_away_line c + update [Ogl_Home_Line =. home_line] $ -- WHERE + Ogl_Odds_Casinos_Id ==. h_casino_id + + return game_id + + return ImportSucceeded + +-- +-- Pickling +-- + +-- | Pickler for an 'OddsGame' optionally preceded by some notes. +-- pickle_game_with_notes :: PU OddsGameWithNotes pickle_game_with_notes = xpWrap (from_pair, to_pair) $ - xpPair + xpTriple + (xpOption $ xpElem "League_Name" xpText) (xpList $ xpElem "Notes" xpText) pickle_game where - from_pair = uncurry OddsGameWithNotes - to_pair OddsGameWithNotes{..} = (notes, game) - + from_pair = uncurryN OddsGameWithNotes + to_pair OddsGameWithNotes{..} = (league, notes, game) -pickle_casino :: PU OddsCasinoXml +-- | Pickler for an 'OddsGameCasinoXml'. +-- +pickle_casino :: PU OddsGameCasinoXml pickle_casino = xpElem "Casino" $ xpWrap (from_tuple, to_tuple) $ xpTriple (xpAttr "ClientID" xpInt) (xpAttr "Name" xpText) - (xpOption xpPrim) -- Float + (xpOption xpText) where - from_tuple = uncurryN OddsCasinoXml + from_tuple = uncurryN OddsGameCasinoXml -- Use record wildcards to avoid unused field warnings. - to_tuple OddsCasinoXml{..} = (xml_casino_client_id, - xml_casino_name, - xml_casino_line) - -instance XmlPickler OddsCasinoXml where - xpickle = pickle_casino + to_tuple OddsGameCasinoXml{..} = (xml_casino_client_id, + xml_casino_name, + xml_casino_line) -pickle_home_team :: PU OddsHomeTeamXml +-- | Pickler for an 'OddsGameTeamXml'. +-- +pickle_home_team :: PU OddsGameTeamXml pickle_home_team = xpElem "HomeTeam" $ xpWrap (from_tuple, to_tuple) $ - xp5Tuple - (xpElem "HomeTeamID" xpInt) - (xpElem "HomeRotationNumber" xpInt) + xp6Tuple + (xpElem "HomeTeamID" xpText) + (xpElem "HomeRotationNumber" (xpOption xpInt)) (xpElem "HomeAbbr" xpText) (xpElem "HomeTeamName" xpText) + (-- This is an ugly way to get both the HStarter ID attribute + -- and contents. + xpOption (xpElem "HStarter" $ xpPair (xpAttr "ID" xpInt) xpText)) (xpList pickle_casino) where - from_tuple = uncurryN OddsHomeTeamXml - -- Use record wildcards to avoid unused field warnings. - to_tuple OddsHomeTeamXml{..} = (xml_home_team_id, - xml_home_rotation_number, - xml_home_abbr, - xml_home_team_name, - xml_home_casinos) - -instance XmlPickler OddsHomeTeamXml where - xpickle = pickle_home_team + from_tuple = uncurryN OddsGameTeamXml - -pickle_away_team :: PU OddsAwayTeamXml + -- Use record wildcards to avoid unused field warnings. + to_tuple OddsGameTeamXml{..} = (xml_team_id, + xml_team_rotation_number, + xml_team_abbr, + xml_team_name, + xml_team_starter, + xml_team_casinos) + +-- | Pickler for an 'OddsGameTeamXml'. +-- +pickle_away_team :: PU OddsGameTeamXml pickle_away_team = xpElem "AwayTeam" $ xpWrap (from_tuple, to_tuple) $ - xp5Tuple - (xpElem "AwayTeamID" xpInt) - (xpElem "AwayRotationNumber" xpInt) + xp6Tuple + (xpElem "AwayTeamID" xpText) + (xpElem "AwayRotationNumber" (xpOption xpInt)) (xpElem "AwayAbbr" xpText) (xpElem "AwayTeamName" xpText) + (-- This is an ugly way to get both the AStarter ID attribute + -- and contents. + xpOption (xpElem "AStarter" $ xpPair (xpAttr "ID" xpInt) xpText)) (xpList pickle_casino) where - from_tuple = uncurryN OddsAwayTeamXml - -- Use record wildcards to avoid unused field warnings. - to_tuple OddsAwayTeamXml{..} = (xml_away_team_id, - xml_away_rotation_number, - xml_away_abbr, - xml_away_team_name, - xml_away_casinos) + from_tuple = uncurryN OddsGameTeamXml + -- Use record wildcards to avoid unused field warnings. + to_tuple OddsGameTeamXml{..} = (xml_team_id, + xml_team_rotation_number, + xml_team_abbr, + xml_team_name, + xml_team_starter, + xml_team_casinos) -instance XmlPickler OddsAwayTeamXml where - xpickle = pickle_away_team -pickle_over_under :: PU OddsOverUnder +-- | Pickler for an 'OddsGameOverUnderXml'. +-- +pickle_over_under :: PU OddsGameOverUnderXml pickle_over_under = xpElem "Over_Under" $ xpWrap (to_newtype, from_newtype) $ xpList pickle_casino where - from_newtype (OddsOverUnder cs) = cs - to_newtype = OddsOverUnder - -instance XmlPickler OddsOverUnder where - xpickle = pickle_over_under + from_newtype (OddsGameOverUnderXml cs) = cs + to_newtype = OddsGameOverUnderXml +-- | Pickler for an 'OddsGameXml'. +-- pickle_game :: PU OddsGameXml pickle_game = xpElem "Game" $ xpWrap (from_tuple, to_tuple) $ xp6Tuple (xpElem "GameID" xpInt) - (xpElem "Game_Date" xpText) - (xpElem "Game_Time" xpText) + (xpElem "Game_Date" xp_date_padded) + (xpElem "Game_Time" xp_time) pickle_away_team pickle_home_team pickle_over_under @@ -329,14 +656,13 @@ pickle_game = to_tuple OddsGameXml{..} = (xml_game_id, xml_game_date, xml_game_time, - xml_game_away_team, - xml_game_home_team, - xml_game_over_under) - -instance XmlPickler OddsGameXml where - xpickle = pickle_game + xml_away_team, + xml_home_team, + xml_over_under) +-- | Pickler for the top-level 'Message'. +-- pickle_message :: PU Message pickle_message = xpElem "message" $ @@ -348,7 +674,7 @@ pickle_message = (xpElem "Title" xpText) (xpElem "Line_Time" xpText) (xpList pickle_game_with_notes) - (xpElem "time_stamp" xpText) + (xpElem "time_stamp" xp_time_stamp) where from_tuple = uncurryN Message to_tuple m = (xml_xml_file_id m, @@ -361,70 +687,122 @@ pickle_message = xml_time_stamp m) -instance XmlPickler Message where - xpickle = pickle_message +-- +-- Tasty Tests +-- +-- | A list of all tests for this module. +-- +odds_tests :: TestTree +odds_tests = + testGroup + "Odds tests" + [ test_on_delete_cascade, + test_pickle_of_unpickle_is_identity, + test_unpickle_succeeds ] +-- | If we unpickle something and then pickle it, we should wind up +-- with the same thing we started with. WARNING: success of this +-- test does not mean that unpickling succeeded. +-- +test_pickle_of_unpickle_is_identity :: TestTree +test_pickle_of_unpickle_is_identity = testGroup "pickle-unpickle tests" + [ check "pickle composed with unpickle is the identity" + "test/xml/Odds_XML.xml", + check "pickle composed with unpickle is the identity (non-int team_id)" + "test/xml/Odds_XML-noninteger-team-id.xml", --- * Groundhog database schema. -mkPersist tsn_codegen_config [groundhog| -- entity: Odds + check "pickle composed with unpickle is the identity (positive(+) line)" + "test/xml/Odds_XML-positive-line.xml", -- entity: OddsCasino - dbName: odds_casinos - constructors: - - name: OddsCasino - uniques: - - name: unique_odds_casino - type: constraint - fields: [casino_client_id] + check "pickle composed with unpickle is the identity (large file)" + "test/xml/Odds_XML-largefile.xml", -- entity: OddsTeam - dbName: odds_teams - constructors: - - name: OddsTeam - uniques: - - name: unique_odds_team - type: constraint - fields: [db_team_id] + check "pickle composed with unpickle is the identity (league name)" + "test/xml/Odds_XML-league-name.xml" ] + where + check desc path = testCase desc $ do + (expected, actual) <- pickle_unpickle pickle_message path + actual @?= expected -- entity: OddsGame - dbName: odds_games - constructors: - - name: OddsGame - uniques: - - name: unique_odds_game - type: constraint - fields: [db_game_id] -|] +-- | Make sure we can actually unpickle these things. +-- +test_unpickle_succeeds :: TestTree +test_unpickle_succeeds = testGroup "unpickle tests" + [ check "unpickling succeeds" + "test/xml/Odds_XML.xml", + check "unpickling succeeds (non-int team_id)" + "test/xml/Odds_XML-noninteger-team-id.xml", --- * Tasty Tests -odds_tests :: TestTree -odds_tests = - testGroup - "Odds tests" - [ test_pickle_of_unpickle_is_identity, - test_unpickle_succeeds ] + check "unpickling succeeds (positive(+) line)" + "test/xml/Odds_XML-positive-line.xml", + check "unpickling succeeds (large file)" + "test/xml/Odds_XML-largefile.xml", --- | Warning, succeess of this test does not mean that unpickling --- succeeded. -test_pickle_of_unpickle_is_identity :: TestTree -test_pickle_of_unpickle_is_identity = - testCase "pickle composed with unpickle is the identity" $ do - let path = "test/xml/Odds_XML.xml" - (expected :: [Message], actual) <- pickle_unpickle "message" path - actual @?= expected + check "unpickling succeeds (league name)" + "test/xml/Odds_XML-league-name.xml" ] + where + check desc path = testCase desc $ do + actual <- unpickleable path pickle_message + let expected = True + actual @?= expected -test_unpickle_succeeds :: TestTree -test_unpickle_succeeds = - testCase "unpickling succeeds" $ do - let path = "test/xml/Odds_XML.xml" - actual <- unpickleable path pickle_message - let expected = True - actual @?= expected +-- | Make sure everything gets deleted when we delete the top-level +-- record. The casinos and teams should be left behind. +-- +test_on_delete_cascade :: TestTree +test_on_delete_cascade = testGroup "cascading delete tests" + [ check "deleting odds deletes its children" + "test/xml/Odds_XML.xml" + 13 -- 5 casinos, 8 teams + , + + check "deleting odds deletes its children (non-int team_id)" + "test/xml/Odds_XML-noninteger-team-id.xml" + 51 -- 5 casinos, 46 teams + , + + check "deleting odds deleted its children (positive(+) line)" + "test/xml/Odds_XML-positive-line.xml" + 17 -- 5 casinos, 12 teams + , + + check "deleting odds deleted its children (large file)" + "test/xml/Odds_XML-largefile.xml" + 189 -- 5 casinos, 184 teams + , + check "deleting odds deleted its children (league name)" + "test/xml/Odds_XML-league-name.xml" + 35 -- 5 casinos, 30 teams + ] + where + check desc path expected = testCase desc $ do + odds <- unsafe_unpickle path pickle_message + let a = undefined :: Team + let b = undefined :: Odds + let c = undefined :: OddsCasino + let d = undefined :: OddsGame + let e = undefined :: OddsGameLine + actual <- withSqliteConn ":memory:" $ runDbConn $ do + runMigration silentMigrationLogger $ do + migrate a + migrate b + migrate c + migrate d + migrate e + _ <- dbimport odds + deleteAll b + count_a <- countAll a + count_b <- countAll b + count_c <- countAll c + count_d <- countAll d + count_e <- countAll e + return $ sum [count_a, count_b, count_c, + count_d, count_e ] + actual @?= expected