X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=src%2FTSN%2FXML%2FJFile.hs;h=a0fa43297f3c376fec8fae6644417afd434bc687;hb=b3f2573796d736bf0aec8c7ae5ec45fa72eefe98;hp=2eed37fb7e2f8eb555ce7ed510c1e0df8d55159b;hpb=5a8806defa5e0fb3a99ae5316d6eeceb74dda3a3;p=dead%2Fhtsn-import.git diff --git a/src/TSN/XML/JFile.hs b/src/TSN/XML/JFile.hs index 2eed37f..a0fa432 100644 --- a/src/TSN/XML/JFile.hs +++ b/src/TSN/XML/JFile.hs @@ -12,48 +12,75 @@ -- a message contains a bunch of games. -- module TSN.XML.JFile ( - dtd ) + dtd, + pickle_message, + -- * Tests + jfile_tests, + -- * WARNING: these are private but exported to silence warnings + JFileConstructor(..), + JFileGameConstructor(..) ) where -- System imports +import Control.Monad ( forM_ ) +import Data.List ( intercalate ) +import Data.String.Utils ( split ) import Data.Time ( UTCTime(..) ) import Data.Tuple.Curry ( uncurryN ) -import Database.Groundhog ( migrate ) +import Database.Groundhog ( + countAll, + deleteAll, + migrate, + runMigration, + silentMigrationLogger ) import Database.Groundhog.Core ( DefaultKey ) +import Database.Groundhog.Generic ( runDbConn ) +import Database.Groundhog.Sqlite ( withSqliteConn ) import Database.Groundhog.TH ( groundhog, mkPersist ) +import Test.Tasty ( TestTree, testGroup ) +import Test.Tasty.HUnit ( (@?=), testCase ) import Text.XML.HXT.Core ( PU, xpTriple, xp6Tuple, - xp7Tuple, - xp8Tuple, - xp10Tuple, xp14Tuple, + xp19Tuple, xpAttr, xpElem, xpInt, xpList, xpOption, xpPair, + xpPrim, xpText, + xpText0, xpWrap ) -- Local imports import TSN.Codegen ( tsn_codegen_config ) import TSN.DbImport ( DbImport(..), ImportResult(..), run_dbmigrate ) -import TSN.Picklers ( xp_date_padded, xp_time, xp_time_stamp ) +import TSN.Picklers ( + xp_date, + xp_date_padded, + xp_datetime, + xp_time, + xp_time_dots, + xp_time_stamp ) import TSN.Team ( Team(..) ) import TSN.XmlImport ( XmlImport(..), - XmlImportFk(..) ) - + XmlImportFkTeams(..) ) import Xml ( + Child(..), FromXml(..), - FromXmlFk(..), - ToDb(..) ) + FromXmlFkTeams(..), + ToDb(..), + pickle_unpickle, + unpickleable, + unsafe_unpickle ) @@ -129,8 +156,8 @@ instance XmlImport Message data JFileGameAwayTeamXml = JFileGameAwayTeamXml { away_team_id :: String, - away_team_abbreviation :: String, - away_team_name :: String } + away_team_abbreviation :: Maybe String, + away_team_name :: Maybe String } deriving (Eq, Show) instance ToDb JFileGameAwayTeamXml where @@ -146,8 +173,8 @@ instance FromXml JFileGameAwayTeamXml where from_xml JFileGameAwayTeamXml{..} = Team { team_id = away_team_id, - team_abbreviation = away_team_abbreviation, - team_name = away_team_name } + abbreviation = away_team_abbreviation, + name = away_team_name } -- | Allow us to import JFileGameAwayTeamXml directly. instance XmlImport JFileGameAwayTeamXml @@ -159,8 +186,8 @@ instance XmlImport JFileGameAwayTeamXml data JFileGameHomeTeamXml = JFileGameHomeTeamXml { home_team_id :: String, - home_team_abbreviation :: String, - home_team_name :: String } + home_team_abbreviation :: Maybe String, + home_team_name :: Maybe String } deriving (Eq, Show) instance ToDb JFileGameHomeTeamXml where @@ -176,8 +203,8 @@ instance FromXml JFileGameHomeTeamXml where from_xml JFileGameHomeTeamXml{..} = Team { team_id = home_team_id, - team_abbreviation = home_team_abbreviation, - team_name = home_team_name } + abbreviation = home_team_abbreviation, + name = home_team_name } -- | Allow us to import JFileGameHomeTeamXml directly. instance XmlImport JFileGameHomeTeamXml @@ -192,22 +219,28 @@ instance XmlImport JFileGameHomeTeamXml -- measure, but in the conversion to the database type, we can drop -- all of the redundant information. -- +-- All of these are optional because TSN does actually leave the +-- whole thing empty from time to time. +-- +-- We stick \"info\" on the home/away team ids to avoid a name clash +-- with the game itself. +-- data JFileGameOddsInfo = JFileGameOddsInfo { - db_list_date :: UTCTime, - db_home_team_id :: String, -- redundant (Team) - db_away_team_id :: String, -- redundant (Team) - db_home_abbr :: String, -- redundant (Team) - db_away_abbr :: String, -- redundant (Team) - db_home_team_name :: String, -- redundant (Team) - db_away_team_name :: String, -- redundant (Team) - db_home_starter :: String, - db_away_starter :: String, - db_game_date :: UTCTime, -- redundant (JFileGame) - db_home_game_key :: Int, - db_away_game_key :: Int, - db_current_timestamp :: UTCTime, - db_live :: Bool, + db_list_date :: Maybe UTCTime, + db_info_home_team_id :: Maybe String, -- redundant (Team) + db_info_away_team_id :: Maybe String, -- redundant (Team) + db_home_abbr :: Maybe String, -- redundant (Team) + db_away_abbr :: Maybe String, -- redundant (Team) + db_home_team_name :: Maybe String, -- redundant (Team) + db_away_team_name :: Maybe String, -- redundant (Team) + db_home_starter :: Maybe String, + db_away_starter :: Maybe String, + db_game_date :: Maybe UTCTime, -- redundant (JFileGame) + db_home_game_key :: Maybe Int, + db_away_game_key :: Maybe Int, + db_current_timestamp :: Maybe UTCTime, + db_live :: Maybe Bool, db_notes :: String } deriving (Eq, Show) @@ -219,7 +252,7 @@ data JFileGameOddsInfo = data JFileGameStatus = JFileGameStatus { db_status_numeral :: Int, - db_status :: String } + db_status :: Maybe String } deriving (Eq, Show) @@ -232,10 +265,12 @@ data JFileGameStatus = data JFileGame = JFileGame { db_jfile_id :: DefaultKey JFile, + db_away_team_id :: DefaultKey Team, + db_home_team_id :: DefaultKey Team, db_game_id :: Int, db_schedule_id :: Int, db_odds_info :: JFileGameOddsInfo, - db_season_type :: String, + db_season_type :: Maybe String, db_game_time :: UTCTime, db_vleague :: Maybe String, db_hleague :: Maybe String, @@ -256,7 +291,7 @@ data JFileGameXml = xml_game_id :: Int, xml_schedule_id :: Int, xml_odds_info :: JFileGameOddsInfo, - xml_season_type :: String, + xml_season_type :: Maybe String, xml_game_date :: UTCTime, xml_game_time :: UTCTime, xml_vteam :: JFileGameAwayTeamXml, @@ -289,24 +324,29 @@ instance ToDb JFileGameXml where -- type Db JFileGameXml = JFileGame -instance FromXmlFk JFileGameXml where + +instance Child JFileGameXml where -- | Each 'JFileGameXml' is contained in (i.e. has a foreign key to) -- a 'JFile'. -- type Parent JFileGameXml = JFile + +instance FromXmlFkTeams JFileGameXml where -- | To convert an 'JFileGameXml' to an 'JFileGame', we add the - -- foreign key and drop the 'xml_vteam'/'xml_hteam'. We also mash + -- foreign keys for JFile and the home/away teams. We also mash -- the date/time together into one field. -- - from_xml_fk fk JFileGameXml{..} = + from_xml_fk_teams fk fk_away fk_home JFileGameXml{..} = JFileGame { db_jfile_id = fk, + db_away_team_id = fk_away, + db_home_team_id = fk_home, db_game_id = xml_game_id, db_schedule_id = xml_schedule_id, db_odds_info = xml_odds_info, db_season_type = xml_season_type, - db_game_time = xml_game_time, + db_game_time = make_game_time xml_game_date xml_game_time, db_vleague = xml_vleague, db_hleague = xml_hleague, db_vscore = xml_vscore, @@ -318,25 +358,13 @@ instance FromXmlFk JFileGameXml where -- date/time. Simply take the day part from one and the time -- from the other. -- - make_game_time d Nothing = d - make_game_time d (Just t) = UTCTime (utctDay d) (utctDayTime t) + make_game_time d t = UTCTime (utctDay d) (utctDayTime t) -- | This allows us to insert the XML representation -- 'JFileGameXml' directly. -- -instance XmlImportFk JFileGameXml - - --- * JFileGame_Team - --- | Database mapping between games and their home/away teams. --- -data JFileGame_Team = - JFileGame_Team { - jgt_jfile_games_id :: DefaultKey JFileGame, - jgt_away_team_id :: DefaultKey Team, - jgt_home_team_id :: DefaultKey Team } +instance XmlImportFkTeams JFileGameXml --- @@ -349,9 +377,22 @@ instance DbImport Message where migrate (undefined :: Team) migrate (undefined :: JFile) migrate (undefined :: JFileGame) - migrate (undefined :: JFileGame_Team) - dbimport m = return ImportSucceeded + dbimport m = do + -- Insert the top-level message + msg_id <- insert_xml m + + -- Now loop through the message's games + forM_ (xml_games $ xml_gamelist m) $ \game -> do + -- First we insert the home and away teams. + away_team_id <- insert_xml_or_select (xml_vteam game) + home_team_id <- insert_xml_or_select (xml_hteam game) + + -- First insert the game, keyed to the "jfile", + insert_xml_fk_teams_ msg_id away_team_id home_team_id game + + + return ImportSucceeded mkPersist tsn_codegen_config [groundhog| @@ -399,13 +440,19 @@ mkPersist tsn_codegen_config [groundhog| - name: db_jfile_id reference: onDelete: cascade + - name: db_away_team_id + reference: + onDelete: cascade + - name: db_home_team_id + reference: + onDelete: cascade - name: db_odds_info embeddedType: - {name: list_date, dbName: list_date} - {name: home_starter, dbName: home_starter} - {name: away_starter, dbName: away_starter} - {name: home_game_key, dbName: home_game_key} - - {name: away_game_key, dbName: home_game_key} + - {name: away_game_key, dbName: away_game_key} - {name: current_timestamp, dbName: current_timestamp} - {name: live, dbName: live} - {name: notes, dbName: notes} @@ -414,20 +461,6 @@ mkPersist tsn_codegen_config [groundhog| - {name: status_numeral, dbName: status_numeral} - {name: status, dbName: status} -- entity: JFileGame_Team - dbName: jfile_games__teams - constructors: - - name: JFileGame_Team - fields: - - name: jgt_jfile_games_id - reference: - onDelete: cascade - - name: jgt_away_team_id - reference: - onDelete: cascade - - name: jgt_home_team_id - reference: - onDelete: cascade |] @@ -475,7 +508,7 @@ pickle_game = xp14Tuple (xpElem "game_id" xpInt) (xpElem "schedule_id" xpInt) pickle_odds_info - (xpElem "seasontype" xpText) + (xpElem "seasontype" (xpOption xpText)) (xpElem "Game_Date" xp_date_padded) (xpElem "Game_Time" xp_time) pickle_away_team @@ -503,16 +536,75 @@ pickle_game = xml_time_remaining m, xml_game_status m) -pickle_odds_info = undefined - +pickle_odds_info :: PU JFileGameOddsInfo +pickle_odds_info = + xpElem "Odds_Info" $ + xpWrap (from_tuple, to_tuple) $ + xp19Tuple (xpElem "ListDate" (xpOption xp_date)) + (xpElem "HomeTeamID" (xpOption xpText)) + (xpElem "AwayTeamID" (xpOption xpText)) + (xpElem "HomeAbbr" (xpOption xpText)) + (xpElem "AwayAbbr" (xpOption xpText)) + (xpElem "HomeTeamName" (xpOption xpText)) + (xpElem "AwayTeamName" (xpOption xpText)) + (xpElem "HStarter" (xpOption xpText)) + (xpElem "AStarter" (xpOption xpText)) + (xpElem "GameDate" (xpOption xp_datetime)) + (xpElem "HGameKey" (xpOption xpInt)) + (xpElem "AGameKey" (xpOption xpInt)) + (xpElem "CurrentTimeStamp" (xpOption xp_time_dots)) + (xpElem "Live" (xpOption xpPrim)) + (xpElem "Notes1" xpText0) + (xpElem "Notes2" xpText0) + (xpElem "Notes3" xpText0) + (xpElem "Notes4" xpText0) + (xpElem "Notes5" xpText0) + where + from_tuple (x1,x2,x3,x4,x5,x6,x7,x8,x9,x10,x11,x12,x13,x14,n1,n2,n3,n4,n5) = + JFileGameOddsInfo x1 x2 x3 x4 x5 x6 x7 x8 x9 x10 x11 x12 x13 x14 notes + where + notes = intercalate "\n" [n1,n2,n3,n4,n5] + + to_tuple o = (db_list_date o, + db_info_home_team_id o, + db_info_away_team_id o, + db_home_abbr o, + db_away_abbr o, + db_home_team_name o, + db_away_team_name o, + db_home_starter o, + db_away_starter o, + db_game_date o, + db_home_game_key o, + db_away_game_key o, + db_current_timestamp o, + db_live o, + n1,n2,n3,n4,n5) + where + note_lines = split "\n" (db_notes o) + n1 = case note_lines of + (notes1:_) -> notes1 + _ -> "" + n2 = case note_lines of + (_:notes2:_) -> notes2 + _ -> "" + n3 = case note_lines of + (_:_:notes3:_) -> notes3 + _ -> "" + n4 = case note_lines of + (_:_:_:notes4:_) -> notes4 + _ -> "" + n5 = case note_lines of + (_:_:_:_:notes5:_) -> notes5 + _ -> "" pickle_home_team :: PU JFileGameHomeTeamXml pickle_home_team = xpElem "hteam" $ xpWrap (from_tuple, to_tuple) $ xpTriple (xpAttr "teamid" xpText) -- Yeah, they're text. - (xpAttr "abbr" xpText) - xpText + (xpAttr "abbr" (xpOption xpText)) -- Some are blank + (xpOption xpText) -- Yup, some are nameless where from_tuple = uncurryN JFileGameHomeTeamXml to_tuple t = (home_team_id t, @@ -525,8 +617,8 @@ pickle_away_team = xpElem "vteam" $ xpWrap (from_tuple, to_tuple) $ xpTriple (xpAttr "teamid" xpText) -- Yeah, they're text. - (xpAttr "abbr" xpText) - xpText + (xpAttr "abbr" (xpOption xpText)) -- Some are blank + (xpOption xpText) -- Yup, some are nameless where from_tuple = uncurryN JFileGameAwayTeamXml to_tuple t = (away_team_id t, @@ -539,8 +631,89 @@ pickle_status = xpElem "status" $ xpWrap (from_tuple, to_tuple) $ xpPair (xpAttr "numeral" xpInt) - xpText + (xpOption xpText) where from_tuple = uncurry JFileGameStatus to_tuple s = (db_status_numeral s, db_status s) + + + +-- +-- Tasty Tests +-- + +-- | A list of all tests for this module. +-- +jfile_tests :: TestTree +jfile_tests = + testGroup + "JFile tests" + [ test_on_delete_cascade, + test_pickle_of_unpickle_is_identity, + test_unpickle_succeeds ] + + +-- | If we unpickle something and then pickle it, we should wind up +-- with the same thing we started with. WARNING: success of this +-- test does not mean that unpickling succeeded. +-- +test_pickle_of_unpickle_is_identity :: TestTree +test_pickle_of_unpickle_is_identity = testGroup "pickle-unpickle tests" + [ check "pickle composed with unpickle is the identity" + "test/xml/jfilexml.xml", + check "pickle composed with unpickle is the identity (missing fields)" + "test/xml/jfilexml-missing-fields.xml" ] + where + check desc path = testCase desc $ do + (expected, actual) <- pickle_unpickle pickle_message path + actual @?= expected + + + +-- | Make sure we can actually unpickle these things. +-- +test_unpickle_succeeds :: TestTree +test_unpickle_succeeds = testGroup "unpickle tests" + [ check "unpickling succeeds" "test/xml/jfilexml.xml", + check "unpickling succeeds (missing fields)" + "test/xml/jfilexml-missing-fields.xml" ] + where + check desc path = testCase desc $ do + actual <- unpickleable path pickle_message + + let expected = True + actual @?= expected + + + +-- | Make sure everything gets deleted when we delete the top-level +-- record. +-- +test_on_delete_cascade :: TestTree +test_on_delete_cascade = testGroup "cascading delete tests" + [ check "deleting auto_racing_results deletes its children" + "test/xml/jfilexml.xml" + 20, + check "deleting auto_racing_results deletes its children (missing fields)" + "test/xml/jfilexml-missing-fields.xml" + 44 ] + where + check desc path expected = testCase desc $ do + results <- unsafe_unpickle path pickle_message + let a = undefined :: Team + let b = undefined :: JFile + let c = undefined :: JFileGame + + actual <- withSqliteConn ":memory:" $ runDbConn $ do + runMigration silentMigrationLogger $ do + migrate a + migrate b + migrate c + _ <- dbimport results + deleteAll b + count_a <- countAll a + count_b <- countAll b + count_c <- countAll c + return $ sum [count_a, count_b, count_c] + actual @?= expected