X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=run-tests.sh;h=78739322b5a5c6ad9cbec7879ae9e68f5cb5cb69;hb=9147fa98f5786713e7c625cfccb76c86bfda172e;hp=c1721287c339431de6e9e4d8f0afad93b246ceb3;hpb=b8cecada12c850ce02f823e1db3643d31c99c5b8;p=apply-default-acl.git

diff --git a/run-tests.sh b/run-tests.sh
index c172128..7873932 100755
--- a/run-tests.sh
+++ b/run-tests.sh
@@ -718,15 +718,9 @@ mkdir "${TESTDIR}/foo"
 LINK2TARGET="${TESTDIR}/foo/bar-sym"
 ln -s "../bar" "${LINK2TARGET}"
 setfacl --default --modify user:${USERS[0]}:rwx "${TESTDIR}/foo"
+EXPECTED=$(getfacl --omit-header "${TARGET}")
 "${BIN}" --recursive "${TESTDIR}/foo"
 ACTUAL=$( getfacl --omit-header "${TARGET}" )
-EXPECTED=$(cat <<EOF
-user::rw-
-group::r--
-other::r--
-
-EOF
-)
 compare
 
 
@@ -783,15 +777,9 @@ mkdir -p $(dirname "${TARGET}")
 touch "${TARGET}"
 ln -s foo "${LINK2FOO}"
 setfacl --default --modify user:${USERS[0]}:rw $(dirname "${TARGET}")
+EXPECTED=$(getfacl --omit-header "${TARGET}")
 "${BIN}" "${LINK2FOO}/bar/baz"
 ACTUAL=$( getfacl --omit-header "${TARGET}" )
-EXPECTED=$(cat <<EOF
-user::rw-
-group::r--
-other::r--
-
-EOF
-)
 compare
 
 
@@ -818,8 +806,7 @@ EXPECTED="1"
 compare
 
 
-# The previous test should "succeed" if we use --recursive. This is
-# buggy, but it's documented.
+# The previous test should fail, even if we use --recursive.
 TESTNUM=35
 TARGET="${TESTDIR}/bar"
 touch "${TESTDIR}/foo"
@@ -827,7 +814,7 @@ ln -s foo "${TARGET}"
 setfacl --default --modify user:${USERS[0]}:rw "${TESTDIR}"
 "${BIN}" --recursive "${TARGET}"
 ACTUAL="$?"
-EXPECTED="0"
+EXPECTED="1"
 compare
 
 
@@ -854,15 +841,14 @@ EXPECTED="1"
 compare
 
 
-# And test the buggy behavior again; the previous test should return
-# success (ignoring the failure) when --recursive is used.
+# The failure should prevail when using --recursive, too.
 TESTNUM=38
 mkdir "${TESTDIR}/foo"
 ln -s foo "${TESTDIR}/bar"
 mkdir "${TESTDIR}/baz"
 "${BIN}" --recursive "${TESTDIR}"
 ACTUAL="$?"
-EXPECTED="0"
+EXPECTED="1"
 compare
 
 
@@ -913,3 +899,17 @@ EXPECTED=$( getfacl --omit-header "${TARGET}-direct" )
 "${BIN}" --recursive "${TESTDIR}"
 ACTUAL=$( getfacl --omit-header "${TARGET}" )
 compare
+
+
+# Ensure that we don't get "error" results for symlinks encountered
+# during a recursive traversal.
+TESTNUM=43
+TARGET="${TESTDIR}"
+mkdir "${TARGET}/foo"
+mkdir "${TARGET}/bar"
+ln -s "../foo" "${TARGET}/bar/baz"
+setfacl --default --modify user:${USERS[0]}:rw "${TARGET}"
+EXPECTED="1"
+"${BIN}" --recursive "${TARGET}"
+ACTUAL=$?
+compare