X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=panel-plugin%2Fxfce4-hdaps.c;h=732224c4e5dfe7e65ead2845e38eab56b8c11c82;hb=f7f9ab86d0ca87edbd50125198093fc5f44127ab;hp=8dbc74d1765dcbd997f7f999f7736faa962ba283;hpb=a883b9664639b2e80dba9b4e616afba8f3d2163b;p=xfce4-hdaps.git diff --git a/panel-plugin/xfce4-hdaps.c b/panel-plugin/xfce4-hdaps.c index 8dbc74d..732224c 100644 --- a/panel-plugin/xfce4-hdaps.c +++ b/panel-plugin/xfce4-hdaps.c @@ -22,6 +22,7 @@ #include #endif +#include "hdaps.h" #include "xfce4-hdaps.h" #include "xfce4-hdaps-dialogs.h" @@ -39,7 +40,7 @@ static void hdaps_construct(XfcePanelPlugin *plugin); /* Register the plugin with the panel. */ -XFCE_PANEL_PLUGIN_REGISTER_EXTERNAL(hdaps_construct); +XFCE_PANEL_PLUGIN_REGISTER(hdaps_construct); void hdaps_save(XfcePanelPlugin *plugin, HdapsPlugin *hdaps) { @@ -144,8 +145,26 @@ void hdaps_set_tooltip(HdapsPlugin *hdaps, int status) { static void hdaps_set_defaults(HdapsPlugin *hdaps) { DBG("Configuring all settings to defaults."); - hdaps->device_name = g_strdup(DEFAULT_DEVICE_NAME); + + /* Here we determine the default device name. There are essentially + two "defaults," one soft, and the other hard. The soft default + is to choose the first supported HDAPS device in the system. This + would benefit users who, for example, only have one supported drive + named hda. If we can't find any supported HDAPS devices, we use the + hard default of DEFAULT_DEVICE_NAME. */ + char hdaps_devices[MAX_HDAPS_DEVICES][FILENAME_MAX]; + int found_devices = get_hdaps_device_list(hdaps_devices); + + if (found_devices > 0) { + hdaps->device_name = g_strdup(hdaps_devices[0]); + } + else { + hdaps->device_name = g_strdup(DEFAULT_DEVICE_NAME); + } + snprintf(hdaps->sysfs_file, FILENAME_MAX, UNLOAD_HEADS_FMT, hdaps->device_name); + + /* The other default is easier. */ hdaps->poll_frequency = DEFAULT_POLL_FREQUENCY; } @@ -230,6 +249,11 @@ static HdapsPlugin *hdaps_new(XfcePanelPlugin *plugin) { hdaps->eventbox = gtk_event_box_new(); gtk_widget_show(hdaps->eventbox); + /* Make the event box transparent. In newer versions of xfce4-panel + users can make the panel transparent, so we don't want to stick a + big opaque box on it. */ + gtk_event_box_set_visible_window(hdaps->eventbox, FALSE); + /* Set up the hvbox for the widget, which supports both horizontal and vertical (hv) orientations. */ hdaps->hvbox = xfce_hvbox_new(orientation, FALSE, 2);