X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=mjo%2Forthogonal_polynomials.py;h=15c695611fb3e287c357075f45e55eeddf550f7f;hb=HEAD;hp=edea32bf7a0788b7574f3dd9c7f7298e395fff1b;hpb=99a1300976825fff1379f39c7acc0ad74586a078;p=sage.d.git

diff --git a/mjo/orthogonal_polynomials.py b/mjo/orthogonal_polynomials.py
index edea32b..15c6956 100644
--- a/mjo/orthogonal_polynomials.py
+++ b/mjo/orthogonal_polynomials.py
@@ -1,8 +1,7 @@
 from sage.all import *
-from sage.symbolic.expression import is_Expression
 
 def legendre_p(n, x, a = -1, b = 1):
-    """
+    r"""
     Returns the ``n``th Legendre polynomial of the first kind over the
     interval [a, b] with respect to ``x``.
 
@@ -29,12 +28,68 @@ def legendre_p(n, x, a = -1, b = 1):
     returned. Otherwise, the value of the ``n``th polynomial at ``x``
     will be returned.
 
+    SETUP::
+
+        sage: from mjo.orthogonal_polynomials import legendre_p
+
+    EXAMPLES:
+
+    Create the standard Legendre polynomials in `x`::
+
+        sage: legendre_p(0,x)
+        1
+        sage: legendre_p(1,x)
+        x
+
+    Reuse the variable from a polynomial ring::
+        sage: P.<t> = QQ[]
+        sage: legendre_p(2,t)
+        3/2*t^2 - 1/2
+
+    If ``x`` is a real number, the result should be as well::
+
+        sage: legendre_p(3, 1.1)
+        1.67750000000000
+
+    Similarly for complex numbers::
+
+        sage: legendre_p(3, 1 + I)
+        7/2*I - 13/2
+
+    Even matrices work::
+
+        sage: legendre_p(3, MatrixSpace(ZZ, 2)([1, 2, -4, 7]))
+        [-179  242]
+        [-484  547]
+
+    And finite field elements::
+
+        sage: legendre_p(3, GF(11)(5))
+        8
+
+    Solve a simple least squares problem over `[-\pi, \pi]`::
+
+        sage: a = -pi
+        sage: b = pi
+        sage: def inner_product(v1, v2):
+        ....:     return integrate(v1*v2, x, a, b)
+        sage: def norm(v):
+        ....:     return sqrt(inner_product(v,v))
+        sage: def project(basis, v):
+        ....:     return sum( inner_product(v, b)*b/norm(b)**2
+        ....:                 for b in basis)
+        sage: f = sin(x)
+        sage: legendre_basis = [ legendre_p(k, x, a, b) for k in range(4) ]
+        sage: proj = project(legendre_basis, f)
+        sage: proj.simplify_trig()
+        5/2*(7*(pi^2 - 15)*x^3 - 3*(pi^4 - 21*pi^2)*x)/pi^6
+
     TESTS:
 
     We should agree with Maxima for all `n`::
 
         sage: eq = lambda k: bool(legendre_p(k,x) == legendre_P(k,x))
-        sage: all([eq(k) for k in range(0,20) ]) # long time
+        sage: all( eq(k) for k in range(20) ) # long time
         True
 
     We can evaluate the result of the zeroth polynomial::
@@ -55,10 +110,11 @@ def legendre_p(n, x, a = -1, b = 1):
         1
 
     Two different polynomials should be orthogonal with respect to the
-    inner product over [a,b]::
+    inner product over `[a,b]`. Note that this test can fail if QQ is
+    replaced with RR, since integrate() can return NaN::
 
-        sage: a = RR.random_element()
-        sage: b = RR.random_element()
+        sage: a = QQ.random_element()
+        sage: b = QQ.random_element()
         sage: j = ZZ.random_element(20)
         sage: k = j + 1
         sage: Pj = legendre_p(j, x, a, b)
@@ -81,6 +137,13 @@ def legendre_p(n, x, a = -1, b = 1):
         sage: bool(legendre_p(3, x, 0, 1) == p3)
         True
 
+    The zeroth polynomial is an element of the ring that we're working
+    in::
+
+        sage: legendre_p(0, MatrixSpace(ZZ, 2)([1, 2, -4, 7]))
+        [1 0]
+        [0 1]
+
     """
     if not n in ZZ:
         raise TypeError('n must be a natural number')
@@ -91,15 +154,35 @@ def legendre_p(n, x, a = -1, b = 1):
     if not (a in RR and b in RR):
         raise TypeError('both `a` and `b` must be real numbers')
 
-    a = RR(a)
-    b = RR(b)
-    n = ZZ(n) # Ensure that 1/(2**n) is not integer division.
-    dn = 1/(2**n)
+    if n == 0:
+        # Easy base case, save time. Attempt to return a value in the
+        # same field/ring as `x`.
+        return x.parent()(1)
+
+    # Even though we know a,b are real we use a different ring. We
+    # prefer ZZ so that we can support division of finite field
+    # elements by (a-b). Eventually this should be supported for QQ as
+    # well, although it does not work at the moment. The preference of
+    # SR over RR is to return something attractive when e.g. a=pi.
+    if a in ZZ:
+        a = ZZ(a)
+    else:
+        a = SR(a)
+
+    if b in ZZ:
+        b = ZZ(b)
+    else:
+        b = SR(b)
+
+    # Ensure that (2**n) is an element of ZZ. This is used later --
+    # we can divide finite field elements by integers but we can't
+    # multiply them by rationals at the moment.
+    n = ZZ(n)
 
     def phi(t):
-        # This is an affine map from [a,b] into [-1,1] and so preserves
-        # orthogonality.
-        return (2 / (b-a))*t + 1 - (2*b)/(b-a)
+        # This is an affine map from [a,b] into [-1,1] and so
+        # preserves orthogonality.
+        return (a + b - 2*t)/(a - b)
 
     def c(m):
         return binomial(n,m)*binomial(n, n-m)
@@ -109,11 +192,7 @@ def legendre_p(n, x, a = -1, b = 1):
         return ( ((phi(x) - 1)**(n-m)) * (phi(x) + 1)**m )
 
     # From Abramowitz & Stegun, (22.3.2) with alpha = beta = 0.
-    P = dn * sum([ c(m)*g(m) for m in range(0,n+1) ])
-
-    # If `x` is a symbolic expression, we want to return a symbolic
-    # expression (even if that expression is e.g. `1`).
-    if is_Expression(x):
-        P = SR(P)
+    # Also massaged to support finite field elements.
+    P = sum( c(m)*g(m) for m in range(n+1) )/(2**n)
 
     return P