X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=mjo%2Feja%2Feuclidean_jordan_algebra.py;h=ce6f6e55e18b28aabea82c9118758c1dab061c28;hb=3cee3d24af1c7606b4c2f30c16a7f6f3e51fd1bd;hp=52e1383383cac83a8fa91e3f63c39c8795d8b533;hpb=bb8418eb800cae28a844f40b5f04480d64b2250b;p=sage.d.git

diff --git a/mjo/eja/euclidean_jordan_algebra.py b/mjo/eja/euclidean_jordan_algebra.py
index 52e1383..ce6f6e5 100644
--- a/mjo/eja/euclidean_jordan_algebra.py
+++ b/mjo/eja/euclidean_jordan_algebra.py
@@ -57,6 +57,18 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
                 return A.element_class(A, self.vector()*(self.matrix()**(n-1)))
 
 
+        def span_of_powers(self):
+            """
+            Return the vector space spanned by successive powers of
+            this element.
+            """
+            # The dimension of the subalgebra can't be greater than
+            # the big algebra, so just put everything into a list
+            # and let span() get rid of the excess.
+            V = self.vector().parent()
+            return V.span( (self**d).vector() for d in xrange(V.dimension()) )
+
+
         def degree(self):
             """
             Compute the degree of this element the straightforward way
@@ -74,13 +86,8 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
                 2
 
             """
-            d = 0
-            V = self.vector().parent()
-            vectors = [(self**d).vector()]
-            while V.span(vectors).dimension() > d:
-                d += 1
-                vectors.append((self**d).vector())
-            return d
+            return self.span_of_powers().dimension()
+
 
         def minimal_polynomial(self):
             return self.matrix().minimal_polynomial()
@@ -122,9 +129,6 @@ def eja_rn(dimension, field=QQ):
     Qs = [ matrix(field, dimension, dimension, lambda k,j: 1*(k == j == i))
            for i in xrange(dimension) ]
 
-    # Assuming associativity is wrong here, but it works to
-    # temporarily trick the Jordan algebra constructor into using the
-    # multiplication table.
     return FiniteDimensionalEuclideanJordanAlgebra(field,Qs)