X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=mjo%2Feja%2Feuclidean_jordan_algebra.py;h=8f623b4491ca1439d0905b5b91bcfe25cf754ecb;hb=0dc6a110a16f63240e7817fc7529996e885973c8;hp=849243c81d56a2781a8b0abe5c9e6ae795f264eb;hpb=6d4b7ff3cf1b285953f0f3d3c5797067c0f52587;p=sage.d.git

diff --git a/mjo/eja/euclidean_jordan_algebra.py b/mjo/eja/euclidean_jordan_algebra.py
index 849243c..8f623b4 100644
--- a/mjo/eja/euclidean_jordan_algebra.py
+++ b/mjo/eja/euclidean_jordan_algebra.py
@@ -85,6 +85,10 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
         also the left multiplication matrix and must be symmetric::
 
             sage: set_random_seed()
+            sage: n = ZZ.random_element(1,10).abs()
+            sage: J = eja_rn(5)
+            sage: J.random_element().matrix().is_symmetric()
+            True
             sage: J = eja_ln(5)
             sage: J.random_element().matrix().is_symmetric()
             True
@@ -151,7 +155,22 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
 
         def subalgebra_generated_by(self):
             """
-            Return the subalgebra of the parent EJA generated by this element.
+            Return the associative subalgebra of the parent EJA generated
+            by this element.
+
+            TESTS::
+
+                sage: set_random_seed()
+                sage: n = ZZ.random_element(1,10).abs()
+                sage: J = eja_rn(n)
+                sage: x = J.random_element()
+                sage: x.subalgebra_generated_by().is_associative()
+                True
+                sage: J = eja_ln(n)
+                sage: x = J.random_element()
+                sage: x.subalgebra_generated_by().is_associative()
+                True
+
             """
             # First get the subspace spanned by the powers of myself...
             V = self.span_of_powers()
@@ -178,7 +197,9 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
                 b_right_matrix = matrix(F, b_right_rows)
                 mats.append(b_right_matrix)
 
-            return FiniteDimensionalEuclideanJordanAlgebra(F, mats)
+            # It's an algebra of polynomials in one element, and EJAs
+            # are power-associative.
+            return FiniteDimensionalEuclideanJordanAlgebra(F, mats, assume_associative=True)
 
 
         def minimal_polynomial(self):
@@ -221,13 +242,25 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
                 True
 
             """
-            V = self.span_of_powers()
-            assoc_subalg = self.subalgebra_generated_by()
-            # Mis-design warning: the basis used for span_of_powers()
-            # and subalgebra_generated_by() must be the same, and in
-            # the same order!
-            subalg_self = assoc_subalg(V.coordinates(self.vector()))
-            return subalg_self.matrix().minimal_polynomial()
+            # The element we're going to call "minimal_polynomial()" on.
+            # Either myself, interpreted as an element of a finite-
+            # dimensional algebra, or an element of an associative
+            # subalgebra.
+            elt = None
+
+            if self.parent().is_associative():
+                elt = FiniteDimensionalAlgebraElement(self.parent(), self)
+            else:
+                V = self.span_of_powers()
+                assoc_subalg = self.subalgebra_generated_by()
+                # Mis-design warning: the basis used for span_of_powers()
+                # and subalgebra_generated_by() must be the same, and in
+                # the same order!
+                elt = assoc_subalg(V.coordinates(self.vector()))
+
+            # Recursive call, but should work since elt lives in an
+            # associative algebra.
+            return elt.minimal_polynomial()
 
 
         def characteristic_polynomial(self):
@@ -317,4 +350,8 @@ def eja_ln(dimension, field=QQ):
         Qi[0,0] = Qi[0,0] * ~field(2)
         Qs.append(Qi)
 
-    return FiniteDimensionalEuclideanJordanAlgebra(field,Qs,rank=2)
+    # The rank of the spin factor algebra is two, UNLESS we're in a
+    # one-dimensional ambient space (the rank is bounded by the
+    # ambient dimension).
+    rank = min(dimension,2)
+    return FiniteDimensionalEuclideanJordanAlgebra(field,Qs,rank=rank)