X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=mjo%2Feja%2FTODO;h=f4b9515c4ed643bd1f9a13c6fc0d6cefa3d32879;hb=HEAD;hp=dd671c5fd7ab847a4c635748923bf0cba12a63ad;hpb=ba5ac5253ad25bf78e7655699d6d05630d91c1a5;p=sage.d.git diff --git a/mjo/eja/TODO b/mjo/eja/TODO index dd671c5..b0d5378 100644 --- a/mjo/eja/TODO +++ b/mjo/eja/TODO @@ -1,44 +1,20 @@ -Trace inner product tests: +1. Add references and start citing them. - TESTS: +2. Profile (and fix?) any remaining slow operations. - The trace inner product is commutative:: +3. When we take a Cartesian product involving a trivial algebra, we + could easily cache the identity and charpoly coefficients using + the nontrivial factor. On the other hand, it's nice that we can + test out some alternate code paths... - sage: set_random_seed() - sage: J = random_eja() - sage: x = J.random_element(); y = J.random_element() - sage: x.trace_inner_product(y) == y.trace_inner_product(x) - True +4. Add dimension bounds on any tests over AA that compute element + subalgebras. - The trace inner product is bilinear:: +5. The rational_algebra() stuff doesn't really belong in classes that + don't derive from RationalBasisEJA or its as-yet-nonexistent + element class. - sage: set_random_seed() - sage: J = random_eja() - sage: x = J.random_element() - sage: y = J.random_element() - sage: z = J.random_element() - sage: a = QQ.random_element(); - sage: actual = (a*(x+z)).trace_inner_product(y) - sage: expected = a*x.trace_inner_product(y) + a*z.trace_inner_product(y) - sage: actual == expected - True - sage: actual = x.trace_inner_product(a*(y+z)) - sage: expected = a*x.trace_inner_product(y) + a*x.trace_inner_product(z) - sage: actual == expected - True - - The trace inner product is associative:: - - sage: pass - - The trace inner product satisfies the compatibility - condition in the definition of a Euclidean Jordan algebra: - - sage: set_random_seed() - sage: J = random_eja() - sage: x = J.random_element() - sage: y = J.random_element() - sage: z = J.random_element() - sage: (x*y).trace_inner_product(z) == y.trace_inner_product(x*z) - True - \ No newline at end of file +6. Add special det/trace method overrides for the algebras where we + know them? The only reason this might be tricky is because the + obvious solution is to subclass EJAElement, but then we might + collide with e.g. the Cartesian product element subclass.