X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=mjo%2Feja%2FTODO;h=dc987dfe1b6dd3158b3caeb39ec777b7f8f4c7e9;hb=95bac72b9d6731b0cdaafc89a839972d8544512f;hp=529f70fd633bf36275c63282a05614f1109a7df0;hpb=d9b0659df5d8ad61f457674e009180618dffef67;p=sage.d.git diff --git a/mjo/eja/TODO b/mjo/eja/TODO index 529f70f..dc987df 100644 --- a/mjo/eja/TODO +++ b/mjo/eja/TODO @@ -2,24 +2,14 @@ 2. Profile (and fix?) any remaining slow operations. -3. Every once in a long while, the test - - sage: set_random_seed() - sage: x = random_eja().random_element() - sage: x.is_invertible() == (x.det() != 0) - - in eja_element.py returns False. Example: - - sage: J1 = ComplexHermitianEJA(2) - sage: J2 = TrivialEJA() - sage: J = cartesian_product([J1,J2]) - sage: x = J.from_vector(vector(QQ, [-1, -1/2, -1/2, -1/2])) - sage: x.is_invertible() - True - sage: x.det() - 0 - -4. When we take a Cartesian product involving a trivial algebra, we +3. When we take a Cartesian product involving a trivial algebra, we could easily cache the identity and charpoly coefficients using the nontrivial factor. On the other hand, it's nice that we can test out some alternate code paths... + +4. Add dimension bounds on any tests over AA that compute element + subalgebras. + +5. The rational_algebra() stuff doesn't really belong in classes that + don't dervice from RationalBasisEJA or its as-yet-nonexistent + element class.