X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=mjo%2Fcone%2Fdoubly_nonnegative.py;h=e8cacda5cd492100096eff2cf557c8992a34d9b3;hb=1bbade9f41ffbfe366b15d0db657f666bc1f025d;hp=9dcae61856e6e9d5bda7f689cadf905de27290ac;hpb=fe9ce8d587b741f3094af4a6c98c7b41811318af;p=sage.d.git diff --git a/mjo/cone/doubly_nonnegative.py b/mjo/cone/doubly_nonnegative.py index 9dcae61..e8cacda 100644 --- a/mjo/cone/doubly_nonnegative.py +++ b/mjo/cone/doubly_nonnegative.py @@ -16,7 +16,7 @@ from sage.all import * from mjo.cone.symmetric_psd import (factor_psd, is_symmetric_psd, random_symmetric_psd) -from mjo.matrix_vector import isomorphism +from mjo.basis_repr import basis_repr def is_doubly_nonnegative(A): @@ -383,7 +383,7 @@ def is_extreme_doubly_nonnegative(A): # can't compute the dimension of a set of matrices anyway, so we # convert them all to vectors and just ask for the dimension of the # resulting vector space. - (phi, phi_inverse) = isomorphism(A.matrix_space()) + (phi, phi_inverse) = basis_repr(A.matrix_space()) vectors = map(phi,spanning_set) V = span(vectors, A.base_ring()) @@ -530,7 +530,7 @@ def random_extreme_doubly_nonnegative(V, accept_zero=True, rank=None): """ - if not is_admissible_extreme_rank(rank, V.dimension()): + if rank is not None and not is_admissible_extreme_rank(rank, V.dimension()): msg = 'Rank %d not possible in dimension %d.' raise ValueError(msg % (rank, V.dimension()))