X-Git-Url: http://gitweb.michael.orlitzky.com/?a=blobdiff_plain;f=TODO;h=48d4bd36380ce361c3d35d7aff6be8689781ee18;hb=5bcb67b592ff12a57f7cb9803305c380342ef71c;hp=ae41d67ffcb3519f45741c157660aec9bbd6bccc;hpb=6f90e0a65e6775b153e6abd320232421dd90ba6f;p=dunshire.git diff --git a/TODO b/TODO index ae41d67..48d4bd3 100644 --- a/TODO +++ b/TODO @@ -78,6 +78,7 @@ [0.0191076] [0.0000000] + 6. Fix the math domain errors that sometimes pop up: ERROR: test_scaling_icecream (test.symmetric_linear_game_test @@ -101,3 +102,98 @@ File "/usr/lib64/python3.4/site-packages/cvxopt/misc.py", line 856, in jnrm2 return math.sqrt(x[offset] - a) * math.sqrt(x[offset] + a) ValueError: math domain error + + +7. Figure out why this happens, too: + + FAIL: test_scaling_icecream (test.symmetric_linear_game_test + .SymmetricLinearGameTest) + ---------------------------------------------------------------------- + Traceback (most recent call last): + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 336, in test_scaling_icecream + self.assert_scaling_works(L, K, e1, e2) + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 318, in assert_scaling_works + self.assert_within_tol(alpha*value1, value2) + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 254, in assert_within_tol + self.assertTrue(abs(first - second) < options.ABS_TOL) + AssertionError: False is not true + + + FAIL: test_translation_orthant (test.symmetric_linear_game_test + SymmetricLinearGameTest) + ---------------------------------------------------------------------- + Traceback (most recent call last): + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 374, in test_translation_orthant + self.assert_translation_works(L, K, e1, e2) + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 366, in assert_translation_works + self.assert_within_tol(value2, inner_product(M*x_bar, y_bar)) + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 254, in assert_within_tol + self.assertTrue(abs(first - second) < options.ABS_TOL) + AssertionError: False is not true + + +8. Fix floating point comparisons in the doctest output. + + +12. Investigate this test failure too. It looks like it was really + close to being solved, but we would have needed a fudge factor + of three instead of two. + + ERROR: test_positive_operator_value (test.symmetric_linear_game_test + .SymmetricLinearGameTest) + ---------------------------------------------------------------------- + Traceback (most recent call last): + File "/home/mjo/src/dunshire/test/symmetric_linear_game_test.py", + line 550, in test_positive_operator_value + self.assertTrue(G.solution().game_value() >= -options.ABS_TOL) + File "/home/mjo/src/dunshire/dunshire/games.py", line 515, in solution + raise GameUnsolvableException(self, soln_dict) + dunshire.errors.GameUnsolvableException: Solution failed with result + "unknown." + The linear game (L, K, e1, e2) where + L = [8.0814704 3.5584693] + [3.9986814 9.3381562], + K = Nonnegative orthant in the real 2-space, + e1 = [1.3288182] + [0.7458942], + e2 = [0.6814326] + [3.3799082], + Condition((L, K, e1, e2)) = 41.093597. + CVXOPT returned: + dual infeasibility: 2.368640021750079e-06 + dual objective: -7.867137172157051 + dual slack: 1.1314089173606103e-07 + gap: 1.1404410161224882e-06 + iterations: 6 + primal infeasibility: 1.379959981010593e-07 + primal objective: -7.867137449574777 + primal slack: 1.0550559882036034e-08 + relative gap: 1.4496264027827932e-07 + residual as dual infeasibility certificate: 0.12711103707156543 + residual as primal infeasibility certificate: None + s: + [1.4674968] + [0.0000000] + [1.4055364] + [0.0000000] + status: unknown + x: + [ 7.8671374] + [ 1.4674968] + [-0.0000000] + y: + [7.8671372] + z: + [ 0.0000001] + [14.0707905] + [ 0.0000002] + [ 1.3406728] + + +13. Add game payoff(x,y) method to check solutions.