]> gitweb.michael.orlitzky.com - libsvgtiny.git/blobdiff - src/svgtiny.c
cope with lack of root svg element
[libsvgtiny.git] / src / svgtiny.c
index abc34ab3dee0a22b520c1e7997f72aebcffe793a..bd9aeaa89486ddc873249744feed390d78042801 100644 (file)
@@ -3,9 +3,9 @@
  * Licensed under the MIT License,
  *                http://opensource.org/licenses/mit-license.php
  * Copyright 2008-2009 James Bursa <james@semichrome.net>
+ * Copyright 2012 Daniel Silverstone <dsilvers@netsurf-browser.org>
  */
 
-#define _GNU_SOURCE  /* for strndup */
 #include <assert.h>
 #include <math.h>
 #include <setjmp.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <libxml/parser.h>
-#include <libxml/debugXML.h>
+
+#include <dom/dom.h>
+#include <dom/bindings/xml/xmlparser.h>
+
 #include "svgtiny.h"
 #include "svgtiny_internal.h"
 
 
 #define KAPPA          0.5522847498
 
-static svgtiny_code svgtiny_parse_svg(xmlNode *svg,
+static svgtiny_code svgtiny_parse_svg(dom_element *svg,
                struct svgtiny_parse_state state);
-static svgtiny_code svgtiny_parse_path(xmlNode *path,
+static svgtiny_code svgtiny_parse_path(dom_element *path,
                struct svgtiny_parse_state state);
-static svgtiny_code svgtiny_parse_rect(xmlNode *rect,
+static svgtiny_code svgtiny_parse_rect(dom_element *rect,
                struct svgtiny_parse_state state);
-static svgtiny_code svgtiny_parse_circle(xmlNode *circle,
+static svgtiny_code svgtiny_parse_circle(dom_element *circle,
                struct svgtiny_parse_state state);
-static svgtiny_code svgtiny_parse_ellipse(xmlNode *ellipse,
+static svgtiny_code svgtiny_parse_ellipse(dom_element *ellipse,
                struct svgtiny_parse_state state);
-static svgtiny_code svgtiny_parse_line(xmlNode *line,
+static svgtiny_code svgtiny_parse_line(dom_element *line,
                struct svgtiny_parse_state state);
-static svgtiny_code svgtiny_parse_poly(xmlNode *poly,
+static svgtiny_code svgtiny_parse_poly(dom_element *poly,
                struct svgtiny_parse_state state, bool polygon);
-static svgtiny_code svgtiny_parse_text(xmlNode *text,
+static svgtiny_code svgtiny_parse_text(dom_element *text,
                struct svgtiny_parse_state state);
-static void svgtiny_parse_position_attributes(const xmlNode *node,
+static void svgtiny_parse_position_attributes(dom_element *node,
                const struct svgtiny_parse_state state,
                float *x, float *y, float *width, float *height);
-static void svgtiny_parse_paint_attributes(const xmlNode *node,
+static void svgtiny_parse_paint_attributes(dom_element *node,
                struct svgtiny_parse_state *state);
-static void svgtiny_parse_font_attributes(const xmlNode *node,
+static void svgtiny_parse_font_attributes(dom_element *node,
                struct svgtiny_parse_state *state);
-static void svgtiny_parse_transform_attributes(xmlNode *node,
+static void svgtiny_parse_transform_attributes(dom_element *node,
                struct svgtiny_parse_state *state);
 static svgtiny_code svgtiny_add_path(float *p, unsigned int n,
                struct svgtiny_parse_state *state);
+static void _svgtiny_parse_color(const char *s, svgtiny_colour *c,
+               struct svgtiny_parse_state *state);
+
+/**
+ * Set the local externally-stored parts of a parse state.
+ * Call this in functions that made a new state on the stack.
+ * Doesn't make own copy of global state, such as the interned string list.
+ */
+static void svgtiny_setup_state_local(struct svgtiny_parse_state *state)
+{
+       if (state->gradient_x1 != NULL) {
+               dom_string_ref(state->gradient_x1);
+       }
+       if (state->gradient_y1 != NULL) {
+               dom_string_ref(state->gradient_y1);
+       }
+       if (state->gradient_x2 != NULL) {
+               dom_string_ref(state->gradient_x2);
+       }
+       if (state->gradient_y2 != NULL) {
+               dom_string_ref(state->gradient_y2);
+       }
+}
+
+/**
+ * Cleanup the local externally-stored parts of a parse state.
+ * Call this in functions that made a new state on the stack.
+ * Doesn't cleanup global state, such as the interned string list.
+ */
+static void svgtiny_cleanup_state_local(struct svgtiny_parse_state *state)
+{
+       if (state->gradient_x1 != NULL) {
+               dom_string_unref(state->gradient_x1);
+               state->gradient_x1 = NULL;
+       }
+       if (state->gradient_y1 != NULL) {
+               dom_string_unref(state->gradient_y1);
+               state->gradient_y1 = NULL;
+       }
+       if (state->gradient_x2 != NULL) {
+               dom_string_unref(state->gradient_x2);
+               state->gradient_x2 = NULL;
+       }
+       if (state->gradient_y2 != NULL) {
+               dom_string_unref(state->gradient_y2);
+               state->gradient_y2 = NULL;
+       }
+}
 
 
 /**
@@ -61,18 +111,21 @@ struct svgtiny_diagram *svgtiny_create(void)
 {
        struct svgtiny_diagram *diagram;
 
-       diagram = malloc(sizeof *diagram);
+       diagram = calloc(sizeof(*diagram), 1);
        if (!diagram)
                return 0;
 
-       diagram->shape = 0;
-       diagram->shape_count = 0;
-       diagram->error_line = 0;
-       diagram->error_message = 0;
-
        return diagram;
+       free(diagram);
+       return NULL;
 }
 
+static void ignore_msg(uint32_t severity, void *ctx, const char *msg, ...)
+{
+       UNUSED(severity);
+       UNUSED(ctx);
+       UNUSED(msg);
+}
 
 /**
  * Parse a block of memory into a svgtiny_diagram.
@@ -82,8 +135,13 @@ svgtiny_code svgtiny_parse(struct svgtiny_diagram *diagram,
                const char *buffer, size_t size, const char *url,
                int viewport_width, int viewport_height)
 {
-       xmlDoc *document;
-       xmlNode *svg;
+       dom_document *document;
+       dom_exception exc;
+       dom_xml_parser *parser;
+       dom_xml_error err;
+       dom_element *svg;
+       dom_string *svg_name;
+       lwc_string *svg_name_lwc;
        struct svgtiny_parse_state state;
        float x, y, width, height;
        svgtiny_code code;
@@ -92,26 +150,91 @@ svgtiny_code svgtiny_parse(struct svgtiny_diagram *diagram,
        assert(buffer);
        assert(url);
 
-       /* parse XML to tree */
-       document = xmlReadMemory(buffer, size, url, 0,
-                       XML_PARSE_NONET | XML_PARSE_COMPACT);
-       if (!document)
-               return svgtiny_LIBXML_ERROR;
+       UNUSED(url);
 
-       /*xmlDebugDumpDocument(stderr, document);*/
+       state.gradient_x1 = NULL;
+       state.gradient_y1 = NULL;
+       state.gradient_x2 = NULL;
+       state.gradient_y2 = NULL;
+
+       parser = dom_xml_parser_create(NULL, NULL,
+                                      ignore_msg, NULL, &document);
+
+       if (parser == NULL)
+               return svgtiny_LIBDOM_ERROR;
+
+       err = dom_xml_parser_parse_chunk(parser, (uint8_t *)buffer, size);
+       if (err != DOM_XML_OK) {
+               dom_node_unref(document);
+               dom_xml_parser_destroy(parser);
+               return svgtiny_LIBDOM_ERROR;
+       }
+
+       err = dom_xml_parser_completed(parser);
+       if (err != DOM_XML_OK) {
+               dom_node_unref(document);
+               dom_xml_parser_destroy(parser);
+               return svgtiny_LIBDOM_ERROR;
+       }
+
+       /* We're done parsing, drop the parser.
+        * We now own the document entirely.
+        */
+       dom_xml_parser_destroy(parser);
 
        /* find root <svg> element */
-       svg = xmlDocGetRootElement(document);
-       if (!svg)
-               return svgtiny_NOT_SVG;
-       if (strcmp((const char *) svg->name, "svg") != 0)
+       exc = dom_document_get_document_element(document, &svg);
+       if (exc != DOM_NO_ERR) {
+               dom_node_unref(document);
+               return svgtiny_LIBDOM_ERROR;
+       }
+        if (svg == NULL) {
+                /* no root svg element */
+                dom_node_unref(document);
+               return svgtiny_SVG_ERROR;
+        }
+
+       exc = dom_node_get_node_name(svg, &svg_name);
+       if (exc != DOM_NO_ERR) {
+               dom_node_unref(svg);
+               dom_node_unref(document);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (lwc_intern_string("svg", 3 /* SLEN("svg") */,
+                             &svg_name_lwc) != lwc_error_ok) {
+               dom_string_unref(svg_name);
+               dom_node_unref(svg);
+               dom_node_unref(document);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (!dom_string_caseless_lwc_isequal(svg_name, svg_name_lwc)) {
+               lwc_string_unref(svg_name_lwc);
+               dom_string_unref(svg_name);
+               dom_node_unref(svg);
+               dom_node_unref(document);
                return svgtiny_NOT_SVG;
+       }
+
+       lwc_string_unref(svg_name_lwc);
+       dom_string_unref(svg_name);
 
        /* get graphic dimensions */
+       memset(&state, 0, sizeof(state));
        state.diagram = diagram;
        state.document = document;
        state.viewport_width = viewport_width;
        state.viewport_height = viewport_height;
+
+#define SVGTINY_STRING_ACTION2(s,n)                                    \
+       if (dom_string_create_interned((const uint8_t *) #n,            \
+                                      strlen(#n), &state.interned_##s) \
+           != DOM_NO_ERR) {                                            \
+               code = svgtiny_LIBDOM_ERROR;                            \
+               goto cleanup;                                           \
+       }
+#include "svgtiny_strings.h"
+#undef SVGTINY_STRING_ACTION2
+
        svgtiny_parse_position_attributes(svg, state, &x, &y, &width, &height);
        diagram->width = width;
        diagram->height = height;
@@ -135,9 +258,16 @@ svgtiny_code svgtiny_parse(struct svgtiny_diagram *diagram,
        /* parse tree */
        code = svgtiny_parse_svg(svg, state);
 
-       /* free XML tree */
-       xmlFreeDoc(document);
+       dom_node_unref(svg);
+       dom_node_unref(document);
 
+cleanup:
+       svgtiny_cleanup_state_local(&state);
+#define SVGTINY_STRING_ACTION2(s,n)                    \
+       if (state.interned_##s != NULL)                 \
+               dom_string_unref(state.interned_##s);
+#include "svgtiny_strings.h"
+#undef SVGTINY_STRING_ACTION2
        return code;
 }
 
@@ -146,19 +276,30 @@ svgtiny_code svgtiny_parse(struct svgtiny_diagram *diagram,
  * Parse a <svg> or <g> element node.
  */
 
-svgtiny_code svgtiny_parse_svg(xmlNode *svg,
+svgtiny_code svgtiny_parse_svg(dom_element *svg,
                struct svgtiny_parse_state state)
 {
        float x, y, width, height;
+       dom_string *view_box;
+       dom_element *child;
+       dom_exception exc;
+
+       svgtiny_setup_state_local(&state);
 
        svgtiny_parse_position_attributes(svg, state, &x, &y, &width, &height);
        svgtiny_parse_paint_attributes(svg, &state);
        svgtiny_parse_font_attributes(svg, &state);
 
-       /* parse viewBox */
-       xmlAttr *view_box = xmlHasProp(svg, (const xmlChar *) "viewBox");
+       exc = dom_element_get_attribute(svg, state.interned_viewBox,
+                                       &view_box);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+
        if (view_box) {
-               const char *s = (const char *) view_box->children->content;
+               char *s = strndup(dom_string_data(view_box),
+                                 dom_string_byte_length(view_box));
                float min_x, min_y, vwidth, vheight;
                if (sscanf(s, "%f,%f,%f,%f",
                                &min_x, &min_y, &vwidth, &vheight) == 4 ||
@@ -169,43 +310,86 @@ svgtiny_code svgtiny_parse_svg(xmlNode *svg,
                        state.ctm.e += -min_x * state.ctm.a;
                        state.ctm.f += -min_y * state.ctm.d;
                }
+               free(s);
+               dom_string_unref(view_box);
        }
 
        svgtiny_parse_transform_attributes(svg, &state);
 
-       for (xmlNode *child = svg->children; child; child = child->next) {
+       exc = dom_node_get_first_child(svg, (dom_node **) (void *) &child);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       while (child != NULL) {
+               dom_element *next;
+               dom_node_type nodetype;
                svgtiny_code code = svgtiny_OK;
 
-               if (child->type == XML_ELEMENT_NODE) {
-                       const char *name = (const char *) child->name;
-                       if (strcmp(name, "svg") == 0)
+               exc = dom_node_get_node_type(child, &nodetype);
+               if (exc != DOM_NO_ERR) {
+                       dom_node_unref(child);
+                       return svgtiny_LIBDOM_ERROR;
+               }
+               if (nodetype == DOM_ELEMENT_NODE) {
+                       dom_string *nodename;
+                       exc = dom_node_get_node_name(child, &nodename);
+                       if (exc != DOM_NO_ERR) {
+                               dom_node_unref(child);
+                               svgtiny_cleanup_state_local(&state);
+                               return svgtiny_LIBDOM_ERROR;
+                       }
+                       if (dom_string_caseless_isequal(state.interned_svg,
+                                                       nodename))
                                code = svgtiny_parse_svg(child, state);
-                       else if (strcmp(name, "g") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_g,
+                                                            nodename))
                                code = svgtiny_parse_svg(child, state);
-                       else if (strcmp(name, "a") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_a,
+                                                            nodename))
                                code = svgtiny_parse_svg(child, state);
-                       else if (strcmp(name, "path") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_path,
+                                                            nodename))
                                code = svgtiny_parse_path(child, state);
-                       else if (strcmp(name, "rect") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_rect,
+                                                            nodename))
                                code = svgtiny_parse_rect(child, state);
-                       else if (strcmp(name, "circle") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_circle,
+                                                            nodename))
                                code = svgtiny_parse_circle(child, state);
-                       else if (strcmp(name, "ellipse") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_ellipse,
+                                                            nodename))
                                code = svgtiny_parse_ellipse(child, state);
-                       else if (strcmp(name, "line") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_line,
+                                                            nodename))
                                code = svgtiny_parse_line(child, state);
-                       else if (strcmp(name, "polyline") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_polyline,
+                                                            nodename))
                                code = svgtiny_parse_poly(child, state, false);
-                       else if (strcmp(name, "polygon") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_polygon,
+                                                            nodename))
                                code = svgtiny_parse_poly(child, state, true);
-                       else if (strcmp(name, "text") == 0)
+                       else if (dom_string_caseless_isequal(state.interned_text,
+                                                            nodename))
                                code = svgtiny_parse_text(child, state);
+                       dom_string_unref(nodename);
                }
-
-               if (code != svgtiny_OK)
+               if (code != svgtiny_OK) {
+                       dom_node_unref(child);
+                       svgtiny_cleanup_state_local(&state);
                        return code;
+               }
+               exc = dom_node_get_next_sibling(child,
+                                               (dom_node **) (void *) &next);
+               dom_node_unref(child);
+               if (exc != DOM_NO_ERR) {
+                       svgtiny_cleanup_state_local(&state);
+                       return svgtiny_LIBDOM_ERROR;
+               }
+               child = next;
        }
 
+       svgtiny_cleanup_state_local(&state);
        return svgtiny_OK;
 }
 
@@ -217,41 +401,101 @@ svgtiny_code svgtiny_parse_svg(xmlNode *svg,
  * http://www.w3.org/TR/SVG11/paths#PathElement
  */
 
-svgtiny_code svgtiny_parse_path(xmlNode *path,
+svgtiny_code svgtiny_parse_path(dom_element *path,
                struct svgtiny_parse_state state)
 {
+       svgtiny_code err;
+       dom_string *path_d_str;
+       dom_exception exc;
        char *s, *path_d;
+       float *p; /* path elemets */
+        unsigned int palloc; /* number of path elements allocated */
+       unsigned int i;
+       float last_x = 0, last_y = 0;
+       float last_cubic_x = 0, last_cubic_y = 0;
+       float last_quad_x = 0, last_quad_y = 0;
+       float subpath_first_x = 0, subpath_first_y = 0;
+
+       svgtiny_setup_state_local(&state);
 
        svgtiny_parse_paint_attributes(path, &state);
        svgtiny_parse_transform_attributes(path, &state);
 
        /* read d attribute */
-       s = path_d = (char *) xmlGetProp(path, (const xmlChar *) "d");
-       if (!s) {
-               state.diagram->error_line = path->line;
+       exc = dom_element_get_attribute(path, state.interned_d, &path_d_str);
+       if (exc != DOM_NO_ERR) {
+               state.diagram->error_line = -1; /* path->line; */
+               state.diagram->error_message = "path: error retrieving d attribute";
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_SVG_ERROR;
+       }
+
+       if (path_d_str == NULL) {
+               state.diagram->error_line = -1; /* path->line; */
                state.diagram->error_message = "path: missing d attribute";
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_SVG_ERROR;
        }
 
-       /* allocate space for path: it will never have more elements than d */
-       float *p = malloc(sizeof p[0] * strlen(s));
-       if (!p)
+        /* empty path is permitted it just disables the path */
+        palloc = dom_string_byte_length(path_d_str);
+        if (palloc == 0) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_OK;
+        }
+
+        /* local copy of the path data allowing in-place modification */
+       s = path_d = strndup(dom_string_data(path_d_str), palloc);
+       dom_string_unref(path_d_str);
+       if (s == NULL) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_OUT_OF_MEMORY;
+       }
+
+        /* ensure path element allocation is sensibly bounded */
+        if (palloc < 8) {
+            palloc = 8;
+        } else if (palloc > 64) {
+            palloc = palloc / 2;
+        }
+
+       /* allocate initial space for path elements */
+       p = malloc(sizeof p[0] * palloc);
+       if (p == NULL) {
+               free(path_d);
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OUT_OF_MEMORY;
+       }
 
        /* parse d and build path */
-       for (unsigned int i = 0; s[i]; i++)
+       for (i = 0; s[i]; i++)
                if (s[i] == ',')
                        s[i] = ' ';
-       unsigned int i = 0;
-       float last_x = 0, last_y = 0;
-       float last_cubic_x = 0, last_cubic_y = 0;
-       float last_quad_x = 0, last_quad_y = 0;
+       i = 0;
        while (*s) {
                char command[2];
                int plot_command;
                float x, y, x1, y1, x2, y2, rx, ry, rotation, large_arc, sweep;
                int n;
 
+                /* Ensure there is sufficient space for path elements */
+#define ALLOC_PATH_ELEMENTS(NUM_ELEMENTS)                               \
+                do {                                                    \
+                        if ((palloc - i) < NUM_ELEMENTS) {              \
+                                float *tp;                              \
+                                palloc = (palloc * 2) + (palloc / 2);   \
+                                tp = realloc(p, sizeof p[0] * palloc);  \
+                                if (tp == NULL) {                       \
+                                        free(p);                        \
+                                        free(path_d);                   \
+                                        svgtiny_cleanup_state_local(&state); \
+                                        return svgtiny_OUT_OF_MEMORY;   \
+                                }                                       \
+                                p = tp;                                 \
+                        }                                               \
+                } while(0)
+
+
                /* moveto (M, m), lineto (L, l) (2 arguments) */
                if (sscanf(s, " %1[MmLl] %f %f %n", command, &x, &y, &n) == 3) {
                        /*LOG(("moveto or lineto"));*/
@@ -260,11 +504,16 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                        else
                                plot_command = svgtiny_PATH_LINE;
                        do {
+                                ALLOC_PATH_ELEMENTS(3);
                                p[i++] = plot_command;
                                if ('a' <= *command) {
                                        x += last_x;
                                        y += last_y;
                                }
+                               if (plot_command == svgtiny_PATH_MOVE) {
+                                       subpath_first_x = x;
+                                       subpath_first_y = y;
+                               }
                                p[i++] = last_cubic_x = last_quad_x = last_x
                                                = x;
                                p[i++] = last_cubic_y = last_quad_y = last_y
@@ -276,13 +525,19 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                /* closepath (Z, z) (no arguments) */
                } else if (sscanf(s, " %1[Zz] %n", command, &n) == 1) {
                        /*LOG(("closepath"));*/
+                        ALLOC_PATH_ELEMENTS(1);
+
                        p[i++] = svgtiny_PATH_CLOSE;
                        s += n;
+                       last_cubic_x = last_quad_x = last_x = subpath_first_x;
+                       last_cubic_y = last_quad_y = last_y = subpath_first_y;
 
                /* horizontal lineto (H, h) (1 argument) */
                } else if (sscanf(s, " %1[Hh] %f %n", command, &x, &n) == 2) {
                        /*LOG(("horizontal lineto"));*/
                        do {
+                                ALLOC_PATH_ELEMENTS(3);
+
                                p[i++] = svgtiny_PATH_LINE;
                                if (*command == 'h')
                                        x += last_x;
@@ -296,6 +551,8 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                } else if (sscanf(s, " %1[Vv] %f %n", command, &y, &n) == 2) {
                        /*LOG(("vertical lineto"));*/
                        do {
+                                ALLOC_PATH_ELEMENTS(3);
+
                                p[i++] = svgtiny_PATH_LINE;
                                if (*command == 'v')
                                        y += last_y;
@@ -310,6 +567,8 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                                &x1, &y1, &x2, &y2, &x, &y, &n) == 7) {
                        /*LOG(("curveto"));*/
                        do {
+                                ALLOC_PATH_ELEMENTS(7);
+
                                p[i++] = svgtiny_PATH_BEZIER;
                                if (*command == 'c') {
                                        x1 += last_x;
@@ -334,6 +593,8 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                                &x2, &y2, &x, &y, &n) == 5) {
                        /*LOG(("shorthand/smooth curveto"));*/
                        do {
+                                ALLOC_PATH_ELEMENTS(7);
+
                                p[i++] = svgtiny_PATH_BEZIER;
                                x1 = last_x + (last_x - last_cubic_x);
                                y1 = last_y + (last_y - last_cubic_y);
@@ -358,6 +619,8 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                                &x1, &y1, &x, &y, &n) == 5) {
                        /*LOG(("quadratic Bezier curveto"));*/
                        do {
+                                ALLOC_PATH_ELEMENTS(7);
+
                                p[i++] = svgtiny_PATH_BEZIER;
                                last_quad_x = x1;
                                last_quad_y = y1;
@@ -383,6 +646,8 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                                &x, &y, &n) == 3) {
                        /*LOG(("shorthand/smooth quadratic Bezier curveto"));*/
                        do {
+                                ALLOC_PATH_ELEMENTS(7);
+
                                p[i++] = svgtiny_PATH_BEZIER;
                                x1 = last_x + (last_x - last_quad_x);
                                y1 = last_y + (last_y - last_quad_y);
@@ -409,6 +674,8 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                                &rx, &ry, &rotation, &large_arc, &sweep,
                                &x, &y, &n) == 8) {
                        do {
+                                ALLOC_PATH_ELEMENTS(3);
+
                                p[i++] = svgtiny_PATH_LINE;
                                if (*command == 'a') {
                                        x += last_x;
@@ -429,15 +696,33 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
                }
        }
 
-       xmlFree(path_d);
+       free(path_d);
 
        if (i <= 4) {
                /* no real segments in path */
                free(p);
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OK;
        }
 
-       return svgtiny_add_path(p, i, &state);
+        /* resize path element array to not be over allocated */
+        if (palloc != i) {
+                float *tp;
+
+                /* try the resize, if it fails just continue to use the old
+                 * allocation
+                 */
+                tp = realloc(p, sizeof p[0] * i);
+                if (tp != NULL) {
+                        p = tp;
+                }
+        }
+
+       err = svgtiny_add_path(p, i, &state);
+
+       svgtiny_cleanup_state_local(&state);
+
+       return err;
 }
 
 
@@ -447,19 +732,25 @@ svgtiny_code svgtiny_parse_path(xmlNode *path,
  * http://www.w3.org/TR/SVG11/shapes#RectElement
  */
 
-svgtiny_code svgtiny_parse_rect(xmlNode *rect,
+svgtiny_code svgtiny_parse_rect(dom_element *rect,
                struct svgtiny_parse_state state)
 {
+       svgtiny_code err;
        float x, y, width, height;
+       float *p;
+
+       svgtiny_setup_state_local(&state);
 
        svgtiny_parse_position_attributes(rect, state,
                        &x, &y, &width, &height);
        svgtiny_parse_paint_attributes(rect, &state);
        svgtiny_parse_transform_attributes(rect, &state);
 
-       float *p = malloc(13 * sizeof p[0]);
-       if (!p)
+       p = malloc(13 * sizeof p[0]);
+       if (!p) {
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OUT_OF_MEMORY;
+       }
 
        p[0] = svgtiny_PATH_MOVE;
        p[1] = x;
@@ -475,7 +766,11 @@ svgtiny_code svgtiny_parse_rect(xmlNode *rect,
        p[11] = y + height;
        p[12] = svgtiny_PATH_CLOSE;
 
-       return svgtiny_add_path(p, 13, &state);
+       err = svgtiny_add_path(p, 13, &state);
+
+       svgtiny_cleanup_state_local(&state);
+
+       return err;
 }
 
 
@@ -483,38 +778,66 @@ svgtiny_code svgtiny_parse_rect(xmlNode *rect,
  * Parse a <circle> element node.
  */
 
-svgtiny_code svgtiny_parse_circle(xmlNode *circle,
+svgtiny_code svgtiny_parse_circle(dom_element *circle,
                struct svgtiny_parse_state state)
 {
+       svgtiny_code err;
        float x = 0, y = 0, r = -1;
+       float *p;
+       dom_string *attr;
+       dom_exception exc;
+
+       svgtiny_setup_state_local(&state);
+
+       exc = dom_element_get_attribute(circle, state.interned_cx, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               x = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(circle, state.interned_cy, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               y = svgtiny_parse_length(attr, state.viewport_height, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(circle, state.interned_r, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               r = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
 
-       for (xmlAttr *attr = circle->properties; attr; attr = attr->next) {
-               const char *name = (const char *) attr->name;
-               const char *content = (const char *) attr->children->content;
-               if (strcmp(name, "cx") == 0)
-                       x = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "cy") == 0)
-                       y = svgtiny_parse_length(content,
-                                       state.viewport_height, state);
-               else if (strcmp(name, "r") == 0)
-                       r = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-        }
        svgtiny_parse_paint_attributes(circle, &state);
        svgtiny_parse_transform_attributes(circle, &state);
 
        if (r < 0) {
-               state.diagram->error_line = circle->line;
+               state.diagram->error_line = -1; /* circle->line; */
                state.diagram->error_message = "circle: r missing or negative";
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_SVG_ERROR;
        }
-       if (r == 0)
+       if (r == 0) {
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OK;
+       }
 
-       float *p = malloc(32 * sizeof p[0]);
-       if (!p)
+       p = malloc(32 * sizeof p[0]);
+       if (!p) {
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OUT_OF_MEMORY;
+       }
 
        p[0] = svgtiny_PATH_MOVE;
        p[1] = x + r;
@@ -548,8 +871,12 @@ svgtiny_code svgtiny_parse_circle(xmlNode *circle,
        p[29] = x + r;
        p[30] = y;
        p[31] = svgtiny_PATH_CLOSE;
+
+       err = svgtiny_add_path(p, 32, &state);
+
+       svgtiny_cleanup_state_local(&state);
        
-       return svgtiny_add_path(p, 32, &state);
+       return err;
 }
 
 
@@ -557,42 +884,77 @@ svgtiny_code svgtiny_parse_circle(xmlNode *circle,
  * Parse an <ellipse> element node.
  */
 
-svgtiny_code svgtiny_parse_ellipse(xmlNode *ellipse,
+svgtiny_code svgtiny_parse_ellipse(dom_element *ellipse,
                struct svgtiny_parse_state state)
 {
+       svgtiny_code err;
        float x = 0, y = 0, rx = -1, ry = -1;
+       float *p;
+       dom_string *attr;
+       dom_exception exc;
+
+       svgtiny_setup_state_local(&state);
+
+       exc = dom_element_get_attribute(ellipse, state.interned_cx, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               x = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(ellipse, state.interned_cy, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               y = svgtiny_parse_length(attr, state.viewport_height, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(ellipse, state.interned_rx, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               rx = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(ellipse, state.interned_ry, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               ry = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
 
-       for (xmlAttr *attr = ellipse->properties; attr; attr = attr->next) {
-               const char *name = (const char *) attr->name;
-               const char *content = (const char *) attr->children->content;
-               if (strcmp(name, "cx") == 0)
-                       x = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "cy") == 0)
-                       y = svgtiny_parse_length(content,
-                                       state.viewport_height, state);
-               else if (strcmp(name, "rx") == 0)
-                       rx = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "ry") == 0)
-                       ry = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-        }
        svgtiny_parse_paint_attributes(ellipse, &state);
        svgtiny_parse_transform_attributes(ellipse, &state);
 
        if (rx < 0 || ry < 0) {
-               state.diagram->error_line = ellipse->line;
+               state.diagram->error_line = -1; /* ellipse->line; */
                state.diagram->error_message = "ellipse: rx or ry missing "
                                "or negative";
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_SVG_ERROR;
        }
-       if (rx == 0 || ry == 0)
+       if (rx == 0 || ry == 0) {
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OK;
+       }
 
-       float *p = malloc(32 * sizeof p[0]);
-       if (!p)
+       p = malloc(32 * sizeof p[0]);
+       if (!p) {
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OUT_OF_MEMORY;
+       }
 
        p[0] = svgtiny_PATH_MOVE;
        p[1] = x + rx;
@@ -627,7 +989,11 @@ svgtiny_code svgtiny_parse_ellipse(xmlNode *ellipse,
        p[30] = y;
        p[31] = svgtiny_PATH_CLOSE;
        
-       return svgtiny_add_path(p, 32, &state);
+       err = svgtiny_add_path(p, 32, &state);
+
+       svgtiny_cleanup_state_local(&state);
+
+       return err;
 }
 
 
@@ -635,33 +1001,65 @@ svgtiny_code svgtiny_parse_ellipse(xmlNode *ellipse,
  * Parse a <line> element node.
  */
 
-svgtiny_code svgtiny_parse_line(xmlNode *line,
+svgtiny_code svgtiny_parse_line(dom_element *line,
                struct svgtiny_parse_state state)
 {
+       svgtiny_code err;
        float x1 = 0, y1 = 0, x2 = 0, y2 = 0;
+       float *p;
+       dom_string *attr;
+       dom_exception exc;
+
+       svgtiny_setup_state_local(&state);
+
+       exc = dom_element_get_attribute(line, state.interned_x1, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               x1 = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(line, state.interned_y1, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               y1 = svgtiny_parse_length(attr, state.viewport_height, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(line, state.interned_x2, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               x2 = svgtiny_parse_length(attr, state.viewport_width, state);
+       }
+       dom_string_unref(attr);
+
+       exc = dom_element_get_attribute(line, state.interned_y2, &attr);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       if (attr != NULL) {
+               y2 = svgtiny_parse_length(attr, state.viewport_height, state);
+       }
+       dom_string_unref(attr);
 
-       for (xmlAttr *attr = line->properties; attr; attr = attr->next) {
-               const char *name = (const char *) attr->name;
-               const char *content = (const char *) attr->children->content;
-               if (strcmp(name, "x1") == 0)
-                       x1 = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "y1") == 0)
-                       y1 = svgtiny_parse_length(content,
-                                       state.viewport_height, state);
-               else if (strcmp(name, "x2") == 0)
-                       x2 = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "y2") == 0)
-                       y2 = svgtiny_parse_length(content,
-                                       state.viewport_height, state);
-        }
        svgtiny_parse_paint_attributes(line, &state);
        svgtiny_parse_transform_attributes(line, &state);
 
-       float *p = malloc(7 * sizeof p[0]);
-       if (!p)
+       p = malloc(7 * sizeof p[0]);
+       if (!p) {
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OUT_OF_MEMORY;
+       }
 
        p[0] = svgtiny_PATH_MOVE;
        p[1] = x1;
@@ -671,7 +1069,11 @@ svgtiny_code svgtiny_parse_line(xmlNode *line,
        p[5] = y2;
        p[6] = svgtiny_PATH_CLOSE;
 
-       return svgtiny_add_path(p, 7, &state);
+       err = svgtiny_add_path(p, 7, &state);
+
+       svgtiny_cleanup_state_local(&state);
+
+       return err;
 }
 
 
@@ -682,35 +1084,57 @@ svgtiny_code svgtiny_parse_line(xmlNode *line,
  * http://www.w3.org/TR/SVG11/shapes#PolygonElement
  */
 
-svgtiny_code svgtiny_parse_poly(xmlNode *poly,
+svgtiny_code svgtiny_parse_poly(dom_element *poly,
                struct svgtiny_parse_state state, bool polygon)
 {
+       svgtiny_code err;
+       dom_string *points_str;
+       dom_exception exc;
        char *s, *points;
+       float *p;
+       unsigned int i;
+
+       svgtiny_setup_state_local(&state);
 
        svgtiny_parse_paint_attributes(poly, &state);
        svgtiny_parse_transform_attributes(poly, &state);
-
-       /* read points attribute */
-       s = points = (char *) xmlGetProp(poly, (const xmlChar *) "points");
-       if (!s) {
-               state.diagram->error_line = poly->line;
+       
+       exc = dom_element_get_attribute(poly, state.interned_points,
+                                       &points_str);
+       if (exc != DOM_NO_ERR) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_LIBDOM_ERROR;
+       }
+       
+       if (points_str == NULL) {
+               state.diagram->error_line = -1; /* poly->line; */
                state.diagram->error_message =
                                "polyline/polygon: missing points attribute";
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_SVG_ERROR;
        }
 
+       s = points = strndup(dom_string_data(points_str),
+                            dom_string_byte_length(points_str));
+       dom_string_unref(points_str);
+       /* read points attribute */
+       if (s == NULL) {
+               svgtiny_cleanup_state_local(&state);
+               return svgtiny_OUT_OF_MEMORY;
+       }
        /* allocate space for path: it will never have more elements than s */
-       float *p = malloc(sizeof p[0] * strlen(s));
+       p = malloc(sizeof p[0] * strlen(s));
        if (!p) {
-               xmlFree(points);
+               free(points);
+               svgtiny_cleanup_state_local(&state);
                return svgtiny_OUT_OF_MEMORY;
        }
 
        /* parse s and build path */
-       for (unsigned int i = 0; s[i]; i++)
+       for (i = 0; s[i]; i++)
                if (s[i] == ',')
                        s[i] = ' ';
-       unsigned int i = 0;
+       i = 0;
        while (*s) {
                float x, y;
                int n;
@@ -730,9 +1154,13 @@ svgtiny_code svgtiny_parse_poly(xmlNode *poly,
         if (polygon)
                p[i++] = svgtiny_PATH_CLOSE;
 
-       xmlFree(points);
+       free(points);
 
-       return svgtiny_add_path(p, i, &state);
+       err = svgtiny_add_path(p, i, &state);
+
+       svgtiny_cleanup_state_local(&state);
+
+       return err;
 }
 
 
@@ -740,46 +1168,100 @@ svgtiny_code svgtiny_parse_poly(xmlNode *poly,
  * Parse a <text> or <tspan> element node.
  */
 
-svgtiny_code svgtiny_parse_text(xmlNode *text,
+svgtiny_code svgtiny_parse_text(dom_element *text,
                struct svgtiny_parse_state state)
 {
        float x, y, width, height;
+       float px, py;
+       dom_node *child;
+       dom_exception exc;
+
+       svgtiny_setup_state_local(&state);
 
        svgtiny_parse_position_attributes(text, state,
                        &x, &y, &width, &height);
        svgtiny_parse_font_attributes(text, &state);
        svgtiny_parse_transform_attributes(text, &state);
 
-       float px = state.ctm.a * x + state.ctm.c * y + state.ctm.e;
-       float py = state.ctm.b * x + state.ctm.d * y + state.ctm.f;
+       px = state.ctm.a * x + state.ctm.c * y + state.ctm.e;
+       py = state.ctm.b * x + state.ctm.d * y + state.ctm.f;
 /*     state.ctm.e = px - state.origin_x; */
 /*     state.ctm.f = py - state.origin_y; */
 
        /*struct css_style style = state.style;
        style.font_size.value.length.value *= state.ctm.a;*/
-
-       for (xmlNode *child = text->children; child; child = child->next) {
+       
+        exc = dom_node_get_first_child(text, &child);
+       if (exc != DOM_NO_ERR) {
+               return svgtiny_LIBDOM_ERROR;
+               svgtiny_cleanup_state_local(&state);
+       }
+       while (child != NULL) {
+               dom_node *next;
+               dom_node_type nodetype;
                svgtiny_code code = svgtiny_OK;
 
-               if (child->type == XML_TEXT_NODE) {
+               exc = dom_node_get_node_type(child, &nodetype);
+               if (exc != DOM_NO_ERR) {
+                       dom_node_unref(child);
+                       svgtiny_cleanup_state_local(&state);
+                       return svgtiny_LIBDOM_ERROR;
+               }
+               if (nodetype == DOM_ELEMENT_NODE) {
+                       dom_string *nodename;
+                       exc = dom_node_get_node_name(child, &nodename);
+                       if (exc != DOM_NO_ERR) {
+                               dom_node_unref(child);
+                               svgtiny_cleanup_state_local(&state);
+                               return svgtiny_LIBDOM_ERROR;
+                       }
+                       if (dom_string_caseless_isequal(nodename,
+                                                       state.interned_tspan))
+                               code = svgtiny_parse_text((dom_element *)child,
+                                                         state);
+                       dom_string_unref(nodename);
+               } else if (nodetype == DOM_TEXT_NODE) {
                        struct svgtiny_shape *shape = svgtiny_add_shape(&state);
-                       if (!shape)
+                       dom_string *content;
+                       if (shape == NULL) {
+                               dom_node_unref(child);
+                               svgtiny_cleanup_state_local(&state);
                                return svgtiny_OUT_OF_MEMORY;
-                       shape->text = strdup((const char *) child->content);
+                       }
+                       exc = dom_text_get_whole_text(child, &content);
+                       if (exc != DOM_NO_ERR) {
+                               dom_node_unref(child);
+                               svgtiny_cleanup_state_local(&state);
+                               return svgtiny_LIBDOM_ERROR;
+                       }
+                       if (content != NULL) {
+                               shape->text = strndup(dom_string_data(content),
+                                                     dom_string_byte_length(content));
+                               dom_string_unref(content);
+                       } else {
+                               shape->text = strdup("");
+                       }
                        shape->text_x = px;
                        shape->text_y = py;
                        state.diagram->shape_count++;
-
-               } else if (child->type == XML_ELEMENT_NODE &&
-                               strcmp((const char *) child->name,
-                                       "tspan") == 0) {
-                       code = svgtiny_parse_text(child, state);
                }
 
-               if (!code != svgtiny_OK)
+               if (code != svgtiny_OK) {
+                       dom_node_unref(child);
+                       svgtiny_cleanup_state_local(&state);
                        return code;
+               }
+               exc = dom_node_get_next_sibling(child, &next);
+               dom_node_unref(child);
+               if (exc != DOM_NO_ERR) {
+                       svgtiny_cleanup_state_local(&state);
+                       return svgtiny_LIBDOM_ERROR;
+               }
+               child = next;
        }
 
+       svgtiny_cleanup_state_local(&state);
+
        return svgtiny_OK;
 }
 
@@ -788,30 +1270,42 @@ svgtiny_code svgtiny_parse_text(xmlNode *text,
  * Parse x, y, width, and height attributes, if present.
  */
 
-void svgtiny_parse_position_attributes(const xmlNode *node,
+void svgtiny_parse_position_attributes(dom_element *node,
                const struct svgtiny_parse_state state,
                float *x, float *y, float *width, float *height)
 {
+       dom_string *attr;
+       dom_exception exc;
+
        *x = 0;
        *y = 0;
        *width = state.viewport_width;
        *height = state.viewport_height;
 
-       for (xmlAttr *attr = node->properties; attr; attr = attr->next) {
-               const char *name = (const char *) attr->name;
-               const char *content = (const char *) attr->children->content;
-               if (strcmp(name, "x") == 0)
-                       *x = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "y") == 0)
-                       *y = svgtiny_parse_length(content,
-                                       state.viewport_height, state);
-               else if (strcmp(name, "width") == 0)
-                       *width = svgtiny_parse_length(content,
-                                       state.viewport_width, state);
-               else if (strcmp(name, "height") == 0)
-                       *height = svgtiny_parse_length(content,
-                                       state.viewport_height, state);
+       exc = dom_element_get_attribute(node, state.interned_x, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               *x = svgtiny_parse_length(attr, state.viewport_width, state);
+               dom_string_unref(attr);
+       }
+
+       exc = dom_element_get_attribute(node, state.interned_y, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               *y = svgtiny_parse_length(attr, state.viewport_height, state);
+               dom_string_unref(attr);
+       }
+
+       exc = dom_element_get_attribute(node, state.interned_width, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               *width = svgtiny_parse_length(attr, state.viewport_width,
+                                             state);
+               dom_string_unref(attr);
+       }
+
+       exc = dom_element_get_attribute(node, state.interned_height, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               *height = svgtiny_parse_length(attr, state.viewport_height,
+                                              state);
+               dom_string_unref(attr);
        }
 }
 
@@ -820,8 +1314,8 @@ void svgtiny_parse_position_attributes(const xmlNode *node,
  * Parse a length as a number of pixels.
  */
 
-float svgtiny_parse_length(const char *s, int viewport_size,
-               const struct svgtiny_parse_state state)
+static float _svgtiny_parse_length(const char *s, int viewport_size,
+                                  const struct svgtiny_parse_state state)
 {
        int num_length = strspn(s, "0123456789+-.");
        const char *unit = s + num_length;
@@ -855,53 +1349,77 @@ float svgtiny_parse_length(const char *s, int viewport_size,
        return 0;
 }
 
+float svgtiny_parse_length(dom_string *s, int viewport_size,
+                          const struct svgtiny_parse_state state)
+{
+       char *ss = strndup(dom_string_data(s), dom_string_byte_length(s));
+       float ret = _svgtiny_parse_length(ss, viewport_size, state);
+       free(ss);
+       return ret;
+}
 
 /**
  * Parse paint attributes, if present.
  */
 
-void svgtiny_parse_paint_attributes(const xmlNode *node,
+void svgtiny_parse_paint_attributes(dom_element *node,
                struct svgtiny_parse_state *state)
 {
-       for (const xmlAttr *attr = node->properties; attr; attr = attr->next) {
-               const char *name = (const char *) attr->name;
-               const char *content = (const char *) attr->children->content;
-               if (strcmp(name, "fill") == 0)
-                       svgtiny_parse_color(content, &state->fill, state);
-               else if (strcmp(name, "stroke") == 0)
-                       svgtiny_parse_color(content, &state->stroke, state);
-               else if (strcmp(name, "stroke-width") == 0)
-                       state->stroke_width = svgtiny_parse_length(content,
-                                       state->viewport_width, *state);
-               else if (strcmp(name, "style") == 0) {
-                       const char *style = (const char *)
-                                       attr->children->content;
-                       const char *s;
-                       char *value;
-                       if ((s = strstr(style, "fill:"))) {
-                               s += 5;
-                               while (*s == ' ')
-                                       s++;
-                               value = strndup(s, strcspn(s, "; "));
-                               svgtiny_parse_color(value, &state->fill, state);
-                               free(value);
-                       }
-                       if ((s = strstr(style, "stroke:"))) {
-                               s += 7;
-                               while (*s == ' ')
-                                       s++;
-                               value = strndup(s, strcspn(s, "; "));
-                               svgtiny_parse_color(value, &state->stroke, state);
-                               free(value);
-                       }
-                       if ((s = strstr(style, "stroke-width:"))) {
-                               s += 13;
-                               while (*s == ' ')
-                                       s++;
-                               state->stroke_width = svgtiny_parse_length(s,
+       dom_string *attr;
+       dom_exception exc;
+       
+       exc = dom_element_get_attribute(node, state->interned_fill, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               svgtiny_parse_color(attr, &state->fill, state);
+               dom_string_unref(attr);
+       }
+
+       exc = dom_element_get_attribute(node, state->interned_stroke, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               svgtiny_parse_color(attr, &state->stroke, state);
+               dom_string_unref(attr);
+       }
+
+       exc = dom_element_get_attribute(node, state->interned_stroke_width, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               state->stroke_width = svgtiny_parse_length(attr,
                                                state->viewport_width, *state);
-                       }
+               dom_string_unref(attr);
+       }
+
+       exc = dom_element_get_attribute(node, state->interned_style, &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               char *style = strndup(dom_string_data(attr),
+                                     dom_string_byte_length(attr));
+               const char *s;
+               char *value;
+               if ((s = strstr(style, "fill:"))) {
+                       s += 5;
+                       while (*s == ' ')
+                               s++;
+                       value = strndup(s, strcspn(s, "; "));
+                       _svgtiny_parse_color(value, &state->fill, state);
+                       free(value);
+               }
+               if ((s = strstr(style, "stroke:"))) {
+                       s += 7;
+                       while (*s == ' ')
+                               s++;
+                       value = strndup(s, strcspn(s, "; "));
+                       _svgtiny_parse_color(value, &state->stroke, state);
+                       free(value);
                }
+               if ((s = strstr(style, "stroke-width:"))) {
+                       s += 13;
+                       while (*s == ' ')
+                               s++;
+                       value = strndup(s, strcspn(s, "; "));
+                       state->stroke_width = _svgtiny_parse_length(value,
+                                               state->viewport_width, *state);
+                       free(value);
+               }
+               free(style);
+               dom_string_unref(attr);
        }
 }
 
@@ -910,7 +1428,7 @@ void svgtiny_parse_paint_attributes(const xmlNode *node,
  * Parse a colour.
  */
 
-void svgtiny_parse_color(const char *s, svgtiny_colour *c,
+static void _svgtiny_parse_color(const char *s, svgtiny_colour *c,
                struct svgtiny_parse_state *state)
 {
        unsigned int r, g, b;
@@ -951,8 +1469,6 @@ void svgtiny_parse_color(const char *s, svgtiny_colour *c,
                                *rparen = 0;
                        svgtiny_find_gradient(id, state);
                        free(id);
-                       fprintf(stderr, "linear_gradient_stop_count %i\n",
-                                       state->linear_gradient_stop_count);
                        if (state->linear_gradient_stop_count == 0)
                                *c = svgtiny_TRANSPARENT;
                        else if (state->linear_gradient_stop_count == 1)
@@ -969,17 +1485,30 @@ void svgtiny_parse_color(const char *s, svgtiny_colour *c,
        }
 }
 
+void svgtiny_parse_color(dom_string *s, svgtiny_colour *c,
+               struct svgtiny_parse_state *state)
+{
+       char *ss = strndup(dom_string_data(s), dom_string_byte_length(s));
+       _svgtiny_parse_color(ss, c, state);
+       free(ss);
+}
 
 /**
  * Parse font attributes, if present.
  */
 
-void svgtiny_parse_font_attributes(const xmlNode *node,
+void svgtiny_parse_font_attributes(dom_element *node,
                struct svgtiny_parse_state *state)
 {
+       /* TODO: Implement this, it never used to be */
+       UNUSED(node);
+       UNUSED(state);
+#ifdef WRITTEN_THIS_PROPERLY
+       const xmlAttr *attr;
+
        UNUSED(state);
 
-       for (const xmlAttr *attr = node->properties; attr; attr = attr->next) {
+       for (attr = node->properties; attr; attr = attr->next) {
                if (strcmp((const char *) attr->name, "font-size") == 0) {
                        /*if (css_parse_length(
                                        (const char *) attr->children->content,
@@ -990,6 +1519,7 @@ void svgtiny_parse_font_attributes(const xmlNode *node,
                        }*/
                }
         }
+#endif
 }
 
 
@@ -999,18 +1529,23 @@ void svgtiny_parse_font_attributes(const xmlNode *node,
  * http://www.w3.org/TR/SVG11/coords#TransformAttribute
  */
 
-void svgtiny_parse_transform_attributes(xmlNode *node,
+void svgtiny_parse_transform_attributes(dom_element *node,
                struct svgtiny_parse_state *state)
 {
        char *transform;
-
-       /* parse transform */
-       transform = (char *) xmlGetProp(node, (const xmlChar *) "transform");
-       if (transform) {
+       dom_string *attr;
+       dom_exception exc;
+       
+       exc = dom_element_get_attribute(node, state->interned_transform,
+                                       &attr);
+       if (exc == DOM_NO_ERR && attr != NULL) {
+               transform = strndup(dom_string_data(attr),
+                                   dom_string_byte_length(attr));
                svgtiny_parse_transform(transform, &state->ctm.a, &state->ctm.b,
                                &state->ctm.c, &state->ctm.d,
                                &state->ctm.e, &state->ctm.f);
-               xmlFree(transform);
+               free(transform);
+               dom_string_unref(attr);
        }
 }
 
@@ -1026,8 +1561,9 @@ void svgtiny_parse_transform(char *s, float *ma, float *mb,
        float za, zb, zc, zd, ze, zf;
        float angle, x, y;
        int n;
+       unsigned int i;
 
-       for (unsigned int i = 0; s[i]; i++)
+       for (i = 0; s[i]; i++)
                if (s[i] == ',')
                        s[i] = ' ';
 
@@ -1035,23 +1571,23 @@ void svgtiny_parse_transform(char *s, float *ma, float *mb,
                a = d = 1;
                b = c = 0;
                e = f = 0;
-               if (sscanf(s, "matrix (%f %f %f %f %f %f) %n",
-                                       &a, &b, &c, &d, &e, &f, &n) == 6)
+               if ((sscanf(s, " matrix (%f %f %f %f %f %f ) %n",
+                            &a, &b, &c, &d, &e, &f, &n) == 6) && (n > 0))
                        ;
-               else if (sscanf(s, "translate (%f %f) %n",
-                                       &e, &f, &n) == 2)
+               else if ((sscanf(s, " translate (%f %f ) %n",
+                                 &e, &f, &n) == 2) && (n > 0))
                        ;
-               else if (sscanf(s, "translate (%f) %n",
-                                       &e, &n) == 1)
+               else if ((sscanf(s, " translate (%f ) %n",
+                                 &e, &n) == 1) && (n > 0))
                        ;
-               else if (sscanf(s, "scale (%f %f) %n",
-                                       &a, &d, &n) == 2)
+               else if ((sscanf(s, " scale (%f %f ) %n",
+                                 &a, &d, &n) == 2) && (n > 0))
                        ;
-               else if (sscanf(s, "scale (%f) %n",
-                                       &a, &n) == 1)
+               else if ((sscanf(s, " scale (%f ) %n",
+                                 &a, &n) == 1) && (n > 0))
                        d = a;
-               else if (sscanf(s, "rotate (%f %f %f) %n",
-                                       &angle, &x, &y, &n) == 3) {
+               else if ((sscanf(s, " rotate (%f %f %f ) %n",
+                                 &angle, &x, &y, &n) == 3) && (n > 0)) {
                        angle = angle / 180 * M_PI;
                        a = cos(angle);
                        b = sin(angle);
@@ -1059,19 +1595,19 @@ void svgtiny_parse_transform(char *s, float *ma, float *mb,
                        d = cos(angle);
                        e = -x * cos(angle) + y * sin(angle) + x;
                        f = -x * sin(angle) - y * cos(angle) + y;
-               } else if (sscanf(s, "rotate (%f) %n",
-                                       &angle, &n) == 1) {
+               } else if ((sscanf(s, " rotate (%f ) %n",
+                                   &angle, &n) == 1) && (n > 0)) {
                        angle = angle / 180 * M_PI;
                        a = cos(angle);
                        b = sin(angle);
                        c = -sin(angle);
                        d = cos(angle);
-               } else if (sscanf(s, "skewX (%f) %n",
-                                       &angle, &n) == 1) {
+               } else if ((sscanf(s, " skewX (%f ) %n",
+                                   &angle, &n) == 1) && (n > 0)) {
                        angle = angle / 180 * M_PI;
                        c = tan(angle);
-               } else if (sscanf(s, "skewY (%f) %n",
-                                       &angle, &n) == 1) {
+               } else if ((sscanf(s, " skewY (%f ) %n",
+                                   &angle, &n) == 1) && (n > 0)) {
                        angle = angle / 180 * M_PI;
                        b = tan(angle);
                } else
@@ -1100,12 +1636,14 @@ void svgtiny_parse_transform(char *s, float *ma, float *mb,
 svgtiny_code svgtiny_add_path(float *p, unsigned int n,
                struct svgtiny_parse_state *state)
 {
+       struct svgtiny_shape *shape;
+
        if (state->fill == svgtiny_LINEAR_GRADIENT)
                return svgtiny_add_path_linear_gradient(p, n, state);
 
        svgtiny_transform_path(p, n, state);
 
-       struct svgtiny_shape *shape = svgtiny_add_shape(state);
+       shape = svgtiny_add_shape(state);
        if (!shape) {
                free(p);
                return svgtiny_OUT_OF_MEMORY;
@@ -1137,8 +1675,10 @@ struct svgtiny_shape *svgtiny_add_shape(struct svgtiny_parse_state *state)
        shape->text = 0;
        shape->fill = state->fill;
        shape->stroke = state->stroke;
-       shape->stroke_width = state->stroke_width *
-                       (state->ctm.a + state->ctm.d) / 2;
+       shape->stroke_width = lroundf((float) state->stroke_width *
+                       (state->ctm.a + state->ctm.d) / 2.0);
+       if (0 < state->stroke_width && shape->stroke_width == 0)
+               shape->stroke_width = 1;
 
        return shape;
 }
@@ -1151,8 +1691,11 @@ struct svgtiny_shape *svgtiny_add_shape(struct svgtiny_parse_state *state)
 void svgtiny_transform_path(float *p, unsigned int n,
                struct svgtiny_parse_state *state)
 {
-       for (unsigned int j = 0; j != n; ) {
+       unsigned int j;
+
+       for (j = 0; j != n; ) {
                unsigned int points = 0;
+               unsigned int k;
                switch ((int) p[j]) {
                case svgtiny_PATH_MOVE:
                case svgtiny_PATH_LINE:
@@ -1168,7 +1711,7 @@ void svgtiny_transform_path(float *p, unsigned int n,
                        assert(0);
                }
                j++;
-               for (unsigned int k = 0; k != points; k++) {
+               for (k = 0; k != points; k++) {
                        float x0 = p[j], y0 = p[j + 1];
                        float x = state->ctm.a * x0 + state->ctm.c * y0 +
                                state->ctm.e;
@@ -1188,9 +1731,10 @@ void svgtiny_transform_path(float *p, unsigned int n,
 
 void svgtiny_free(struct svgtiny_diagram *svg)
 {
+       unsigned int i;
        assert(svg);
 
-       for (unsigned int i = 0; i != svg->shape_count; i++) {
+       for (i = 0; i != svg->shape_count; i++) {
                free(svg->shape[i].path);
                free(svg->shape[i].text);
        }
@@ -1200,3 +1744,23 @@ void svgtiny_free(struct svgtiny_diagram *svg)
        free(svg);
 }
 
+#ifndef HAVE_STRNDUP
+char *svgtiny_strndup(const char *s, size_t n)
+{
+       size_t len;
+       char *s2;
+
+       for (len = 0; len != n && s[len]; len++)
+               continue;
+
+       s2 = malloc(len + 1);
+       if (s2 == NULL)
+               return NULL;
+
+       memcpy(s2, s, len);
+       s2[len] = '\0';
+
+       return s2;
+}
+#endif
+