Don't validate the CIDR strings; rather, check whether the type of the returned Cidrs...

[hath.git] / src / Main.hs

diff --git a/src/Main.hs b/src/Main.hs
index 7b3bd7b0884847a456545903594130e9a8504539..2fdcfd0459c1b2c88ecd2980e6de90a4a709cd95 100644 (file)
--- a/src/Main.hs
+++ b/src/Main.hs
@@ -2,17 +2,8 @@ import Data.List (intercalate, intersperse)
 import System.Exit (ExitCode(..), exitWith)
 import System.IO (stderr, hPutStrLn)
 
-import Cidr (Cidr,
-             from_string,
-             is_valid_cidr,
-             min_first_octet,
-             min_second_octet,
-             min_third_octet,
-             min_fourth_octet,
-             max_first_octet,
-             max_second_octet,
-             max_third_octet,
-             max_fourth_octet)
+import Cidr (Cidr(..),
+             cidr_from_string)
 
 import CommandLine (help_set,
                     help_text,
@@ -20,7 +11,10 @@ import CommandLine (help_set,
                     Mode(..),
                     parse_errors,
                     parse_mode)
-
+    
+import IPv4Address
+import Octet
+    
 -- Some exit codes, used in the ExitFailure constructor.
 exit_invalid_cidr :: Int
 exit_invalid_cidr = 1
@@ -59,14 +53,14 @@ cidr_to_regex cidr =
       range2 = numeric_range min2 max2
       range3 = numeric_range min3 max3
       range4 = numeric_range min4 max4
-      min1   = min_first_octet cidr
-      min2   = min_second_octet cidr
-      min3   = min_third_octet cidr
-      min4   = min_fourth_octet cidr
-      max1   = max_first_octet cidr
-      max2   = max_second_octet cidr
-      max3   = max_third_octet cidr
-      max4   = max_fourth_octet cidr
+      min1   = octet_to_int (min_octet1 (ipv4address cidr) (maskbits cidr))
+      min2   = octet_to_int (min_octet2 (ipv4address cidr) (maskbits cidr))
+      min3   = octet_to_int (min_octet3 (ipv4address cidr) (maskbits cidr))
+      min4   = octet_to_int (min_octet4 (ipv4address cidr) (maskbits cidr))
+      max1   = octet_to_int (max_octet1 (ipv4address cidr) (maskbits cidr))
+      max2   = octet_to_int (max_octet2 (ipv4address cidr) (maskbits cidr))
+      max3   = octet_to_int (max_octet3 (ipv4address cidr) (maskbits cidr))
+      max4   = octet_to_int (max_octet4 (ipv4address cidr) (maskbits cidr))
 
 
 
@@ -86,18 +80,6 @@ numeric_range x y =
        upper = maximum [x,y]
 
 
--- Take a CIDR String, and exit with a failure if it's invalid.
-validate_or_die :: String -> IO ()
-validate_or_die cidr = do
-  if (Cidr.is_valid_cidr cidr)
-    then do
-      return ()
-    else do
-        putStrLn "Error: not valid CIDR notation."
-        exitWith (ExitFailure exit_invalid_cidr)
-
-
-
 main :: IO ()
 main = do
   -- First, check for any errors that occurred while parsing
@@ -124,8 +106,13 @@ main = do
   input <- inputfunc
 
   let cidr_strings = lines input
-  mapM validate_or_die cidr_strings
-  let cidrs = map Cidr.from_string cidr_strings
+  let cidrs = map Cidr.cidr_from_string cidr_strings
+
+  if (any (== Cidr.None) cidrs)
+    then do
+      putStrLn "Error: not valid CIDR notation."
+      exitWith (ExitFailure exit_invalid_cidr)
+    else do -- Nothing
 
   -- Get the mode of operation.
   mode <- CommandLine.parse_mode