eja: use different generator names in subalgebras.

[sage.d.git] / mjo / eja / euclidean_jordan_algebra.py

diff --git a/mjo/eja/euclidean_jordan_algebra.py b/mjo/eja/euclidean_jordan_algebra.py
index bb460194970e3da92709082a81f78c86a6c88d5c..28e2a0b7a7ca354d83b77708382bb17b04028072 100644 (file)
--- a/mjo/eja/euclidean_jordan_algebra.py
+++ b/mjo/eja/euclidean_jordan_algebra.py
@@ -199,7 +199,9 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
 
             # It's an algebra of polynomials in one element, and EJAs
             # are power-associative.
-            return FiniteDimensionalEuclideanJordanAlgebra(F, mats, assume_associative=True)
+            #
+            # TODO: choose generator names intelligently.
+            return FiniteDimensionalEuclideanJordanAlgebra(F, mats, assume_associative=True, names='f')
 
 
         def minimal_polynomial(self):
@@ -242,18 +244,80 @@ class FiniteDimensionalEuclideanJordanAlgebra(FiniteDimensionalAlgebra):
                 True
 
             """
+            # The element we're going to call "minimal_polynomial()" on.
+            # Either myself, interpreted as an element of a finite-
+            # dimensional algebra, or an element of an associative
+            # subalgebra.
+            elt = None
+
             if self.parent().is_associative():
-                return self.matrix().minimal_polynomial()
+                elt = FiniteDimensionalAlgebraElement(self.parent(), self)
+            else:
+                V = self.span_of_powers()
+                assoc_subalg = self.subalgebra_generated_by()
+                # Mis-design warning: the basis used for span_of_powers()
+                # and subalgebra_generated_by() must be the same, and in
+                # the same order!
+                elt = assoc_subalg(V.coordinates(self.vector()))
 
-            V = self.span_of_powers()
-            assoc_subalg = self.subalgebra_generated_by()
-            # Mis-design warning: the basis used for span_of_powers()
-            # and subalgebra_generated_by() must be the same, and in
-            # the same order!
-            subalg_self = assoc_subalg(V.coordinates(self.vector()))
-            # Recursive call, but should work since the subalgebra is
-            # associative.
-            return subalg_self.minimal_polynomial()
+            # Recursive call, but should work since elt lives in an
+            # associative algebra.
+            return elt.minimal_polynomial()
+
+
+        def is_nilpotent(self):
+            """
+            Return whether or not some power of this element is zero.
+
+            The superclass method won't work unless we're in an
+            associative algebra, and we aren't. However, we generate
+            an assocoative subalgebra and we're nilpotent there if and
+            only if we're nilpotent here (probably).
+
+            TESTS:
+
+            The identity element is never nilpotent::
+
+                sage: set_random_seed()
+                sage: n = ZZ.random_element(2,10).abs()
+                sage: J = eja_rn(n)
+                sage: J.one().is_nilpotent()
+                False
+                sage: J = eja_ln(n)
+                sage: J.one().is_nilpotent()
+                False
+
+            The additive identity is always nilpotent::
+
+                sage: set_random_seed()
+                sage: n = ZZ.random_element(2,10).abs()
+                sage: J = eja_rn(n)
+                sage: J.zero().is_nilpotent()
+                True
+                sage: J = eja_ln(n)
+                sage: J.zero().is_nilpotent()
+                True
+
+            """
+            # The element we're going to call "is_nilpotent()" on.
+            # Either myself, interpreted as an element of a finite-
+            # dimensional algebra, or an element of an associative
+            # subalgebra.
+            elt = None
+
+            if self.parent().is_associative():
+                elt = FiniteDimensionalAlgebraElement(self.parent(), self)
+            else:
+                V = self.span_of_powers()
+                assoc_subalg = self.subalgebra_generated_by()
+                # Mis-design warning: the basis used for span_of_powers()
+                # and subalgebra_generated_by() must be the same, and in
+                # the same order!
+                elt = assoc_subalg(V.coordinates(self.vector()))
+
+            # Recursive call, but should work since elt lives in an
+            # associative algebra.
+            return elt.is_nilpotent()
 
 
         def characteristic_polynomial(self):