-from mjo.eja.eja_subalgebra import FiniteDimensionalEuclideanJordanSubalgebra
-
-
-class FiniteDimensionalEuclideanJordanElementSubalgebra(FiniteDimensionalEuclideanJordanSubalgebra):
- def __init__(self, elt, orthonormalize_basis):
- self._superalgebra = elt.parent()
- category = self._superalgebra.category().Associative()
- V = self._superalgebra.vector_space()
- field = self._superalgebra.base_ring()
-
- # This list is guaranteed to contain all independent powers,
- # because it's the maximal set of powers that could possibly
- # be independent (by a dimension argument).
- powers = [ elt**k for k in range(V.dimension()) ]
- power_vectors = [ p.to_vector() for p in powers ]
- P = matrix(field, power_vectors)
-
- if orthonormalize_basis == False:
- # Echelonize the matrix ourselves, because otherwise the
- # call to P.pivot_rows() below can choose a non-optimal
- # row-reduction algorithm. In particular, scaling can
- # help over AA because it avoids the RecursionError that
- # gets thrown when we have to look too hard for a root.
- #
- # Beware: QQ supports an entirely different set of "algorithm"
- # keywords than do AA and RR.
- algo = None
- if field is not QQ:
- algo = "scaled_partial_pivoting"
+from mjo.eja.eja_subalgebra import FiniteDimensionalEJASubalgebra
+
+
+class FiniteDimensionalEJAElementSubalgebra(FiniteDimensionalEJASubalgebra):
+ def __init__(self, elt, orthonormalize=True, **kwargs):
+ superalgebra = elt.parent()
+
+ # TODO: going up to the superalgebra dimension here is
+ # overkill. We should append p vectors as rows to a matrix
+ # and continually rref() it until the rank stops going
+ # up. When n=10 but the dimension of the algebra is 1, that
+ # can save a shitload of time (especially over AA).
+ powers = tuple( elt**k for k in range(superalgebra.dimension()) )
+ power_vectors = ( p.to_vector() for p in powers )
+ P = matrix(superalgebra.base_ring(), power_vectors)
+
+ # Echelonize the matrix ourselves, because otherwise the
+ # call to P.pivot_rows() below can choose a non-optimal
+ # row-reduction algorithm. In particular, scaling can
+ # help over AA because it avoids the RecursionError that
+ # gets thrown when we have to look too hard for a root.
+ #
+ # Beware: QQ supports an entirely different set of "algorithm"
+ # keywords than do AA and RR.
+ algo = None
+ if superalgebra.base_ring() is not QQ:
+ algo = "scaled_partial_pivoting"